From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44403)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNMEY-00074R-8K
 for guix-patches@gnu.org; Sat, 11 Apr 2020 15:56:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNMEU-0005tR-D7
 for guix-patches@gnu.org; Sat, 11 Apr 2020 15:56:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45574)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jNMEU-0005tN-A9
 for guix-patches@gnu.org; Sat, 11 Apr 2020 15:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNMEU-00041D-8O
 for guix-patches@gnu.org; Sat, 11 Apr 2020 15:56:02 -0400
Subject: [bug#40301] [PATCH] Fixed some issues with the patches.
Resent-Message-ID: <handler.40301.B40301.158663494615427@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu>
Date: Sat, 11 Apr 2020 21:55:36 +0200
In-Reply-To: <87o8ryq9h4.fsf@asu.edu> (John Soo's message of "Sat, 11 Apr 2020
 09:21:27 -0700")
Message-ID: <87a73h3ih3.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40301@debbugs.gnu.org

Hello,

John Soo <jsoo1@asu.edu> writes:

> I rebased these commits on master, moved the build-system field up, and
> put the sha string on the same line as base32. I also moved the
> definition further up in the file to avoid conflicts.

Thank you!

> +(define-public emacs-psc-ide
> +  (package
> +    (name "emacs-psc-ide")
> +    (version "0.0.0")

According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
you need to add a revision number, "0", or "1" at this point.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/purescript-emacs/psc-ide-emacs")
> +         (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))

The commit should be moved in a top-level `let' at the beginning of the
package definition.

> +       (file-name (git-file-name name "0.0.0"))

This should use version, along with the revision number.
> +    (synopsis "Emacs integration for PureScript's psc-ide tool")
> +    (description
> +     "Emacs integration for PureScript's psc-ide tool. Featuring:

Description should be made of full sentences. Also, it might be useful
to explain what "psc-ide" tool is.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou