all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brice Waegeneire <brice@waegenei.re>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 48985@debbugs.gnu.org
Subject: [bug#48985] [PATCH] gnu: libressl: Remove search paths.
Date: Thu, 17 Jun 2021 08:49:32 +0200	[thread overview]
Message-ID: <87a6npyohv.fsf_-_@waegenei.re> (raw)
In-Reply-To: <87wnqto7cl.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 16 Jun 2021 22:57:46 +0200")

Ludovic Courtès <ludo@gnu.org> writes:

> Brice Waegeneire <brice@waegenei.re> skribis:
>> -                            ,(string-append "--with-cacert="
>> -                                            (assoc-ref %build-inputs "libressl")
>> -                                            "/etc/ssl/cert.pem"))
>> +     `(#:configure-flags (list "--with-privsep-user=ntpd"
>> +                               "--localstatedir=/var"
>> +                               (string-append "--with-cacert="
>> +                                              (assoc-ref %build-inputs "libressl")
>> +                                              "/share/libressl-"
>> +                                              ,(package-version libressl)
>> +                                              "/cert.pem"))
>
> So the etc/ssl/cert.pm file name was wrong for a while?

No, the file existed and was used properly.  I forgot to mention
explicitly that libressl used to put it's SSL configuration in etc/ssl,
I moved it to share/libressl-$version/ as does openssl.

> Note: instead of (package-version libressl), we should look at the
> libressl input of ‘this-package’, though it’s probably not big deal
> here.

I tired to correct it, missed. But I have fixed it in the second commit.
:/

> Otherwise LGTM, thanks!

Pushed as 76a9bad380111493b5a1422485f941de799c6c90 and
d65bd74411ab4820318311062b0f327b139a5784.

Cheers,
- Brice




      reply	other threads:[~2021-06-17  6:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 21:24 [bug#48985] [PATCH] gnu: libressl: Remove search paths Brice Waegeneire
2021-06-16 20:57 ` Ludovic Courtès
2021-06-17  6:49   ` Brice Waegeneire [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6npyohv.fsf_-_@waegenei.re \
    --to=brice@waegenei.re \
    --cc=48985@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.