all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan@gmail.com>
Cc: 53879@debbugs.gnu.org
Subject: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Tue, 08 Feb 2022 18:29:27 +0100	[thread overview]
Message-ID: <87a6f1xo5k.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87pmnx4cbx.fsf@gmail.com> (Jai Vetrivelan's message of "Tue, 08 Feb 2022 20:47:38 +0530")

Hello,

Jai Vetrivelan <jaivetrivelan@gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-everywhere.

Thanks. Some comments follow.

> +(define-public emacs-everywhere
> +  ;; No upstream release.  Extract version from main file.
> +  (let ((revision "0") (version "0.0.1")

Nitpick: binding should go to separate lines. However, in this case,
I suggest to move version string right in the "version" field. It will
make life of the updater scripts easier.

> +      (propagated-inputs
> +       (list xclip xdotool xprop xwininfo))

Could you turn those into regular inputs, and patch calls in the
library? Ideally, upstream should turn the location of these executables
into a defcustom. You may want to suggest it to them.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2022-02-08 19:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 15:17 [bug#53879] [PATCH] gnu: Add emacs-everywhere Jai Vetrivelan
2022-02-08 17:29 ` Nicolas Goaziou [this message]
2022-02-08 23:40   ` Jai Vetrivelan
2022-02-08 23:44     ` Nicolas Goaziou
2022-02-09  0:51       ` Jai Vetrivelan
2022-02-09 14:11         ` bug#53879: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6f1xo5k.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=53879@debbugs.gnu.org \
    --cc=jaivetrivelan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.