From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2H5QAzfJAmJcgAAAgWs5BA (envelope-from ) for ; Tue, 08 Feb 2022 20:49:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kDLEADfJAmI6dwAA9RJhRA (envelope-from ) for ; Tue, 08 Feb 2022 20:49:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFFF928722 for ; Tue, 8 Feb 2022 20:49:10 +0100 (CET) Received: from localhost ([::1]:57794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHWU9-00070T-Sn for larch@yhetil.org; Tue, 08 Feb 2022 14:49:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHUJa-0006tK-03 for guix-patches@gnu.org; Tue, 08 Feb 2022 12:30:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHUJW-0004p5-TY for guix-patches@gnu.org; Tue, 08 Feb 2022 12:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHUJW-00044U-Kg for guix-patches@gnu.org; Tue, 08 Feb 2022 12:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53879] [PATCH] gnu: Add emacs-everywhere. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53879 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jai Vetrivelan Cc: 53879@debbugs.gnu.org Received: via spool by 53879-submit@debbugs.gnu.org id=B53879.164434138215601 (code B ref 53879); Tue, 08 Feb 2022 17:30:02 +0000 Received: (at 53879) by debbugs.gnu.org; 8 Feb 2022 17:29:42 +0000 Received: from localhost ([127.0.0.1]:48523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUJC-00043Z-7A for submit@debbugs.gnu.org; Tue, 08 Feb 2022 12:29:42 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUJ7-00043H-2z for 53879@debbugs.gnu.org; Tue, 08 Feb 2022 12:29:41 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 2F6BDC000A; Tue, 8 Feb 2022 17:29:29 +0000 (UTC) From: Nicolas Goaziou References: <87pmnx4cbx.fsf@gmail.com> Date: Tue, 08 Feb 2022 18:29:27 +0100 In-Reply-To: <87pmnx4cbx.fsf@gmail.com> (Jai Vetrivelan's message of "Tue, 08 Feb 2022 20:47:38 +0530") Message-ID: <87a6f1xo5k.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644349750; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Awa9vbNO0f1zMeDhNQRvF2muTP7LqHsjtbG/HtqlCc4=; b=eAMKXlb6D8+MYTjJ+xJ5tZMgjhDiWJyj9t9756uoD0wYGFm7Pg6qhEDrmPEgeZvS8C8qt2 zCFn+qr+XvFcgodRqpkfnadRh6I3bvQh/LRzNvineGp3VIE9ZDpdNfrcE58wLBB4Fbnxk3 k7WGEC9cxzKClLLkU6oyHk3wq19K4iwCMA0WycygacIaM5XlAiNYLdPgNqxd+9nQRxIm3r QIWYXgQzXcc6621mpv+7adVVhYU6UswV8iMQdeCpCcDfyfZemTtwcqIpdVm1iFpczE8egz zjXaVbuFbtMXEYreIr0Kumy9cF8/B3qfabNTqR2As213/c1GJ0zIpUfgYFx+bg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644349750; a=rsa-sha256; cv=none; b=m67EIcJMC+K9UWK/IoGwRj1H/vngwsZ/A9PJWg+DyiXPns0Och4889RFqlsHCGUpe5xtL5 EalBS3TswMOrwvokO/sZHWHduBtiV0xFu9iaK/4o6NRieQdDER3ynJqJJyNjVdcfGLVNMo m6eSkJEkedcReRNbx9t+iXbAh6XIj2PBisV3Jaox4JkUc2EPL46NFhavntp5Ka6MQwGuYj rsOxE03vtCGHf2vpMdw+oGcE1S5jKysmPxTFe8A5xPzRB6+7o9MP2sGp9CAO/vX0WM30/w JW/LOEm76Ht8lAnbvhCAc7Hr2jbEFOUnp7Kyl3Hl1mYXzxlsqpeoO+bp8DqKJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BFFF928722 X-Spam-Score: -3.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: TfiTtBAq2oMK Hello, Jai Vetrivelan writes: > Subject: [PATCH] gnu: Add emacs-everywhere. Thanks. Some comments follow. > +(define-public emacs-everywhere > + ;; No upstream release. Extract version from main file. > + (let ((revision "0") (version "0.0.1") Nitpick: binding should go to separate lines. However, in this case, I suggest to move version string right in the "version" field. It will make life of the updater scripts easier. > + (propagated-inputs > + (list xclip xdotool xprop xwininfo)) Could you turn those into regular inputs, and patch calls in the library? Ideally, upstream should turn the location of these executables into a defcustom. You may want to suggest it to them. Regards, -- Nicolas Goaziou