From: "Ludovic Courtès" <ludo@gnu.org>
To: Eric Bavier <bavier@posteo.net>
Cc: 62406@debbugs.gnu.org
Subject: bug#62406: “! failing-command” pattern in shell tests is wrong
Date: Tue, 28 Mar 2023 18:21:12 +0200 [thread overview]
Message-ID: <87a5zwg83r.fsf@gnu.org> (raw)
In-Reply-To: <75622c7ab52087a4266b7b48374013d0c76d3c53.camel@posteo.net> (Eric Bavier's message of "Thu, 23 Mar 2023 18:53:47 +0000")
Hi Eric,
Eric Bavier <bavier@posteo.net> skribis:
> The purpose of d89343 was to ease visual parsing of the tests. I mentioned
> having used the '!' syntax in my own shell tests, but I realize now that I
> was not relying on `set -e` like guix is.
>
> I'll consider a few options.
Neat. I guess we could have a ‘lib.sh’ with an ‘expect_fail’ function
or something.
> Do we have a known issue where this is causing a test to not to catch
> a failure?
No; I noticed it while writing a new test that I expected to fail.
Thanks for your feedback! Shell semantics are definitely weird. :-)
Ludo’.
next prev parent reply other threads:[~2023-03-28 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:00 bug#62406: “! failing-command” pattern in shell tests is wrong Ludovic Courtès
2023-03-23 18:53 ` Eric Bavier
2023-03-28 16:21 ` Ludovic Courtès [this message]
2023-04-20 5:48 ` Eric Bavier
2023-03-26 18:16 ` Martin Castillo
2023-03-26 18:21 ` Martin Castillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5zwg83r.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=62406@debbugs.gnu.org \
--cc=bavier@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.