From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6ISHGkUUI2RB9QAASxT56A (envelope-from ) for ; Tue, 28 Mar 2023 18:22:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IEyOGUUUI2SP5AAAG6o9tA (envelope-from ) for ; Tue, 28 Mar 2023 18:22:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 361A72386A for ; Tue, 28 Mar 2023 18:22:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phC5D-0003YI-Q8; Tue, 28 Mar 2023 12:22:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phC5C-0003YA-K7 for bug-guix@gnu.org; Tue, 28 Mar 2023 12:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phC5C-0000LS-CG for bug-guix@gnu.org; Tue, 28 Mar 2023 12:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phC5B-0005o5-VC for bug-guix@gnu.org; Tue, 28 Mar 2023 12:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#62406: =?UTF-8?Q?=E2=80=9C!_?= =?UTF-8?Q?failing-command=E2=80=9D?= pattern in shell tests is wrong Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Mar 2023 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Eric Bavier Cc: 62406@debbugs.gnu.org Received: via spool by 62406-submit@debbugs.gnu.org id=B62406.168002048222269 (code B ref 62406); Tue, 28 Mar 2023 16:22:01 +0000 Received: (at 62406) by debbugs.gnu.org; 28 Mar 2023 16:21:22 +0000 Received: from localhost ([127.0.0.1]:50573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phC4Y-0005n7-5H for submit@debbugs.gnu.org; Tue, 28 Mar 2023 12:21:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phC4W-0005mt-71 for 62406@debbugs.gnu.org; Tue, 28 Mar 2023 12:21:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phC4Q-0000I5-QJ; Tue, 28 Mar 2023 12:21:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=uLgC0Zxrb0Rq3Z+wMSR3pSfcH62gxyF6f37W5+GB6oY=; b=VsyxqLgs+n1TdDYnlsVL Tahh8FpudoqJ3iYXpiCNcAORGE5jaqmz/a7/0lBXHiDpX+EtYrFH7+mN1L2B97qbf1JnJsQx+BV7i l1qftQAFSTQixt43Gvf+Tgyh3vjAnfl+x8pIUr8MLsEv2eiV0n+706+EMsu8uCNjw4+GpHw0hs9qn HOpVNKfYEbqRmXSw5cpU7jURvrTk1jC+L/8mvE2ulBOAl9l6T/mPSl6EBOR32jUecyYiqKH5mNz0H RspAjA941CtJzXwt421kWHPvwgivzR2zUmOoBwF5iebZUvMBqAwd6KwW9jvIh0NyJEkdOVrynGRc+ eXmsgDAUAnF7nA==; Received: from [193.50.110.81] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phC4Q-0000CO-2n; Tue, 28 Mar 2023 12:21:14 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y1nn790x.fsf@inria.fr> <75622c7ab52087a4266b7b48374013d0c76d3c53.camel@posteo.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 8 Germinal an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Jonquille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 28 Mar 2023 18:21:12 +0200 In-Reply-To: <75622c7ab52087a4266b7b48374013d0c76d3c53.camel@posteo.net> (Eric Bavier's message of "Thu, 23 Mar 2023 18:53:47 +0000") Message-ID: <87a5zwg83r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680020549; a=rsa-sha256; cv=none; b=HMik0Rb4z07UyqsNMzio2LZIZPELeX4YzIrzNMGTXydHIuQKpeIWMOvbSiJl82uU+6XZ7F tPOs6K0Fr1Ci+iATIhaEOQScrfb3HoN44bdqPTkMqfA30GZJfuTGydjkUGNPXfVpoDLw8v fLdYLC+jf2+7KSPQE43bSXCDWCcWn7BxRGQZuForOqT2BlhTToJRK3+LwAYAn13OQ39A+H shrGPheou8HKcdCb6fB3+Q/r8FE+b5DjqhkNVxcIqdUUJHHz4NjkpfVk5QxheuBkrqdqFG 11rUMmoTVbUPpT7EbBaMGdjw2yo5PwuRAyBcjqIjaVD4WV6ST5mMILFHJo73TQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VsyxqLgs; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680020549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uLgC0Zxrb0Rq3Z+wMSR3pSfcH62gxyF6f37W5+GB6oY=; b=WtYyBTLqN50yRNmKHu3MiRMHVDciPmjWiKw6HWgQs9jJq2PHGP0CxgDvMio63suKBF6OSS IA7MPZH4H/iIY6+rqLJOzbtNjVwh8sknNGD1jIYJIc89vj5xhzASJsaEfboIh7yTpxJxzE JI+/4PukSmreqxkAV0NcnmA5QnHCiFRV0txr3SLMnholOl1KnPLP6IsALdgmrNQK68mA4+ w/XcaGKwQDDh/AlkkOzFcLkSsYpocQNLZ3y2Nwai00QmZmqSzrlS3zN+QIRaXKep8MbuT6 g64V9EEufyEjqcKjDmg/7Tw4gNyrJH0ycVx/Qys33zDTDn26u8ucUC3nNsrL/Q== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VsyxqLgs; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.63 X-Spam-Score: -2.63 X-Migadu-Queue-Id: 361A72386A X-TUID: zGIpIl4dcjAw Hi Eric, Eric Bavier skribis: > The purpose of d89343 was to ease visual parsing of the tests. I mention= ed > having used the '!' syntax in my own shell tests, but I realize now that I > was not relying on `set -e` like guix is. > > I'll consider a few options. Neat. I guess we could have a =E2=80=98lib.sh=E2=80=99 with an =E2=80=98ex= pect_fail=E2=80=99 function or something. > Do we have a known issue where this is causing a test to not to catch > a failure? No; I noticed it while writing a new test that I expected to fail. Thanks for your feedback! Shell semantics are definitely weird. :-) Ludo=E2=80=99.