From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alberto EFG <albertoefg@posteo.mx>
Cc: 40591-done@debbugs.gnu.org
Subject: bug#40591: Add emacs-org-roam
Date: Tue, 14 Apr 2020 11:08:52 +0200 [thread overview]
Message-ID: <878siywi1n.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87h7xovxys.fsf@posteo.mx> (Alberto EFG's message of "Sun, 12 Apr 2020 22:58:03 -0500")
Hello,
Alberto EFG <albertoefg@posteo.mx> writes:
> Added emacs-org-roam. I used it all day, seems like everything works.
Thank you.
I applied your patch with the following changes.
> +(define-public emacs-org-roam
> + (package
> + (name "emacs-org-roam")
The indentation is off. If you use Emacs, you can press M-q, otherwise,
you may call the etc/indent.el script in Guix source tree.
> + (version "1.0.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/jethrokuan/org-roam.git")
> + (commit "1433dbc31602c412914c71ecc81aa5dcf6b03daf")))
When there is an official release, we use the tag. Therefore, I changed
the line above to:
(commit (string-append "v" version))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "08pfa63k194dpk0y2gfa0nzn5lig81q0l9axkq5j4ibj6ifaap4a"))))
Nitpick: I put the string on the line above.
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-company" ,emacs-company)
> + ("emacs-emacsql-sqlite" ,emacs-emacsql)
> + ("emacs-dash" ,emacs-dash)
> + ("emacs-f" ,emacs-f)
> + ("emacs-s" ,emacs-s)
> + ("emacs-org-ref" ,emacs-org-ref)))
I re-ordered the inputs alphabetically.
> + (license license:gpl3)))
The license is actually gpl3+, as written in the source code.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-04-14 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 3:58 [bug#40591] Add emacs-org-roam Alberto EFG
2020-04-14 9:08 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878siywi1n.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40591-done@debbugs.gnu.org \
--cc=albertoefg@posteo.mx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.