From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:57128) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOHZz-0005n9-Aa for guix-patches@gnu.org; Tue, 14 Apr 2020 05:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOHZy-0002GW-8a for guix-patches@gnu.org; Tue, 14 Apr 2020 05:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOHZy-0002GQ-58 for guix-patches@gnu.org; Tue, 14 Apr 2020 05:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOHZy-0004jO-0u for guix-patches@gnu.org; Tue, 14 Apr 2020 05:10:02 -0400 Subject: bug#40591: Add emacs-org-roam Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Nicolas Goaziou References: <87h7xovxys.fsf@posteo.mx> Date: Tue, 14 Apr 2020 11:08:52 +0200 In-Reply-To: <87h7xovxys.fsf@posteo.mx> (Alberto EFG's message of "Sun, 12 Apr 2020 22:58:03 -0500") Message-ID: <878siywi1n.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alberto EFG Cc: 40591-done@debbugs.gnu.org Hello, Alberto EFG writes: > Added emacs-org-roam. I used it all day, seems like everything works. Thank you. I applied your patch with the following changes. > +(define-public emacs-org-roam > + (package > + (name "emacs-org-roam") The indentation is off. If you use Emacs, you can press M-q, otherwise, you may call the etc/indent.el script in Guix source tree. > + (version "1.0.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jethrokuan/org-roam.git") > + (commit "1433dbc31602c412914c71ecc81aa5dcf6b03daf"))) When there is an official release, we use the tag. Therefore, I changed the line above to: (commit (string-append "v" version)) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "08pfa63k194dpk0y2gfa0nzn5lig81q0l9axkq5j4ibj6ifaap4a")))) Nitpick: I put the string on the line above. > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-company" ,emacs-company) > + ("emacs-emacsql-sqlite" ,emacs-emacsql) > + ("emacs-dash" ,emacs-dash) > + ("emacs-f" ,emacs-f) > + ("emacs-s" ,emacs-s) > + ("emacs-org-ref" ,emacs-org-ref))) I re-ordered the inputs alphabetically. > + (license license:gpl3))) The license is actually gpl3+, as written in the source code. Regards, -- Nicolas Goaziou