From: Christopher Baines <mail@cbaines.net>
To: Kozo <Gitlabcanada@runbox.com>
Cc: 40860@debbugs.gnu.org
Subject: [bug#40860] [PATCH] yarnpkg
Date: Sun, 26 Apr 2020 18:42:51 +0100 [thread overview]
Message-ID: <878siinnxg.fsf@cbaines.net> (raw)
In-Reply-To: <1ba1944d95080f01f02a11c2484e7cb9fa75f538.camel@runbox.com>
[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]
Kozo <Gitlabcanada@runbox.com> writes:
> This is my first submission. Please let me know how I can improve for
> future packages.
>
> I followed the steps in the manual and submitted a Software Heritage
> request to pull the source code.
Hi Kozo,
Yarn would indeed be something that would be nice to have a package for.
While I guess that this might work, I think there are issues with the
source here and the lack of dependencies that make this unsuitable for
Guix.
> +(define-public yarn
> + (package
> + (name "yarn")
> + (version yarn-version)
> + (source (origin
> + (method url-fetch/tarbomb)
> + (uri (string-append "https://github.com/yarnpkg/yarn/releases/download/v"
> + version "/yarn-v" version ".tar.gz"))
> + (sha256
> + (base32
> + "0n7vhwjz3lyjnavcaw08cqa8gfampqsy5mm3f555cbqb26m1clxw"))))
The key thing here is source. For many reasons, the packages in Guix
represent software being built from some source material.
What's being downloaded here might look like source material, but I
doubt the ~153,409 line lib/cli.js file is really the preferred form for
editing the Yarn source code.
> + (build-system trivial-build-system)
> + (outputs '("out"))
> + (inputs `(("node" ,node)))
Another sign that something is up is the mismatch between the inputs
here, and the dependencies in the upstream metadata [1]. Assuming the
package works, I'm guessing that there's a lot more than the source of
Yarn within the "source" of this package.
1: https://github.com/yarnpkg/yarn/blob/master/package.json
I'm hopeful that package Yarn will become possible sometime soon, but in
my mind the path forward is to get an importer working for npm, package
the many dependencies, then attempt to package yarn.
Unfortunately I don't think there's a bug that tracks this overall issue
well, although I did find a similar bug about yarn [2]
2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33431
Does that make sense?
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-04-26 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 2:15 [bug#40860] [PATCH] yarnpkg Kozo
2020-04-26 17:42 ` Christopher Baines [this message]
2020-04-26 18:16 ` Jakub Kądziołka
2020-04-27 14:10 ` [bug#40860] [PATCH] Yarnpkg Kozo
2020-04-27 18:28 ` bug#40860: " Björn Höfling
2020-05-04 19:28 ` [bug#40860] (no subject) Kozo via web
2020-05-05 7:08 ` Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878siinnxg.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=40860@debbugs.gnu.org \
--cc=Gitlabcanada@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.