From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59338) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSlJ1-0003fm-HY for guix-patches@gnu.org; Sun, 26 Apr 2020 13:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSlJ0-0005Mu-Ui for guix-patches@gnu.org; Sun, 26 Apr 2020 13:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSlJ0-0005Mp-Ih for guix-patches@gnu.org; Sun, 26 Apr 2020 13:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSlJ0-0000VG-Gu for guix-patches@gnu.org; Sun, 26 Apr 2020 13:43:02 -0400 Subject: [bug#40860] [PATCH] yarnpkg Resent-Message-ID: References: <1ba1944d95080f01f02a11c2484e7cb9fa75f538.camel@runbox.com> From: Christopher Baines In-reply-to: <1ba1944d95080f01f02a11c2484e7cb9fa75f538.camel@runbox.com> Date: Sun, 26 Apr 2020 18:42:51 +0100 Message-ID: <878siinnxg.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kozo Cc: 40860@debbugs.gnu.org --=-=-= Content-Type: text/plain Kozo writes: > This is my first submission. Please let me know how I can improve for > future packages. > > I followed the steps in the manual and submitted a Software Heritage > request to pull the source code. Hi Kozo, Yarn would indeed be something that would be nice to have a package for. While I guess that this might work, I think there are issues with the source here and the lack of dependencies that make this unsuitable for Guix. > +(define-public yarn > + (package > + (name "yarn") > + (version yarn-version) > + (source (origin > + (method url-fetch/tarbomb) > + (uri (string-append "https://github.com/yarnpkg/yarn/releases/download/v" > + version "/yarn-v" version ".tar.gz")) > + (sha256 > + (base32 > + "0n7vhwjz3lyjnavcaw08cqa8gfampqsy5mm3f555cbqb26m1clxw")))) The key thing here is source. For many reasons, the packages in Guix represent software being built from some source material. What's being downloaded here might look like source material, but I doubt the ~153,409 line lib/cli.js file is really the preferred form for editing the Yarn source code. > + (build-system trivial-build-system) > + (outputs '("out")) > + (inputs `(("node" ,node))) Another sign that something is up is the mismatch between the inputs here, and the dependencies in the upstream metadata [1]. Assuming the package works, I'm guessing that there's a lot more than the source of Yarn within the "source" of this package. 1: https://github.com/yarnpkg/yarn/blob/master/package.json I'm hopeful that package Yarn will become possible sometime soon, but in my mind the path forward is to get an importer working for npm, package the many dependencies, then attempt to package yarn. Unfortunately I don't think there's a bug that tracks this overall issue well, although I did find a similar bug about yarn [2] 2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33431 Does that make sense? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6lyBtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeGpQ/6A9mixGXc2IobxUkE0RnjK5iQkdA4viJxOjnY8rZjvr6nhTIChOorcP8E UYrEePzYYCi7AzIq0EED6ZQShf0auoajzkZhHdVeLsNnvl7mQ/VfQ1H3/Z/GvNy6 Ma66Dsko07DlqQzX8aCNZ7A+XVfr/yewg9NHRtSP3hRiyCfAtQT1Tt3ceViMLqny 9T1rcBZLZtHUldDOcx5t2NMC2e+jBlLj61NqWv2YfRmjI1H4/CZHPHzUBUp6Qphm 3ZQBjG3CzQPWf4etk8KIKNxAOfwxgLC8EfVYYgSV4+vQmDy5VRp8VGcH2xhw1vCo FYDhyT29SpqBw4rQ5eT+gedyvdxK7EOPJkVvmAHXa7vFT8B1yLyBvEVvErtCohD9 yz3EXg6FSz5kAYezq4k/h155MHvQflPSidizhI4i2k90fp+3Y3hwAoTqz8EZ+D45 O3zw+9ItRafCceR6lBzG1XUD2E5MKUqKPAsJtmg68931DYQ1QNgjPBocDBgBhW3g RltUV01kqCjYz1PVVDaoyucNDYoMXvKsYNjA8YBdkAyRcsPmtDepRv/KuVCGZfAb LrddrgkpgUOdTSsCTTo8JqXHN8J/P3ZCvStJu+vEcJS9UK2GH9b1SQqsQHtnFaX8 7ipA7YSZpz+vzWRZckfyKKnsvkLtL9DzMk7HZ3r6Syd9V08uSC4= =QUul -----END PGP SIGNATURE----- --=-=-=--