all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Carlo Holl <carloholl@gmail.com>
Cc: 44174@debbugs.gnu.org
Subject: [bug#44174] [PATCH 04/16] gnu: Upgrade ghc-doctest.
Date: Sat, 24 Oct 2020 22:29:28 +0100	[thread overview]
Message-ID: <878sbvb9dz.fsf@cbaines.net> (raw)
In-Reply-To: <20201023170544.9860-4-carloholl@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3004 bytes --]


Carlo Holl <carloholl@gmail.com> writes:

> ---
>  gnu/packages/haskell-xyz.scm | 35 ++++++++++++++++++++---------------
>  1 file changed, 20 insertions(+), 15 deletions(-)


For the commit message for this package, I'd write:

gnu: ghc-doctest: Update to 0.16.3.

* gnu/packages/haskell-xyz.scm (ghc-doctest): Update to 0.16.3.
[inputs,native-inputs]: Replace with what is generated by guix import.


> diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
> index 803ee995c0..ad9c49ddeb 100644
> --- a/gnu/packages/haskell-xyz.scm
> +++ b/gnu/packages/haskell-xyz.scm
> @@ -3416,7 +3416,7 @@ Writer monad), where list append quickly becomes too expensive.")
>  (define-public ghc-doctest
>    (package
>      (name "ghc-doctest")
> -    (version "0.16.2")
> +    (version "0.16.3")
>      (source
>       (origin
>         (method url-fetch)
> @@ -3426,26 +3426,31 @@ Writer monad), where list append quickly becomes too expensive.")
>               ".tar.gz"))
>         (sha256
>          (base32
> -         "0lk4cjfzi5bx2snfzw1zi06li0gvgz3ckfh2kwa98l7nxfdl39ag"))))
> +         "1y1l7aa80qkib1z8lsizgg7fpfdmdwhxvi5m255a42jdkjgn5sfg"))))
>      (build-system haskell-build-system)
>      (arguments `(#:tests? #f))          ; FIXME: missing test framework
>      (inputs
> -     `(("ghc-syb" ,ghc-syb)
> -       ("ghc-paths" ,ghc-paths)
> -       ("ghc-base-compat" ,ghc-base-compat)
> -       ("ghc-code-page" ,ghc-code-page)
> -       ("ghc-hunit" ,ghc-hunit)
> -       ("ghc-hspec" ,ghc-hspec)
> -       ("ghc-quickcheck" ,ghc-quickcheck)
> -       ("ghc-stringbuilder" ,ghc-stringbuilder)
> -       ("ghc-silently" ,ghc-silently)
> -       ("ghc-setenv" ,ghc-setenv)))
> +      `(("ghc-base-compat" ,ghc-base-compat)
> +        ("ghc-code-page" ,ghc-code-page)
> +        ("ghc-paths" ,ghc-paths)
> +        ("ghc-syb" ,ghc-syb)))
> +    (native-inputs
> +      `(("ghc-hunit" ,ghc-hunit)
> +        ("ghc-quickcheck" ,ghc-quickcheck)
> +        ("ghc-hspec" ,ghc-hspec)
> +        ("ghc-hspec-core" ,ghc-hspec-core)
> +        ("ghc-mockery" ,ghc-mockery)
> +        ("ghc-setenv" ,ghc-setenv)
> +        ("ghc-silently" ,ghc-silently)
> +        ("ghc-stringbuilder" ,ghc-stringbuilder)))

Here you can see the slightly off indentation, the previous level of
indentation is what I'd use.

>      (home-page
>       "https://github.com/sol/doctest#readme")
>      (synopsis "Test interactive Haskell examples")
> -    (description "The doctest program checks examples in source code comments.
> -It is modeled after doctest for Python, see
> -@uref{https://docs.python.org/library/doctest.html, the Doctest website}.")
> +    (description
> +      "The doctest program checks examples in source code comments.  It is modeled
> +after doctest for Python (@url{http://docs.python.org/library/doctest.html}).
> +
> +Documentation is at @url{https://github.com/sol/doctest#readme}.")
>      (license license:expat)))

I'd keep the previous description, as I think it's better.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2020-10-24 21:30 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  7:46 [bug#44174] [PATCH 00/16] Add hledger and its dependencies Carlo Holl
2020-10-23 17:05 ` [bug#44174] [PATCH 01/16] gnu: Add ghc-control-monad-free Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 02/16] gnu: Add ghc-csv Carlo Holl
2020-10-24 21:27     ` Christopher Baines
2020-10-23 17:05   ` [bug#44174] [PATCH 03/16] gnu: Add ghc-decimal Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 04/16] gnu: Upgrade ghc-doctest Carlo Holl
2020-10-24 21:29     ` Christopher Baines [this message]
2020-10-23 17:05   ` [bug#44174] [PATCH 05/16] gnu: Add ghc-hspec-megaparsec Carlo Holl
2020-10-24 21:30     ` Christopher Baines
2020-10-23 17:05   ` [bug#44174] [PATCH 06/16] gnu: Add ghc-lucid Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 07/16] gnu: Add ghc-only Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 08/16] gnu: Add ghc-text-short Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 09/16] gnu: Add ghc-tabular Carlo Holl
2020-10-24 21:38     ` Christopher Baines
2020-10-23 17:05   ` [bug#44174] [PATCH 10/16] gnu: Add ghc-uglymemo Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 11/16] gnu: Add ghc-wizards Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 12/16] gnu: Add ghc-cassava Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 13/16] gnu: Add ghc-cassava-megaparsec Carlo Holl
2020-10-24 21:39     ` Christopher Baines
2020-10-23 17:05   ` [bug#44174] [PATCH 14/16] gnu: Add ghc-hledger-lib Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 15/16] gnu: Add hledger Carlo Holl
2020-10-23 17:05   ` [bug#44174] [PATCH 16/16] Add attribution Carlo Holl
2020-10-24 21:40     ` Christopher Baines
2020-10-24 21:26 ` [bug#44174] [PATCH 00/16] Add hledger and its dependencies Christopher Baines
2020-11-01  2:11   ` Carlo Holl
2020-11-01  2:02 ` [bug#44174] [PATCH v2 00/15] " Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 01/15] gnu: Add ghc-control-monad-free Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 02/15] gnu: Add ghc-csv Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 03/15] gnu: Add ghc-decimal Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 04/15] gnu: ghc-doctest: Update to 0.16.3 Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 05/15] gnu: Add ghc-hspec-megaparsec Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 06/15] gnu: Add ghc-lucid Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 07/15] gnu: Add ghc-only Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 08/15] gnu: Add ghc-text-short Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 09/15] gnu: Add ghc-tabular Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 10/15] gnu: Add ghc-uglymemo Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 11/15] gnu: Add ghc-wizards Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 12/15] gnu: Add ghc-cassava Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 13/15] gnu: Add ghc-cassava-megaparsec Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 14/15] gnu: Add ghc-hledger-lib Carlo Holl
2020-11-01  2:02   ` [bug#44174] [PATCH v2 15/15] gnu: Add hledger Carlo Holl
2020-11-01 13:38   ` bug#44174: [PATCH v2 00/15] Add hledger and its dependencies Christopher Baines
2020-11-01 18:22     ` [bug#44174] " Ricardo Wurmus
2020-11-01 20:02       ` Haskell package versions (was bug#44174: [PATCH v2 00/15] Add hledger and its dependencies.) Christopher Baines
2020-11-01 20:28         ` Ricardo Wurmus
2020-11-02 11:23           ` zimoun
2020-11-01 21:09       ` [bug#44174] [PATCH v2 00/15] Add hledger and its dependencies Carlo Holl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sbvb9dz.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44174@debbugs.gnu.org \
    --cc=carloholl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.