From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 7/ssJOOclF9ZWAAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 21:30:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id Fi+KH+OclF/vaQAAbx9fmQ (envelope-from ) for ; Sat, 24 Oct 2020 21:30:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 169CD9404CA for ; Sat, 24 Oct 2020 21:30:11 +0000 (UTC) Received: from localhost ([::1]:56054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWR73-00086c-Tk for larch@yhetil.org; Sat, 24 Oct 2020 17:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWR6w-00085O-MJ for guix-patches@gnu.org; Sat, 24 Oct 2020 17:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWR6w-00028W-Cj for guix-patches@gnu.org; Sat, 24 Oct 2020 17:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWR6w-0007CD-70 for guix-patches@gnu.org; Sat, 24 Oct 2020 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44174] [PATCH 04/16] gnu: Upgrade ghc-doctest. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carlo Holl Cc: 44174@debbugs.gnu.org Received: via spool by 44174-submit@debbugs.gnu.org id=B44174.160357497327606 (code B ref 44174); Sat, 24 Oct 2020 21:30:02 +0000 Received: (at 44174) by debbugs.gnu.org; 24 Oct 2020 21:29:33 +0000 Received: from localhost ([127.0.0.1]:35333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR6S-0007BC-Tc for submit@debbugs.gnu.org; Sat, 24 Oct 2020 17:29:33 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR6R-0007B4-8u for 44174@debbugs.gnu.org; Sat, 24 Oct 2020 17:29:31 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id C463027BBF0; Sat, 24 Oct 2020 22:29:30 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 027c94fb; Sat, 24 Oct 2020 21:29:28 +0000 (UTC) References: <20201023170544.9860-1-carloholl@gmail.com> <20201023170544.9860-4-carloholl@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201023170544.9860-4-carloholl@gmail.com> Date: Sat, 24 Oct 2020 22:29:28 +0100 Message-ID: <878sbvb9dz.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: /7sDHBgP1bZ8 --=-=-= Content-Type: text/plain Carlo Holl writes: > --- > gnu/packages/haskell-xyz.scm | 35 ++++++++++++++++++++--------------- > 1 file changed, 20 insertions(+), 15 deletions(-) For the commit message for this package, I'd write: gnu: ghc-doctest: Update to 0.16.3. * gnu/packages/haskell-xyz.scm (ghc-doctest): Update to 0.16.3. [inputs,native-inputs]: Replace with what is generated by guix import. > diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm > index 803ee995c0..ad9c49ddeb 100644 > --- a/gnu/packages/haskell-xyz.scm > +++ b/gnu/packages/haskell-xyz.scm > @@ -3416,7 +3416,7 @@ Writer monad), where list append quickly becomes too expensive.") > (define-public ghc-doctest > (package > (name "ghc-doctest") > - (version "0.16.2") > + (version "0.16.3") > (source > (origin > (method url-fetch) > @@ -3426,26 +3426,31 @@ Writer monad), where list append quickly becomes too expensive.") > ".tar.gz")) > (sha256 > (base32 > - "0lk4cjfzi5bx2snfzw1zi06li0gvgz3ckfh2kwa98l7nxfdl39ag")))) > + "1y1l7aa80qkib1z8lsizgg7fpfdmdwhxvi5m255a42jdkjgn5sfg")))) > (build-system haskell-build-system) > (arguments `(#:tests? #f)) ; FIXME: missing test framework > (inputs > - `(("ghc-syb" ,ghc-syb) > - ("ghc-paths" ,ghc-paths) > - ("ghc-base-compat" ,ghc-base-compat) > - ("ghc-code-page" ,ghc-code-page) > - ("ghc-hunit" ,ghc-hunit) > - ("ghc-hspec" ,ghc-hspec) > - ("ghc-quickcheck" ,ghc-quickcheck) > - ("ghc-stringbuilder" ,ghc-stringbuilder) > - ("ghc-silently" ,ghc-silently) > - ("ghc-setenv" ,ghc-setenv))) > + `(("ghc-base-compat" ,ghc-base-compat) > + ("ghc-code-page" ,ghc-code-page) > + ("ghc-paths" ,ghc-paths) > + ("ghc-syb" ,ghc-syb))) > + (native-inputs > + `(("ghc-hunit" ,ghc-hunit) > + ("ghc-quickcheck" ,ghc-quickcheck) > + ("ghc-hspec" ,ghc-hspec) > + ("ghc-hspec-core" ,ghc-hspec-core) > + ("ghc-mockery" ,ghc-mockery) > + ("ghc-setenv" ,ghc-setenv) > + ("ghc-silently" ,ghc-silently) > + ("ghc-stringbuilder" ,ghc-stringbuilder))) Here you can see the slightly off indentation, the previous level of indentation is what I'd use. > (home-page > "https://github.com/sol/doctest#readme") > (synopsis "Test interactive Haskell examples") > - (description "The doctest program checks examples in source code comments. > -It is modeled after doctest for Python, see > -@uref{https://docs.python.org/library/doctest.html, the Doctest website}.") > + (description > + "The doctest program checks examples in source code comments. It is modeled > +after doctest for Python (@url{http://docs.python.org/library/doctest.html}). > + > +Documentation is at @url{https://github.com/sol/doctest#readme}.") > (license license:expat))) I'd keep the previous description, as I think it's better. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+UnLhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcseQ//Tcl533Ea/vuXxHVIOlSBhOMAQ2+A266U Ool0Uj9LpPvhjLVqvr0Klqnf2/RonwxGySHVbvr43e/EKkHikuWd2J5rrbQMpvgY yNoknIqRZDFVwQtS3zaPfFDLY/CYeJb1xTVdwsd6XYe6x/sUM+p9Eook5GTe9YEt 4Tcg+PMHZZYJdM/Uqb28S8gL0hkFMa9N1doIoSK9ZgjDL1mp0zMDrEE3p9rwHJI2 7EOJD9ChDe61YN9sfWSvsrL9e4T9AV1drAvUa4UY6K2FfVnrUBipckpJIsEaCena Y8ZCW6Sm30Qgp3TPYmLc6ksfqA/LUsdKF4l+FNjTmXs9xSnHJZY/SmU1zjykJGNa gpVzCix5SpQ2yzunJm45GODjAh9xlDvq3aZhUnlEauUbCXUlQEL47EiiyD/Z1RAT 9m6N9j/IPmkqeB+du7ZrSDSBNE7BZxqVF1kpq9x8XLp/xmz7zKe/0fC94Ixn2ls1 hthXATpMKk1oBYVjemqrgLesgr7tYn+3XUCBy3NqtNcb3zfKeYLL+10R0o9mpKFK hLe/Wl74mBR3WmHcNYiqGwUznqlOjulDCqJCzxtpVEOWWKqdAXfvZT32mCNzdKjE JXeiuLcRI/8aziWdrU4X9iO+I+4IshNU5ID7FJfXi3iv5zwWUJY6tZ39w1aO2mHx JaezaB8JRjo= =UlDf -----END PGP SIGNATURE----- --=-=-=--