From: guix-patches--- via <guix-patches@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 46113@debbugs.gnu.org, 45707-done@debbugs.gnu.org
Subject: [bug#46113] [PATCH] gnu: obs: Update obs to fb347c.
Date: Thu, 04 Feb 2021 11:45:46 +0100 [thread overview]
Message-ID: <878s84861x.fsf@delta.lan> (raw)
In-Reply-To: <87mtwlrz8d.fsf@trop.in> (Andrew Tropin's message of "Wed, 03 Feb 2021 17:40:34 +0300")
Hi Andrew,
Andrew Tropin <andrew@trop.in> writes:
>> Should we wait for the next OBS release instead of packaging an
>> arbitrary commit?
>
> I'm not in a hurry, but as I explained earlier in this thread [fn:2] it seems
> relatively safe for me to use this commit and getting back later to
> 26.1.3 or 26.2.0 or whatever next release will be.
>
>> I am not insist on keeping [1], but I do think that is more cleaner
>> solution.
>
> In terms of implememntation I like that [fn:1] prevents double loading
> of plugins, by excluding obs installation dir from "load-path". However
> double loading of the same plugin doesn't seem to break anything. Also,
> OBS_PLUGINS_DIRECTORY variable name maybe a little better than
> OBS_PLUGINS_PATH as it contains only one path.
>
> The problem is that now there are two almost identical mechanisms (one
> in upstream and one via patch [fn:1]), which can bring some maintanance
> problems in the future.
>
> There are two good option in my opinion:
> - contribute patch from [fn:1] to upstream (reverting OBS_PLUGINS_PATH)
I would go with this one. But the thing is that [fn:1] is specific and
makes sense only for guix. At least from my point of view. So I doubt
that the upstream accept it. But you can try for sure.
> - revert [fn:1] and use OBS_PLUGINS_PATH from upstream
>
> If Alexey ready to contibute OBS_PLUGINS_DIRECTORY patch to obs
> (reverting OBS_PLUGINS_PATH), I would be glad to support it. Otherwise,
> I would prefer to revert [fn:1] and apply this one. To prevent
> maintanance problems in the future.
As I am not a regular obs user, I am afraid I won't be able to find time
for this soon. Feel free to use/delete/revert [fn:1]. It is your call.
> * Footnotes
>
> [fn:2] http://issues.guix.gnu.org/46113
>
> [fn:1] https://issues.guix.gnu.org/45707
>
> --
> Best regards,
> Andrew Tropin
--
Alexey
next prev parent reply other threads:[~2021-02-04 10:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 23:36 [bug#45707] [PATCH] gnu: Add obs-v4l2sink Evan Straw
2021-01-06 23:42 ` Nicolò Balzarotti
2021-01-06 23:45 ` Evan Straw
2021-01-06 23:47 ` [bug#45707] [PATCH v2] " Evan Straw
2021-01-07 0:11 ` Nicolò Balzarotti
2021-01-07 4:37 ` Evan
2021-01-07 8:19 ` Alexey Abramov
2021-01-13 14:35 ` [bug#45707] [PATCH] " Ludovic Courtès
2021-01-15 16:47 ` Alexey Abramov
2021-01-16 21:47 ` Ludovic Courtès
2021-01-20 8:28 ` Alexey Abramov
2021-02-02 9:31 ` bug#45707: " Ludovic Courtès
2021-01-15 17:10 ` [bug#45707] [PATCH v2] " pelzflorian (Florian Pelz)
2021-01-15 19:25 ` Evan Straw
2021-02-02 20:00 ` [bug#45707] (no subject) Andrew Tropin
2021-02-03 14:40 ` [bug#45707] [PATCH] gnu: obs: Update obs to fb347c Andrew Tropin
2021-02-03 21:11 ` [bug#46113] " Ludovic Courtès
2021-02-04 10:45 ` guix-patches--- via [this message]
2021-02-04 12:49 ` bug#46113: " Andrew Tropin
-- strict thread matches above, loose matches on Subject: below --
2021-01-26 15:59 [bug#46113] " Andrew Tropin
2021-01-26 16:26 ` Andrew Tropin
2021-01-27 7:27 ` Alexey Abramov
2021-01-26 21:10 ` Leo Famulari
2021-01-27 9:36 ` Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s84861x.fsf@delta.lan \
--to=guix-patches@gnu.org \
--cc=45707-done@debbugs.gnu.org \
--cc=46113@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=levenson@mmer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.