From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WPnmEuvQG2CiawAA0tVLHw (envelope-from ) for ; Thu, 04 Feb 2021 10:48:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WGmZDuvQG2C4bwAAB5/wlQ (envelope-from ) for ; Thu, 04 Feb 2021 10:48:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F1139402BD for ; Thu, 4 Feb 2021 10:48:11 +0000 (UTC) Received: from localhost ([::1]:39384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7cBG-0001jv-0t for larch@yhetil.org; Thu, 04 Feb 2021 05:48:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7cB8-0001jM-Jp for guix-patches@gnu.org; Thu, 04 Feb 2021 05:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7cB8-0005H5-Ct for guix-patches@gnu.org; Thu, 04 Feb 2021 05:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7cB8-00014l-A2 for guix-patches@gnu.org; Thu, 04 Feb 2021 05:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46113] [PATCH] gnu: obs: Update obs to fb347c. Resent-From: Alexey Abramov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Feb 2021 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46113 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 46113@debbugs.gnu.org, 45707-done@debbugs.gnu.org Received: via spool by 46113-submit@debbugs.gnu.org id=B46113.16124356344075 (code B ref 46113); Thu, 04 Feb 2021 10:48:02 +0000 Received: (at 46113) by debbugs.gnu.org; 4 Feb 2021 10:47:14 +0000 Received: from localhost ([127.0.0.1]:39833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7cAL-00013a-Vp for submit@debbugs.gnu.org; Thu, 04 Feb 2021 05:47:14 -0500 Received: from mail.mmer.org ([178.22.65.174]:49974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7cAJ-00013G-Gs; Thu, 04 Feb 2021 05:47:12 -0500 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id ceee8ec3; Thu, 4 Feb 2021 10:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim; bh=p0+zhCVmQaPFXTwlg/6519k5v25p2lO2HHh08Y FGewk=; b=eqhFDHvg5DYtA5xxg8ngTyugTZXxpy2ZCux6V/TcyHyjmKHNDX+kya uI3hBFfrtIsRF//yb6KzcKzbkKw83DDVaSepr9L8BOy0UobKCloms6lkcas5RK2c 8Z0N7f+wbiUctcAnRp2wa8wi/HE759RV8VFIDB0BeQszAw13Qv7GI= Received: from delta.lan ( [10.147.19.73]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id 9641fd5d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 4 Feb 2021 10:47:03 +0000 (UTC) References: <87mtwlrz8d.fsf@trop.in> Date: Thu, 04 Feb 2021 11:45:46 +0100 In-Reply-To: <87mtwlrz8d.fsf@trop.in> (Andrew Tropin's message of "Wed, 03 Feb 2021 17:40:34 +0300") Message-ID: <878s84861x.fsf@delta.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Alexey Abramov X-ACL-Warn: , Alexey Abramov via Guix-patches From: guix-patches--- via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mmer.org header.s=dkim header.b=eqhFDHvg; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0F1139402BD X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8ehmTJA2Nkfn Hi Andrew, Andrew Tropin writes: >> Should we wait for the next OBS release instead of packaging an >> arbitrary commit? > > I'm not in a hurry, but as I explained earlier in this thread [fn:2] it seems > relatively safe for me to use this commit and getting back later to > 26.1.3 or 26.2.0 or whatever next release will be. > >> I am not insist on keeping [1], but I do think that is more cleaner >> solution. > > In terms of implememntation I like that [fn:1] prevents double loading > of plugins, by excluding obs installation dir from "load-path". However > double loading of the same plugin doesn't seem to break anything. Also, > OBS_PLUGINS_DIRECTORY variable name maybe a little better than > OBS_PLUGINS_PATH as it contains only one path. > > The problem is that now there are two almost identical mechanisms (one > in upstream and one via patch [fn:1]), which can bring some maintanance > problems in the future. > > There are two good option in my opinion: > - contribute patch from [fn:1] to upstream (reverting OBS_PLUGINS_PATH) I would go with this one. But the thing is that [fn:1] is specific and makes sense only for guix. At least from my point of view. So I doubt that the upstream accept it. But you can try for sure. > - revert [fn:1] and use OBS_PLUGINS_PATH from upstream > > If Alexey ready to contibute OBS_PLUGINS_DIRECTORY patch to obs > (reverting OBS_PLUGINS_PATH), I would be glad to support it. Otherwise, > I would prefer to revert [fn:1] and apply this one. To prevent > maintanance problems in the future. As I am not a regular obs user, I am afraid I won't be able to find time for this soon. Feel free to use/delete/revert [fn:1]. It is your call. > * Footnotes > > [fn:2] http://issues.guix.gnu.org/46113 > > [fn:1] https://issues.guix.gnu.org/45707 > > -- > Best regards, > Andrew Tropin -- Alexey