From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Юрий Холодков" <urist.mckorobochka@gmail.com>
Cc: 46620-done@debbugs.gnu.org
Subject: bug#46620: Fixed git patch
Date: Thu, 18 Feb 2021 21:07:34 +0100 [thread overview]
Message-ID: <878s7lcf7d.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAKSYu49pqONusDT99gyYze6s5RPZQ53a5yU=UVFY8+-=OM_b=w@mail.gmail.com> ("Юрий Холодков"'s message of "Thu, 18 Feb 2021 18:37:05 +0000")
Hello,
Юрий Холодков <urist.mckorobochka@gmail.com> writes:
> Subject: [PATCH] gnu: emacs-kbd: new package
I committed your patch with the minor changes detailed below.
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
> "lisp") #t)))))
I moved the lambda on the line below.
> + (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
> files.")
I slightly shortened synopsis and used @file{.kbd}.
> + (description
> + "This minor mode provides syntax highlighting for Lisp-like DSL
> used in kmonad's
> +configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
> sensible
> +parenthesis handling.")
I removed the second sentence in description, since it is not so useful
when trying to explain what the library is about. I also used
@file{.kbd}.
I added a copyright line for you at the top of the "emacs-xyz.scm" file.
I also added an appropriate commit message.
Note that your patch didn't apply cleanly. You may use "git
format-patch". If you did, something else broke your patch somehow.
Thanks!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2021-02-18 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 17:19 [bug#46620] [PATCH] gnu: emacs-kbd: new package Юрий Холодков
2021-02-18 18:37 ` [bug#46620] Fixed git patch Юрий Холодков
2021-02-18 20:07 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s7lcf7d.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=46620-done@debbugs.gnu.org \
--cc=urist.mckorobochka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.