all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#46620] [PATCH] gnu: emacs-kbd: new package
@ 2021-02-18 17:19 Юрий Холодков
  2021-02-18 18:37 ` [bug#46620] Fixed git patch Юрий Холодков
  0 siblings, 1 reply; 3+ messages in thread
From: Юрий Холодков @ 2021-02-18 17:19 UTC (permalink / raw)
  To: 46620

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

---
Hello!
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cb2a5dc56f..c86732a164 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3146,6 +3146,36 @@ depicting stroke orders for all Kanji.  The
collection is a slightly modified
 and limited version of the images provided by the KanjiVG project.")
       (license license:gpl3+))))

+(define-public emacs-kbd
+  ;; Package has no release.  Version is extracted from "Version:" keyword
in
+  ;; main file.
+  (let ((commit "a7f4c9b9770fa6a58895c5f121df82652bb1b737")
+        (revision "0"))
+    (package
+      (name "emacs-kbd")
+      (version (git-version "0.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/slotThe/kbd-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
"0jv9yfsncgf96308c041hvps3jlc151xb0aipm0vasbma3x83ygm"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
"lisp") #t)))))
+      (home-page "https://github.com/slotThe/kbd-mode")
+      (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
files.")
+      (description
+       "This minor mode provides syntax highlighting for Lisp-like DSL
used in kmonad's
+configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
sensible
+parenthesis handling.")
+      (license license:gpl3+))))
+
 (define-public emacs-keycast
   (package
     (name "emacs-keycast")
-- 
2.30.1

[-- Attachment #2: Type: text/html, Size: 2465 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#46620] Fixed git patch
  2021-02-18 17:19 [bug#46620] [PATCH] gnu: emacs-kbd: new package Юрий Холодков
@ 2021-02-18 18:37 ` Юрий Холодков
  2021-02-18 20:07   ` bug#46620: " Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Юрий Холодков @ 2021-02-18 18:37 UTC (permalink / raw)
  To: 46620

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

From 923fe65c1b2461ebe8ecba7b85dcabedcb864e3b Mon Sep 17 00:00:00 2001
From: Yurii Kholodkov <urist.mckorobochka@gmail.com>
Date: Thu, 18 Feb 2021 20:11:10 +0300
Subject: [PATCH] gnu: emacs-kbd: new package

---
Hello!
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cb2a5dc56f..c86732a164 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3146,6 +3146,36 @@ depicting stroke orders for all Kanji.  The
collection is a slightly modified
 and limited version of the images provided by the KanjiVG project.")
       (license license:gpl3+))))

+(define-public emacs-kbd
+  ;; Package has no release.  Version is extracted from "Version:" keyword
in
+  ;; main file.
+  (let ((commit "a7f4c9b9770fa6a58895c5f121df82652bb1b737")
+        (revision "0"))
+    (package
+      (name "emacs-kbd")
+      (version (git-version "0.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/slotThe/kbd-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
"0jv9yfsncgf96308c041hvps3jlc151xb0aipm0vasbma3x83ygm"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
"lisp") #t)))))
+      (home-page "https://github.com/slotThe/kbd-mode")
+      (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
files.")
+      (description
+       "This minor mode provides syntax highlighting for Lisp-like DSL
used in kmonad's
+configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
sensible
+parenthesis handling.")
+      (license license:gpl3+))))
+
 (define-public emacs-keycast
   (package
     (name "emacs-keycast")
-- 
2.30.1

[-- Attachment #2: Type: text/html, Size: 2740 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#46620: Fixed git patch
  2021-02-18 18:37 ` [bug#46620] Fixed git patch Юрий Холодков
@ 2021-02-18 20:07   ` Nicolas Goaziou
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2021-02-18 20:07 UTC (permalink / raw)
  To: Юрий Холодков
  Cc: 46620-done

Hello,

Юрий Холодков <urist.mckorobochka@gmail.com> writes:

> Subject: [PATCH] gnu: emacs-kbd: new package

I committed your patch with the minor changes detailed below.

> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
> "lisp") #t)))))

I moved the lambda on the line below.

> +      (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
> files.")

I slightly shortened synopsis and used @file{.kbd}.

> +      (description
> +       "This minor mode provides syntax highlighting for Lisp-like DSL
> used in kmonad's
> +configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
> sensible
> +parenthesis handling.")

I removed the second sentence in description, since it is not so useful
when trying to explain what the library is about. I also used
@file{.kbd}.

I added a copyright line for you at the top of the "emacs-xyz.scm" file.
I also added an appropriate commit message.

Note that your patch didn't apply cleanly. You may use "git
format-patch". If you did, something else broke your patch somehow.

Thanks!

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-18 20:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 17:19 [bug#46620] [PATCH] gnu: emacs-kbd: new package Юрий Холодков
2021-02-18 18:37 ` [bug#46620] Fixed git patch Юрий Холодков
2021-02-18 20:07   ` bug#46620: " Nicolas Goaziou

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.