From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 53447@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#53447] Introducing ‘GUIX_’-prefixed environment variables
Date: Wed, 26 Jan 2022 13:05:07 +0100 [thread overview]
Message-ID: <878rv2itxo.fsf@gnu.org> (raw)
In-Reply-To: <87wnin2rae.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 25 Jan 2022 20:56:41 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> I like to see this as a bug, so I've opened one as 53514; Guix should
>>> strive to not mess with the host environment, and setting global
>>> variables used by both Guix and a potentially foreign host goes against
>>> this. The proper fix would be to patch all applications in Guix to use
>>> Guix-specific variables, such as GUIX_XDG_DATA_DIRS instead of
>>> XDG_DATA_DIRS.
>>
>> This approach has its appeal (like in the ‘GUIX_PYTHONPATH’ case), but
>> there’s a tension with our other unwritten (?) guideline that we should
>> modify packages as little as possible.
>>
>> Such wide-ranging changes would have the unfortunate effect that they’d
>> make Guix packages “special”: documentation, bug reports, suggestions
>> you’d find online would apply to the “real” package, but maybe not to
>> the Guix one. That is a situation we’d rather avoid IMO.
>
> True; but after people would get a hang that in Guix most environment
> variables would be prefixed with 'GUIX_', I don't think it'd be that big
> of an issue. Maintaining the patches would be where the burden would
> lie, in my opinion.
There are environment variables everywhere; are you suggesting to
GUIX_-prefix them en masse?
That seems neither viable nor desirable to me. And, as Liliana put it,
when will we have GUIX_PATH? :-)
>> ‘XDG_DATA_DIRS’ is a real problem though. In large part that’s because
>> its purpose is too broad—what “data dirs” are we talking about? It
>> would be ideal if we could progressively replace ‘XDG_DATA_DIRS’ search
>> path specifications with more specific environment variables, when they
>> exist, or perhaps by using ‘wrap-program’ instead of having search path
>> specs.
>
> Are there any more specific environment variables that exist that can
> replace XDG_DATA_DIRS? I'm not too knowledgeable about the freedesktop
> specs, but I'm somewhat skeptical? If they don't yet exist, that makes
> this idea much less actionable.
I don’t know. Like I wrote, the two main cases are glib and qt. Why do
we have them use XDG_DATA_DIRS for? This is what we need to
investigate.
I would be less reluctant to patches that add an extra variable in these
two packages (which could be submitted upstream) than GUIX_-prefixing
it.
Ludo’.
next prev parent reply other threads:[~2022-01-26 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 14:13 [bug#53447] [PATCH] doc: Unset environment variables considered harmful Liliana Marie Prikler
2022-01-22 16:04 ` Ludovic Courtès
2022-01-22 17:53 ` Liliana Marie Prikler
2022-01-24 22:27 ` Maxim Cournoyer
2022-01-25 13:29 ` [bug#53447] Introducing ‘GUIX_’-prefixed environment variables Ludovic Courtès
2022-01-26 1:56 ` Maxim Cournoyer
2022-01-26 12:05 ` Ludovic Courtès [this message]
2022-01-26 20:03 ` Liliana Marie Prikler
2022-01-27 4:53 ` Maxim Cournoyer
2022-01-25 7:39 ` [bug#53447] [PATCH] doc: Unset environment variables considered harmful Ludovic Courtès
2022-01-25 19:21 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rv2itxo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=53447@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.