* [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
@ 2023-12-20 19:50 Clément Lassieur
2023-12-21 11:23 ` Jonathan Brielmaier via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Clément Lassieur @ 2023-12-20 19:50 UTC (permalink / raw)
To: 67941; +Cc: Clément Lassieur, Clément Lassieur, Jonathan Brielmaier
* gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
phase.
Change-Id: I508dbf0a8133634c329c4c1ff20088752311ff91
---
gnu/packages/gnuzilla.scm | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index b268ae8b7c6d..e0fbabfb68eb 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1092,18 +1092,22 @@ (define-public icecat-minimal
(let* ((lib (string-append #$output "/lib"))
(gtk #$(this-package-input "gtk+"))
(gtk-share (string-append gtk "/share"))
- (ld-libs '#$(map (lambda (label)
- (file-append (this-package-input label) "/lib"))
- '("libpng-apng"
- "libxscrnsaver"
- "mesa"
- "pciutils"
- "mit-krb5"
- "eudev"
- "pulseaudio"
- ;; For the integration of native notifications
- ;; (same reason as icedove)
- "libnotify"))))
+ (ld-libs '#$(cons
+ (file-append
+ (this-package-input "libcanberra")
+ "/lib/gtk-3.0/modules")
+ (map (lambda (label)
+ (file-append (this-package-input label) "/lib"))
+ '("libpng-apng"
+ "libxscrnsaver"
+ "mesa"
+ "pciutils"
+ "mit-krb5"
+ "eudev"
+ "pulseaudio"
+ ;; For the integration of native notifications
+ ;; (same reason as icedove)
+ "libnotify")))))
(wrap-program (car (find-files lib "^icecat$"))
`("XDG_DATA_DIRS" prefix (,gtk-share))
;; The following line is commented out because the icecat
base-commit: bb3ab24a296ffa5273b2e82a02ed057e90c095f3
prerequisite-patch-id: 51e2c2aaf5262d0d9001b0b5c37836060291f55d
prerequisite-patch-id: ea15ff59ebfaff0fce3c9a1d42a3c345f8618aab
prerequisite-patch-id: 459d954ba63d5c0c15f8b519aa5aef331f218cc6
prerequisite-patch-id: cc5c8cd318ced4bb10d30f2e00b41b1be1309226
prerequisite-patch-id: 32045c6f50d674987ad6be5b15b8f4f010123c37
prerequisite-patch-id: c0b3ddac8628924c3db8daf2d9694e0de9fb7e5e
prerequisite-patch-id: 9c1d2bed61258b47220ac60fbb889348877ebfb7
prerequisite-patch-id: 4d717985fc3ba49304969527f92f2d854b677fae
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
2023-12-20 19:50 [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra Clément Lassieur
@ 2023-12-21 11:23 ` Jonathan Brielmaier via Guix-patches via
2023-12-21 12:07 ` Clément Lassieur
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Brielmaier via Guix-patches via @ 2023-12-21 11:23 UTC (permalink / raw)
To: Clément Lassieur, 67941
Salut Clément,
Am 20.12.23 um 20:50 schrieb Clément Lassieur:
> * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
> 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
> phase.
I assume this fixes some problems with sound themes of Icecat? If I
understand correctly what "libcanberra" is supposed to do...
~Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
2023-12-21 11:23 ` Jonathan Brielmaier via Guix-patches via
@ 2023-12-21 12:07 ` Clément Lassieur
2024-01-04 3:39 ` Maxim Cournoyer
0 siblings, 1 reply; 5+ messages in thread
From: Clément Lassieur @ 2023-12-21 12:07 UTC (permalink / raw)
To: Jonathan Brielmaier, 67941
On Thu, Dec 21, 2023, at 11:23 AM, Jonathan Brielmaier wrote:
> Salut Clément,
Hey Jonathan :)
> Am 20.12.23 um 20:50 schrieb Clément Lassieur:
> > * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
> > 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
> > phase.
>
> I assume this fixes some problems with sound themes of Icecat? If I
> understand correctly what "libcanberra" is supposed to do...
It fixes this message on Icecat startup:
Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
I'll add this to the commit message.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
2023-12-21 12:07 ` Clément Lassieur
@ 2024-01-04 3:39 ` Maxim Cournoyer
2024-01-04 10:12 ` bug#67941: " Clément Lassieur
0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2024-01-04 3:39 UTC (permalink / raw)
To: Clément Lassieur; +Cc: 67941, Jonathan Brielmaier
Hello,
Clément Lassieur <clement@lassieur.org> writes:
> On Thu, Dec 21, 2023, at 11:23 AM, Jonathan Brielmaier wrote:
>> Salut Clément,
>
> Hey Jonathan :)
>
>> Am 20.12.23 um 20:50 schrieb Clément Lassieur:
>> > * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
>> > 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
>> > phase.
>>
>> I assume this fixes some problems with sound themes of Icecat? If I
>> understand correctly what "libcanberra" is supposed to do...
>
> It fixes this message on Icecat startup:
>
> Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
> Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
>
> I'll add this to the commit message.
Ping :-). LGTM.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#67941: [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
2024-01-04 3:39 ` Maxim Cournoyer
@ 2024-01-04 10:12 ` Clément Lassieur
0 siblings, 0 replies; 5+ messages in thread
From: Clément Lassieur @ 2024-01-04 10:12 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 67941-done, Jonathan Brielmaier
On Wed, Jan 03 2024, Maxim Cournoyer wrote:
>> It fixes this message on Icecat startup:
>>
>> Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
>> Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
>>
>> I'll add this to the commit message.
>
> Ping :-). LGTM.
Pushed, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-04 10:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 19:50 [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra Clément Lassieur
2023-12-21 11:23 ` Jonathan Brielmaier via Guix-patches via
2023-12-21 12:07 ` Clément Lassieur
2024-01-04 3:39 ` Maxim Cournoyer
2024-01-04 10:12 ` bug#67941: " Clément Lassieur
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.