From: "Suhail Singh" <suhailsingh247@gmail.com>
To: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Cc: 69896@debbugs.gnu.org
Subject: [bug#69896] [PATCH v3] gnu: Add emacs-noman.
Date: Thu, 11 Apr 2024 19:56:25 -0400 [thread overview]
Message-ID: <878r1jmp1y.fsf@gmail.com> (raw)
In-Reply-To: <20240411191605.1308781-1-guix-devel-0brg6a@rdmp.org> (Dale Mellor's message of "Thu, 11 Apr 2024 20:16:05 +0100")
Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:
> Review:
> * Synopsis and description are brief but fine
> * License is correct
> * Patch applies clean, guix lint and guix build --check report no problems
> are introduced
> * Tested by installing, adding '(require 'noman)' to emacs.el, running emacs
> and issuing 'M-x noman<ret>git<ret>' and then navigating the help pages
> (this is actually pretty cool!)
> * *Very* cursory look over the upstream source code shows nothing malicious
Thank you for the review!
I noticed that the v3 patch you sent introduced some changes to v2.
Specifically, the commit and file-name fields were being hard-coded
instead of referencing the version and name. I'm assuming this change
was unintentional and I've reverted it in v4 of the patch.
If, however, the change was intentional, could you please elaborate on
the reasons?
Regards,
--
Suhail
next prev parent reply other threads:[~2024-04-11 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 12:23 [bug#69896] [PATCH] gnu: Add emacs-noman Suhail Singh
2024-04-08 15:36 ` [bug#69896] Difficult to use this package Dale Mellor
2024-04-09 6:11 ` Suhail Singh
2024-04-11 1:43 ` [bug#69896] [PATCH v2] gnu: Add emacs-noman Suhail Singh
2024-04-11 19:16 ` [bug#69896] [PATCH v3] " Dale Mellor
2024-04-11 23:56 ` Suhail Singh [this message]
2024-04-11 23:49 ` [bug#69896] [PATCH v4] " Suhail Singh
2024-04-15 10:15 ` bug#69896: " Nicolas Goaziou via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r1jmp1y.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=69896@debbugs.gnu.org \
--cc=guix-devel-0brg6a@rdmp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.