From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sND9F9J4GGaDMwEAe85BDQ:P1 (envelope-from ) for ; Fri, 12 Apr 2024 01:57:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sND9F9J4GGaDMwEAe85BDQ (envelope-from ) for ; Fri, 12 Apr 2024 01:57:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=DDv3mk5Q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712879826; a=rsa-sha256; cv=none; b=GgoHRNNv+9m+ZGOD+b0X3UrczzXSPzoq0luSDj6+PhZK4MQrZtTde1xyQGiPwWeUJkCLl1 YkvWInF3YymVyUia2tQRfE9B03QZ9qakB6ZSPZKq3kWFkR/yXA29GUHuvnysdm7h0u8tXy RSdeJnppH4/He/o/77bMiEznBJ63tcu8UNss39n72uHrYWjiApncTScrVGqZ3IMZ0nAEqP zoMrfmEsqRNjVcKtUu/tggHDRAvV9ZqLgXSJv46IoYfDG5MQQGg5RZZDe0xk6e96PH9I0H f+EuHsFbrw531RnY5eC6YKAESd3VP23SpF8QNnQ0MWyifL0ViZFXiSlRDYnjkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=DDv3mk5Q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712879826; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Tf0eek+lPxJm2WTjZPHcC12SoXUOJbqb0mF0NFGs95o=; b=LgAGVn75y1aqTckY2NzshXFm4gfhVJLuQnkR6ucoZLXibGjUDh1rE5chQDRSTA0QARK6V4 5CUlq19JnNYm4HuUqCrxa5Jp7F7aOmrBrkkwUOOql5jx3GMxp704yoJmjuX9n7f4sqm6ks YxpU6v/Te9s2duq+Ja4GQrANiHF6YeyS4XjLxvbOymPCOHQDrTY9XxPeZ9XMLAawvm/GZ6 ex2xyYq4Pck+d/0jcChNhXCwoqG/RP3/IIw+8k1G+n7M5lDMzyywb6OJSgeNGodSWUrxKS 92QB3YOQkTPIn1AknGNt7zhlWm1n+AMHKV/CcmbTEH2bmiDEiGsGuG52+HBESg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 278107BD84 for ; Fri, 12 Apr 2024 01:57:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rv4Hq-0001qK-UA; Thu, 11 Apr 2024 19:56:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rv4Hp-0001qA-Ip for guix-patches@gnu.org; Thu, 11 Apr 2024 19:56:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rv4Hp-0001iE-AN for guix-patches@gnu.org; Thu, 11 Apr 2024 19:56:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rv4Hy-0005Z5-Ho; Thu, 11 Apr 2024 19:57:06 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69896] [PATCH v3] gnu: Add emacs-noman. Resent-From: "Suhail Singh" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, Dale Mellor Resent-Date: Thu, 11 Apr 2024 23:57:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69896 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dale Mellor Cc: 69896@debbugs.gnu.org Received: via spool by 69896-submit@debbugs.gnu.org id=B69896.171287981221238 (code B ref 69896); Thu, 11 Apr 2024 23:57:06 +0000 Received: (at 69896) by debbugs.gnu.org; 11 Apr 2024 23:56:52 +0000 Received: from localhost ([127.0.0.1]:57512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rv4Hh-0005WD-78 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 19:56:51 -0400 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]:39980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rv4Ha-0005VF-72 for 69896@debbugs.gnu.org; Thu, 11 Apr 2024 19:56:45 -0400 Received: by mail-qv1-xf43.google.com with SMTP id 6a1803df08f44-69b51bfef23so698926d6.0 for <69896@debbugs.gnu.org>; Thu, 11 Apr 2024 16:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712879786; x=1713484586; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Tf0eek+lPxJm2WTjZPHcC12SoXUOJbqb0mF0NFGs95o=; b=DDv3mk5QMj5OshGkkeHllJRGYntr1DOG0DBwI6jkFcKFG6RpHVgJME0CobupdGBXlK sa3zvI3QsevBid/e88GtnorFTy714AYZD5YMzBllmdTkL9qzXK8bW/T69f56RmujkUvn njsxpNsu29fGHlZaUAXw7bgWW7HC7WXfEwbrFPlfuaa9w4hdXrXVoric1v3/eFKn/pbO Q/+LVfgzFJ3Jo9vE0dhX1NUknEYIG4mvqcMgC42diXtGG6btEu2bMEfmkFktoX5LV2zv C16YITizZl10YrwDSglVoAbtxJ0Rnl7NCc5HspzOlRLTONUUbLVRUFafuYdaKkCHlfsd VJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712879786; x=1713484586; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tf0eek+lPxJm2WTjZPHcC12SoXUOJbqb0mF0NFGs95o=; b=Eh569Go3O9/HIvPLX3udTpcDmKFUcIRmPx0DuhtFsHpTHWheIMwahB29F3Q5bykzAB 02nRQhcI6rbr59Enu/YvVjvvIa8K8EYMxoGhweT9OPs/Qnm4RDV/zN+xQje6IAw1fjhm n5/3MPPXyrbOh7PMQ7PxwqpfJ2vexazz5FdmR/dVEGUf3AzldiN7QBoar9YI139jtrI+ i2iIpzQBDtsbwwOAzQStA4MppXXlLtQxz1UHuWwZ5JOzFsRluV0bwISVZrDpI9mcD5Az NqLsCY5wRqpGt4x9L7Nm6KTVw8wrahc2iPLWUc3gpBxWTpo7GvWnCQlsNz/0PNx5PVti 469w== X-Gm-Message-State: AOJu0YztVAaqlpLSXjfb7/ghX9MwMTaOl59se4m7EWLk+V+WkZUfWn6V OAFCiEKlTVRUOWGBGJeYB16+vQhOKOk/TptvAYjw/RH9EkTJ9Rxn3CmfVab1 X-Google-Smtp-Source: AGHT+IEnsn0rY78hn3OoCgxNdhro0XFDdC93Mx9wzx2dFQMzih/o2G/vzBi0V41g1EgR0BWQoccFSA== X-Received: by 2002:ad4:5c64:0:b0:699:2d88:744f with SMTP id i4-20020ad45c64000000b006992d88744fmr1279073qvh.4.1712879786530; Thu, 11 Apr 2024 16:56:26 -0700 (PDT) Received: from gnus (static-198-54-132-241.cust.tzulo.com. [198.54.132.241]) by smtp.gmail.com with ESMTPSA id d16-20020a05621416d000b0069b477761e7sm1566663qvz.123.2024.04.11.16.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:56:26 -0700 (PDT) From: "Suhail Singh" In-Reply-To: <20240411191605.1308781-1-guix-devel-0brg6a@rdmp.org> (Dale Mellor's message of "Thu, 11 Apr 2024 20:16:05 +0100") References: <8f9780091f344a39655f715faf32e2903cc4dd19.1710850789.git.suhail@bayesians.ca> <20240411191605.1308781-1-guix-devel-0brg6a@rdmp.org> Date: Thu, 11 Apr 2024 19:56:25 -0400 Message-ID: <878r1jmp1y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -3.77 X-Migadu-Queue-Id: 278107BD84 X-Migadu-Spam-Score: -3.77 X-Migadu-Scanner: mx10.migadu.com X-TUID: /pRx/eEobZ1n Dale Mellor writes: > Review: > * Synopsis and description are brief but fine > * License is correct > * Patch applies clean, guix lint and guix build --check report no problems > are introduced > * Tested by installing, adding '(require 'noman)' to emacs.el, running emacs > and issuing 'M-x nomangit' and then navigating the help pages > (this is actually pretty cool!) > * *Very* cursory look over the upstream source code shows nothing malicious Thank you for the review! I noticed that the v3 patch you sent introduced some changes to v2. Specifically, the commit and file-name fields were being hard-coded instead of referencing the version and name. I'm assuming this change was unintentional and I've reverted it in v4 of the patch. If, however, the change was intentional, could you please elaborate on the reasons? Regards, -- Suhail