From: Ricardo Wurmus <rekado@elephly.net>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add clojure.
Date: Tue, 16 Aug 2016 20:45:17 +0200 [thread overview]
Message-ID: <877fbg1rk2.fsf@elephly.net> (raw)
In-Reply-To: <87bn0sc072.fsf@gmail.com>
Alex Vong <alexvong1995@gmail.com> writes:
> Thanks for the review too. The changes looks good to me, excepts that it
> seems 'find-files' will find all files with name matching the regex
> recursively, but `scandir' will only list the files on the 1st
> level.
Ah, I didn’t notice that this is what you were trying to do there.
Using “scandir” is fine then.
> Also, I realize there is a typo in my original patch. It should be
> 'under' instead of 'under under' in the comment.
Excellent! Pushed to master as
8293b116e64f543848f4845723208973aeb993f9. Thank you for your
perseverance!
~~ Ricardo
next prev parent reply other threads:[~2016-08-16 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:54 [PATCH] gnu: Add clojure Alex Vong
2016-07-13 15:49 ` Ricardo Wurmus
2016-07-14 13:22 ` Alex Vong
2016-07-24 21:15 ` Ricardo Wurmus
2016-07-26 12:45 ` Alex Vong
2016-07-26 20:00 ` Ricardo Wurmus
2016-07-27 6:47 ` Alex Vong
2016-08-15 12:20 ` Ricardo Wurmus
2016-08-16 13:28 ` Alex Vong
2016-08-16 18:45 ` Ricardo Wurmus [this message]
2016-08-16 18:56 ` Pjotr Prins
-- strict thread matches above, loose matches on Subject: below --
2016-02-24 20:46 Federico Beffa
2016-02-26 11:56 ` Alex Vong
2016-02-27 8:27 ` Federico Beffa
2016-02-27 11:51 ` Ricardo Wurmus
2016-02-24 5:03 Alex Vong
2016-02-24 11:33 ` Ricardo Wurmus
2016-02-24 15:45 ` Alex Vong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fbg1rk2.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=alexvong1995@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.