From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: Add clojure.
Date: Tue, 16 Aug 2016 20:45:17 +0200
Message-ID: <877fbg1rk2.fsf@elephly.net>
References: <87r3b7gc4d.fsf@gmail.com> <8737ndiln5.fsf@elephly.net>
	<87h9bs4amm.fsf@gmail.com> <87twfe7n6t.fsf@elephly.net>
	<87h9bc36wg.fsf@gmail.com> <87y44okw3r.fsf@elephly.net>
	<87bn1j60i5.fsf@gmail.com> <87inv21aw5.fsf@elephly.net>
	<87bn0sc072.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bZjMf-00068l-MW
	for guix-devel@gnu.org; Tue, 16 Aug 2016 14:45:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bZjMb-0008JY-I6
	for guix-devel@gnu.org; Tue, 16 Aug 2016 14:45:28 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bZjMb-0008J3-9I
	for guix-devel@gnu.org; Tue, 16 Aug 2016 14:45:25 -0400
In-reply-to: <87bn0sc072.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel@gnu.org


Alex Vong <alexvong1995@gmail.com> writes:

> Thanks for the review too. The changes looks good to me, excepts that it
> seems 'find-files' will find all files with name matching the regex
> recursively, but `scandir' will only list the files on the 1st
> level.

Ah, I didn’t notice that this is what you were trying to do there.
Using “scandir” is fine then.

> Also, I realize there is a typo in my original patch. It should be
> 'under' instead of 'under under' in the comment.

Excellent!  Pushed to master as
8293b116e64f543848f4845723208973aeb993f9.  Thank you for your
perseverance!

~~ Ricardo