From: Marius Bakke <marius@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Olivier Dion <olivier.dion@polymtl.ca>
Cc: 53238@debbugs.gnu.org
Subject: bug#53238: [PATCH] gnu: tree: Remove stddata feature.
Date: Sun, 16 Jan 2022 18:04:22 +0100 [thread overview]
Message-ID: <877daz8ve1.fsf@gnu.org> (raw)
In-Reply-To: <87r19bxofo.fsf_-_@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]
Hello!
Apologies for missing this discussion earlier...
Maxim Cournoyer <maxim.cournoyer@gmail.com> skriver:
> Hi,
>
> Olivier Dion <olivier.dion@polymtl.ca> writes:
>
>> On Thu, 13 Jan 2022, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>>> Olivier,
>>>
>>> Thanks again for tracking down this weird bug!
>>>
>>> Olivier Dion via Guix-patches via 写道:
>>>> This feature breaks some UNIX utilities. Fix it by disabling
>>>> the feature.
>>>
>>> Hm… How long would we have to carry this fork? My fear is we'd
>>> do so indefinitely.
>>
>> I've contacted the maintainer asking for removal of the feature in its
>> next release. I'm not sure if this will have some impact. Feel free to
>> do the same at <ice+tree@mama.indstate.edu>, maybe adding more weight
>> in the balance would help.
>>
>>> How about creating a (possibly hidden) tree-without-stddata
>>> package variant, to use as input to packages who currently break
>>> with this feature enabled? That lets us refcount the need for it.
>>
>> It's more than just packages, it's also user scripts that can be broken
>> and believe me when I say that this is not an easy bug to track down ;-).
>
> I'm on the fence about this, it does indeed seem an undesirable change,
> especially since there's a --json option, but I am not the author of the
> 'tree' software.
After some consideration (and emails with tree author), I think the best
solution is to patch 'password-store' so that it DTRT even in the
presence of fd 3.
I sent a patch to that effect upstream:
https://lists.zx2c4.com/pipermail/password-store/2022-January/004563.html
...and have local patches to apply that in Guix and revert
bd4f314bbacaaa56751be3a4769f2082be747d24 and
a40ac6271578ea061a8a07b2adbd6032a690ca70.
WDYT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-01-16 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 20:33 [bug#53238] [PATCH] gnu: tree: Remove stddata feature Olivier Dion via Guix-patches via
2022-01-13 20:44 ` Tobias Geerinckx-Rice via Guix-patches via
2022-01-13 20:57 ` Olivier Dion via Guix-patches via
2022-01-13 22:26 ` Maxim Cournoyer
2022-01-16 17:04 ` Marius Bakke [this message]
2022-01-16 18:06 ` bug#53238: " Leo Famulari
2022-01-17 17:37 ` Marius Bakke
2022-01-13 22:33 ` [bug#53238] " Tobias Geerinckx-Rice via Guix-patches via
2022-01-14 1:55 ` Olivier Dion via Guix-patches via
2022-01-14 2:05 ` Tobias Geerinckx-Rice via Guix-patches via
2022-01-15 14:37 ` bug#53238: " Tobias Geerinckx-Rice via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877daz8ve1.fsf@gnu.org \
--to=marius@gnu.org \
--cc=53238@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.