From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EFGNEWNR5GFGBQEAgWs5BA (envelope-from ) for ; Sun, 16 Jan 2022 18:09:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OCwuDmNR5GG53gAAauVa8A (envelope-from ) for ; Sun, 16 Jan 2022 18:09:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D02E81C67E for ; Sun, 16 Jan 2022 18:09:54 +0100 (CET) Received: from localhost ([::1]:41370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n992O-0006ps-EQ for larch@yhetil.org; Sun, 16 Jan 2022 12:09:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98xj-0001Cw-61 for bug-guix@gnu.org; Sun, 16 Jan 2022 12:05:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n98xi-0006nZ-Nx for bug-guix@gnu.org; Sun, 16 Jan 2022 12:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n98xi-0002Zm-Ic for bug-guix@gnu.org; Sun, 16 Jan 2022 12:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53238: [PATCH] gnu: tree: Remove stddata feature. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 16 Jan 2022 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53238 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Olivier Dion Received: via spool by 53238-submit@debbugs.gnu.org id=B53238.16423526799865 (code B ref 53238); Sun, 16 Jan 2022 17:05:02 +0000 Received: (at 53238) by debbugs.gnu.org; 16 Jan 2022 17:04:39 +0000 Received: from localhost ([127.0.0.1]:44150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n98xH-0002Yz-Du for submit@debbugs.gnu.org; Sun, 16 Jan 2022 12:04:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n98xD-0002Yi-97 for 53238@debbugs.gnu.org; Sun, 16 Jan 2022 12:04:34 -0500 Received: from [2001:470:142:3::e] (port=50126 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98x7-0006go-6C; Sun, 16 Jan 2022 12:04:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=H4BF+36VdH1JD1r5Aqhvf7DytkqXZhhWr8CO8O7xZX8=; b=GjAiW49Y91MZko99QSAZ Vb03GueMjQlvEUgQJWXQ4T7Np5yMUYGw7NWFa1Gk9BvzkRJuDajx6NWuPtUd8xIFEVR/MPjbYhyVz MEY75cqQTeOgPJvKC8uc0ivsP0n0XtBmaYBnyAVdOkQBLMrvYomthNUjnVle8iKFtprH9YiviITcs RpJR90qc0O73ujGm9YWlGWz5ICzBQ9T0X7aVCoh9aZLonRJCLiSHKOeWgKjZiwXoFDgaIg399uU5L cqrnPfqzUwgfu+1A0gSlRrOtK7J8+5foZYyeKvYJrNsncn21RS84bQErCyy+nhZzVPSlk2OEJeky/ 1yN31FcNckjssg==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:57220 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98x7-0006iG-A0; Sun, 16 Jan 2022 12:04:25 -0500 From: Marius Bakke In-Reply-To: <87r19bxofo.fsf_-_@gmail.com> References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87r19bxofo.fsf_-_@gmail.com> Date: Sun, 16 Jan 2022 18:04:22 +0100 Message-ID: <877daz8ve1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 53238@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642352994; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=H4BF+36VdH1JD1r5Aqhvf7DytkqXZhhWr8CO8O7xZX8=; b=mpKvzsrZaNT0DuWPbAgAafOfNCMFTvTWItR+UwsHr9Gwo6bS1S/gYcDZUfdOEpk+bKyGz3 Lt9mCrkVLWwZRyYXrskt9RFUf4uX6ZeD7C63jMrsl95ZZoEs3hUbyVBh6zddQo8I9PNgVd HKgR/i2Nhk2/eVKdeu9tCiLmE/dvzToEV6sS6QNAwCdu8QJVji9A7gVRCyUc4SwFD0dRJa 2viNcjBxW2XUNAXFTkYMOCAX5+kiYwdNY4UlZwyJ4LNskieW9oREk0PcVsn9DYVrnl+Uyz HWJQK56NcRlVgSPpbaKZkrAnLYsuSK8vROgC44XFi+Me9ZtVj8vcaE2VtoQz3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642352994; a=rsa-sha256; cv=none; b=UKp882EUbcpAzvP71xst/YhHmllsdKMrYf2VpjGOeux/ZurchQ8ndMFLniY89TEV7h+aCC EmkCt/q+sMoyJ07/zqPniLtqVGaV4oUMufBmnTt3xtq5CBbG2QX0kosAFo2k8XFd/o4Rru EBaUQBmOPf/ljEzfJPTPIjuB5S8uC1SIC1gy00U3zhNFOOrmMZJaGhAj+CBmfU4cBJKmys kiQg3Vr8uITF1aM4Tbyv2eAGlad1TyCE3rEz7e991zOijHt414VbJPqc47pjVlfM6G8biv kNjdr9zLiAc3epHRzpyghaTEcMkQS65OjK6cq0Opih4uBFh2odknKk3NUfTiSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GjAiW49Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GjAiW49Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D02E81C67E X-Spam-Score: -5.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: duy+KrO5DSUn --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! Apologies for missing this discussion earlier... Maxim Cournoyer skriver: > Hi, > > Olivier Dion writes: > >> On Thu, 13 Jan 2022, Tobias Geerinckx-Rice wrote: >>> Olivier, >>> >>> Thanks again for tracking down this weird bug! >>> >>> Olivier Dion via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A >>>> This feature breaks some UNIX utilities. Fix it by disabling=20 >>>> the feature. >>> >>> Hm=E2=80=A6 How long would we have to carry this fork? My fear is we'= d=20 >>> do so indefinitely. >> >> I've contacted the maintainer asking for removal of the feature in its >> next release. I'm not sure if this will have some impact. Feel free to >> do the same at , maybe adding more weight >> in the balance would help. >> >>> How about creating a (possibly hidden) tree-without-stddata=20 >>> package variant, to use as input to packages who currently break=20 >>> with this feature enabled? That lets us refcount the need for it. >> >> It's more than just packages, it's also user scripts that can be broken >> and believe me when I say that this is not an easy bug to track down ;-). > > I'm on the fence about this, it does indeed seem an undesirable change, > especially since there's a --json option, but I am not the author of the > 'tree' software. After some consideration (and emails with tree author), I think the best solution is to patch 'password-store' so that it DTRT even in the presence of fd 3. I sent a patch to that effect upstream: https://lists.zx2c4.com/pipermail/password-store/2022-January/004563.html ...and have local patches to apply that in Guix and revert bd4f314bbacaaa56751be3a4769f2082be747d24 and a40ac6271578ea061a8a07b2adbd6032a690ca70. WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYeRQFg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeJfgD+Okk6I9IHmRBtxcSgc1WNFLC0/Nwe2obqFYj+ A3fHQEkBALGIax0lOnjRXAtZkxx1B22uM9RXWwEE8w8pseblFqUC =AHF+ -----END PGP SIGNATURE----- --=-=-=--