From: Simon Tournier <zimon.toutoune@gmail.com>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 61977@debbugs.gnu.org
Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed
Date: Fri, 05 May 2023 16:15:18 +0200 [thread overview]
Message-ID: <877ctm7tl5.fsf@gmail.com> (raw)
In-Reply-To: <e442826ed0b778e2f3eb4f2de54fe6c4c114455a.1678013769.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Sun, 5 Mar 2023 11:56:09 +0100")
Hi,
What is the status of this patch?
On dim., 05 mars 2023 at 11:56, Josselin Poiret <dev@jpoiret.xyz> wrote:
> * guix/channels.scm (sexp->channel-introduction): Do it.
> ---
> guix/channels.scm | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/guix/channels.scm b/guix/channels.scm
> index d44e7a0a3a..fc2bf55d65 100644
> --- a/guix/channels.scm
> +++ b/guix/channels.scm
> @@ -256,7 +256,14 @@ (define sexp->channel-introduction
> ('commit commit) ('signer signer)
> _ ...)
> (make-channel-introduction commit (openpgp-fingerprint signer)))
> - (x #f)))
> + (x (raise (condition
> + (&message
> + (message (format #f "channel dependency has an invalid\
> + introduction field")))
> + (&error-location
> + (location
> + (source-properties->location
> + (source-properties x)))))))))
I guess the string needs to use ’(G_ )’ for translation, no?
Cheers,
simon
next prev parent reply other threads:[~2023-05-05 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 10:56 [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Josselin Poiret via Guix-patches via
2023-03-17 22:14 ` Ludovic Courtès
2023-03-18 21:42 ` Josselin Poiret via Guix-patches via
2023-05-05 14:15 ` Simon Tournier [this message]
2023-06-04 9:38 ` bug#61977: " Josselin Poiret via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ctm7tl5.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=61977@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.