From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wL3QLuoPVWRlVgAASxT56A (envelope-from ) for ; Fri, 05 May 2023 16:17:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2FYlLuoPVWQp2AAAG6o9tA (envelope-from ) for ; Fri, 05 May 2023 16:17:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E51A3FDDD for ; Fri, 5 May 2023 16:17:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puwF7-0003QI-RS; Fri, 05 May 2023 10:17:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puwF5-0002tw-15 for guix-patches@gnu.org; Fri, 05 May 2023 10:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puwF4-0001mG-L4 for guix-patches@gnu.org; Fri, 05 May 2023 10:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puwF4-0007zX-AR for guix-patches@gnu.org; Fri, 05 May 2023 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 61977@debbugs.gnu.org Received: via spool by 61977-submit@debbugs.gnu.org id=B61977.168329621930707 (code B ref 61977); Fri, 05 May 2023 14:17:02 +0000 Received: (at 61977) by debbugs.gnu.org; 5 May 2023 14:16:59 +0000 Received: from localhost ([127.0.0.1]:57200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwF1-0007zD-Gc for submit@debbugs.gnu.org; Fri, 05 May 2023 10:16:59 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwEw-0007yD-PW for 61977@debbugs.gnu.org; Fri, 05 May 2023 10:16:58 -0400 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-2ff86a12f88so241818f8f.0 for <61977@debbugs.gnu.org>; Fri, 05 May 2023 07:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683296209; x=1685888209; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=SiD6zY9XR0hc7GHtO0RIhTTPn8+7tY5Bpd3cgRrQ6S4=; b=BWGfRylI+Rm23FJVUd94dkZnZBBl139FrhkTGYWrzS2Fk7yYqijkWIaxoNDBRT8+hr 9dQwQDxxluODMC+v8sTlObOhuoEteRyt/KuPGMKelUBdvKx67nRLa/BUTxLqHT8NTDK/ TAULKzvfhhbii8sMAWcMmrf2Skup2yMjyf7o+5pj6DoTqP/Ji7+YLnAKQvAvdpi8c2Xr TZr5KnLQ5Exi3gN8ktt7o0rdnQ+LHj1n8pEfpYpH6Y9aAyt6FamP9CEdm6t2B6pfjMfj StcdnmRXaYxmF0ebg4Bz9QXjOR9VXm5vc0Mdi4CRYVWyk2NUCdCnnq/DjsxsOrc1um+C RpRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683296209; x=1685888209; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SiD6zY9XR0hc7GHtO0RIhTTPn8+7tY5Bpd3cgRrQ6S4=; b=RPEisI3HfEVQewSbhDC22jOz79IHtVw4I8hftyN0R1Y4trsdDxggSaKCTFi9rU2BR2 MO3VhmK22HP/YT9N68YXHbcP66Fp28TqSyYohfbbhOED013i1JdFGcUdCPEm4WYJvuwg t9lsBMVi7AyxKIFb5MZ37WJcZXrMVQ+gPAY6PmmX7qsU3BryvmpL86o4OjjcvUImoiPZ U3/BTqIij7dW7ngTbHU9NcKpaZa7WIcU3HDebRneizMnke4X4/Qji/QpTMNLsagun68Y a48HoOaQXwCP34SP5gunf16Qco5gFHPs9jkC85RJWAf6eEdmwg+7UMf3Tqkj0tFcRgWr 6Saw== X-Gm-Message-State: AC+VfDwv0WBRBhrqnQNLwAG1gwRR+VabE/exbIZelvipn6wBKFKLQ52A mgZ0/2t8/RXItx94nbiUI/4= X-Google-Smtp-Source: ACHHUZ6QpWcs7u1VoFyGCriBgrM9cEB224O85e7L7iwgH9ZFYZW9z7u3nFM5HRg40kjjy92sJzrJMQ== X-Received: by 2002:adf:eb0d:0:b0:306:3a97:e470 with SMTP id s13-20020adfeb0d000000b003063a97e470mr1204827wrn.5.1683296208956; Fri, 05 May 2023 07:16:48 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id y12-20020adffa4c000000b00306281cfa59sm2565724wrr.47.2023.05.05.07.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 07:16:48 -0700 (PDT) From: Simon Tournier References: Date: Fri, 05 May 2023 16:15:18 +0200 In-Reply-To: (Josselin Poiret's message of "Sun, 5 Mar 2023 11:56:09 +0100") Message-ID: <877ctm7tl5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683296234; a=rsa-sha256; cv=none; b=Kt/0C0nhBX/rar+QBCCjOUCICuuubTWi2wmVDR+tEh/OMAIUM8639WmEp7CdgYgqpjzRan i7/XY17eYtgmtBzsQL5451xvuRKB7Upy/KKtJYD5DoyVui6YhqtBKVUk2MuOJ+qJ6y7leq 81Ej+wh4s8agXasLiAK9YhPSKFUO0sIToBxzLCY8gLvFvd0TkngylECEA1ev9CY5tCAtlY DIdS28dxuB8jUE2161pq1hpZA0IIZtflSoFdOL9grcU4Cmc+Ci/QXOGSNMDiUCK6x2tVqV zhnOwEM3ks1Eyo8H7Q/aBiEydmG/8Ee/fvqxbs27tCvLO5+hhVlXye7Y5kj6KA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BWGfRylI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683296234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SiD6zY9XR0hc7GHtO0RIhTTPn8+7tY5Bpd3cgRrQ6S4=; b=FX1h7nZISmHkVDk9mhgCULS25Rn+ny0RHDsEk+sOcb545D3EEcCNRH70MZ2U1N2G2YrLLk cmsZeWMEEs1ray7768lg/7rOW17ryiNXGyRX/d5f+s8ZdZh67RD7+kyBeTJfRsnvEVYapn HKKSAJsSrsyJxc/ev547B5+C/4ffidtA9dQZeM8nDHc1QojH3sE5kMUgY00varC1a/lNQY zCdVWDHnxwH+o3YjcH2CmiNA4b47kKKcaRw2OEfRyw2K+Dm75LSrHKPCgKAuBA+DjJVqAm oM1omFCOSKFRNN/3U/bd1vL0OvmAtgYTHSf9gsMqSWyl6TpQ+u78JQH3Wom2Hg== X-Migadu-Spam-Score: -2.20 X-Spam-Score: -2.20 X-Migadu-Queue-Id: 8E51A3FDDD X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BWGfRylI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: v5IiPKb6yevT Hi, What is the status of this patch? On dim., 05 mars 2023 at 11:56, Josselin Poiret wrote: > * guix/channels.scm (sexp->channel-introduction): Do it. > --- > guix/channels.scm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/guix/channels.scm b/guix/channels.scm > index d44e7a0a3a..fc2bf55d65 100644 > --- a/guix/channels.scm > +++ b/guix/channels.scm > @@ -256,7 +256,14 @@ (define sexp->channel-introduction > ('commit commit) ('signer signer) > _ ...) > (make-channel-introduction commit (openpgp-fingerprint signer))) > - (x #f))) > + (x (raise (condition > + (&message > + (message (format #f "channel dependency has an invalid\ > + introduction field"))) > + (&error-location > + (location > + (source-properties->location > + (source-properties x))))))))) I guess the string needs to use =E2=80=99(G_ )=E2=80=99 for translation, no? Cheers, simon