all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 66171@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: [bug#66171] [PATCH] gnu: git: Install shell completions.
Date: Mon, 25 Sep 2023 13:51:42 -0400	[thread overview]
Message-ID: <877coe2lap.fsf_-_@gmail.com> (raw)
In-Reply-To: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Sep 2023 21:43:07 +0200")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/version-control.scm (git)[outputs]: Add “completion”.
> [#:phases]: Add ‘install-completion’.
> (git-minimal)[#:phases]: Adjust accordingly.

Did something change in git?  I've always had completion in git, so I'm
not sure what this extra phase does, or when it's useful?  Does it add
*extra* completion or... ?

Also, a completion output seems a bit over the top.  I doubt its weigh
justifies the annoyance of special casing it.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-09-25 17:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 19:43 [bug#66171] [PATCH] gnu: git: Install shell completions Liliana Marie Prikler
2023-09-23 19:43 ` [bug#66171] [PATCH v3] gnu: git: Install zsh completions and git-prompt Liliana Marie Prikler
2023-10-02  3:34   ` Maxim Cournoyer
2023-10-02  4:30     ` Liliana Marie Prikler
2023-10-02  9:12       ` Efraim Flashner
2023-10-04  0:35         ` Maxim Cournoyer
2023-10-10  3:33   ` bug#66171: " Maxim Cournoyer
2023-09-23 19:43 ` [bug#66171] [PATCH v2] gnu: git: Install shell completions Liliana Marie Prikler
2023-09-25 17:51   ` Maxim Cournoyer [this message]
2023-09-25 18:41     ` [bug#66171] [PATCH] " Liliana Marie Prikler
2023-09-26 16:36       ` Maxim Cournoyer
2023-09-28 14:41       ` Efraim Flashner
2023-09-25 11:12 ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877coe2lap.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66171@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.