all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 66171@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: [bug#66171] [PATCH] gnu: git: Install shell completions.
Date: Mon, 25 Sep 2023 20:41:05 +0200	[thread overview]
Message-ID: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> (raw)
In-Reply-To: <877coe2lap.fsf_-_@gmail.com>

Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer:
> Hello,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > * gnu/packages/version-control.scm (git)[outputs]: Add
> > “completion”.
> > [#:phases]: Add ‘install-completion’.
> > (git-minimal)[#:phases]: Adjust accordingly.
> 
> Did something change in git?  I've always had completion in git, so
> I'm not sure what this extra phase does, or when it's useful?  Does
> it add *extra* completion or... ?
Which shell are you using?  If it's zsh, then the completion is baked
in.  If it's bash, idk, I haven't tried.  I personally use this for the
included git-prompt, which allows me to have my prompt look like the
following:

  \u@\h /path/to/guix [$branch env] ($SHLVL) \$

> Also, a completion output seems a bit over the top.  I doubt its
> weigh justifies the annoyance of special casing it.
I special-cased it because it *is* a contrib script, but also as it
might be able to conflict with whatever shell builtins you have.  Now
it isn't particularly likely to do so given that other distros include
it as part of their git-core, but I prefer safe over sorry.

That being said, I could just write it to out if you prefer that.

Cheers




  reply	other threads:[~2023-09-25 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 19:43 [bug#66171] [PATCH] gnu: git: Install shell completions Liliana Marie Prikler
2023-09-23 19:43 ` [bug#66171] [PATCH v2] " Liliana Marie Prikler
2023-09-25 17:51   ` [bug#66171] [PATCH] " Maxim Cournoyer
2023-09-25 18:41     ` Liliana Marie Prikler [this message]
2023-09-26 16:36       ` Maxim Cournoyer
2023-09-28 14:41       ` Efraim Flashner
2023-09-23 19:43 ` [bug#66171] [PATCH v3] gnu: git: Install zsh completions and git-prompt Liliana Marie Prikler
2023-10-02  3:34   ` Maxim Cournoyer
2023-10-02  4:30     ` Liliana Marie Prikler
2023-10-02  9:12       ` Efraim Flashner
2023-10-04  0:35         ` Maxim Cournoyer
2023-10-10  3:33   ` bug#66171: " Maxim Cournoyer
2023-09-25 11:12 ` [bug#66171] [PATCH] gnu: git: Install shell completions Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=66171@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.