all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#33994] [PATCH] gnu: python-pillow: Update to 5.4.0
@ 2019-01-06  6:21 Kei Kebreau
  2019-01-11 23:22 ` Marius Bakke
  0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2019-01-06  6:21 UTC (permalink / raw)
  To: 33994; +Cc: Kei Kebreau

* gnu/packages/python.scm (python-pillow): Update to 5.4.0.
[arguments]: Add 'patch-ldconfig' phase.
[home-page]: Update URL.
---
 gnu/packages/python.scm | 35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index ad5c56427..d7d6d1b8b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4151,17 +4151,17 @@ the OleFileIO module from PIL, the Python Image Library.")
 (define-public python-pillow
   (package
     (name "python-pillow")
-    (version "5.2.0")
+    (version "5.4.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "Pillow" version))
        (sha256
         (base32
-         "1ary9mj2ddllq3lkxgn6aac7qxqiwbcg2pacrl94py58ql9x9czq"))))
+         "0qrkcjszym7ixffg5zphhp8a07w8w11yyc2ylcbdrhwm771z316m"))))
     (build-system python-build-system)
     (native-inputs
-     `(("python-pytest"       ,python-pytest)))
+     `(("python-pytest" ,python-pytest)))
     (inputs
      `(("freetype" ,freetype)
        ("lcms"     ,lcms)
@@ -4173,19 +4173,22 @@ the OleFileIO module from PIL, the Python Image Library.")
     (propagated-inputs
      `(("python-olefile" ,python-olefile)))
     (arguments
-     `(#:phases (modify-phases %standard-phases
-                  (add-after
-                   'install 'check-installed
-                   (lambda* (#:key outputs inputs #:allow-other-keys)
-                     (begin
-                       (setenv "HOME" (getcwd))
-                       ;; Make installed package available for running the
-                       ;; tests
-                       (add-installed-pythonpath inputs outputs)
-                       (invoke "python" "selftest.py" "--installed")
-                       (invoke "python" "-m" "pytest" "-vv"))))
-                 (delete 'check))))
-    (home-page "https://pypi.python.org/pypi/Pillow")
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-ldconfig
+           (lambda _
+             (substitute* "setup.py"
+               (("\\['/sbin/ldconfig', '-p'\\]") "['true']"))))
+         (delete 'check) ; We must run checks after python-pillow is installed.
+         (add-after 'install 'check-installed
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (begin
+               (setenv "HOME" (getcwd))
+               ;; Make installed package available for running the tests.
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "selftest.py" "--installed")
+               (invoke "python" "-m" "pytest" "-vv")))))))
+    (home-page "https://python-pillow.org")
     (synopsis "Fork of the Python Imaging Library")
     (description
      "The Python Imaging Library adds image processing capabilities to your
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#33994] [PATCH] gnu: python-pillow: Update to 5.4.0
  2019-01-06  6:21 [bug#33994] [PATCH] gnu: python-pillow: Update to 5.4.0 Kei Kebreau
@ 2019-01-11 23:22 ` Marius Bakke
  2019-01-12 21:43   ` bug#33994: " Kei Kebreau
  0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2019-01-11 23:22 UTC (permalink / raw)
  To: Kei Kebreau, 33994

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> * gnu/packages/python.scm (python-pillow): Update to 5.4.0.
> [arguments]: Add 'patch-ldconfig' phase.
> [home-page]: Update URL.

LGTM!  I'd prefer the home page change as a separate commit, but no
strong opinion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#33994: [PATCH] gnu: python-pillow: Update to 5.4.0
  2019-01-11 23:22 ` Marius Bakke
@ 2019-01-12 21:43   ` Kei Kebreau
  0 siblings, 0 replies; 3+ messages in thread
From: Kei Kebreau @ 2019-01-12 21:43 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 33994-done

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Kei Kebreau <kkebreau@posteo.net> writes:
>
>> * gnu/packages/python.scm (python-pillow): Update to 5.4.0.
>> [arguments]: Add 'patch-ldconfig' phase.
>> [home-page]: Update URL.
>
> LGTM!  I'd prefer the home page change as a separate commit, but no
> strong opinion.

Thanks for reviewing! I've split the patch and pushed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-12 21:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-06  6:21 [bug#33994] [PATCH] gnu: python-pillow: Update to 5.4.0 Kei Kebreau
2019-01-11 23:22 ` Marius Bakke
2019-01-12 21:43   ` bug#33994: " Kei Kebreau

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.