[bug#40326] Remove deprecated packages

[bug#40326] Remove deprecated packages

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

Hello Guix!

Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.

Regards,
RG.

[-- Attachment #2: old.patch --]
[-- Type: application/octet-stream, Size: 2549 bytes --]

From 79bb5e67cb20a5ff3a9510840b48c93de58e1d3c Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 29 Mar 2020 22:53:07 -0400
Subject: [PATCH 17/17] gnu: packages: telephony: Remove bctoolbox and ortp

* gnu/packages/telephony.scm: Remove bctoolbox and ortp.
---
 gnu/packages/telephony.scm | 46 --------------------------------------
 1 file changed, 46 deletions(-)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 275141776c..bcee2b38dd 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -314,52 +314,6 @@ supporting cryptographic kernel.")
     (home-page "https://github.com/cisco/libsrtp")
     (license license:bsd-3)))
 
-(define-public bctoolbox
-  (package
-    (name "bctoolbox")
-    (version "0.2.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "mirror://savannah/linphone/bctoolbox/bctoolbox-"
-                                  version ".tar.gz"))
-              (sha256
-               (base32
-                "14ivv6bh6qywys6yyb34scy9w78d636xl1f7cyxm3gwx2qv71lx5"))))
-    (build-system gnu-build-system)
-    (arguments '(#:make-flags '("CFLAGS=-fPIC")))
-    (native-inputs
-     `(("cunit" ,cunit)))
-    (inputs
-     `(("mbedtls" ,mbedtls-apache)))
-    (home-page "https://www.linphone.org")
-    (synopsis "Utilities library for linphone software")
-    (description "BCtoolbox is a utilities library used by Belledonne
-Communications software like linphone.")
-    (license license:gpl2+)))
-
-(define-public ortp
-  (package
-    (name "ortp")
-    (version "0.27.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://download.savannah.nongnu.org/"
-                                  "releases/linphone/ortp/sources/ortp-"
-                                  version ".tar.gz"))
-              (sha256
-               (base32
-                "1by0dqdqrj5avzcvjws30g8v5sa61wj12x00sxw0kn1smcrshqgb"))))
-    (build-system gnu-build-system)
-    (inputs
-     `(("bctoolbox" ,bctoolbox)))
-    (native-inputs
-     `(("pkg-config" ,pkg-config)))
-    (home-page "https://linphone.org/")
-    (synopsis "Implementation of the Real-time transport protocol")
-    (description "oRTP is a library implementing the Real-time transport
-protocol (RFC 3550).")
-    (license license:lgpl2.1+)))
-
 (define-public libiax2
   (let ((commit "0e5980f1d78ce462e2d1ed6bc39ff35c8341f201"))
     ;; This is the commit used by the Ring Project.
-- 
2.26.0

[bug#40326] Remove deprecated packages

[Leo Famulari]

On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
> Hello Guix!
> 
> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.

These packages haven't been deprecated, as I understand it. That would
mean they had been defined with the deprecated-package procedure for a
while.

[bug#40326] Remove deprecated packages

[Maxim Cournoyer]

Hello Leo and Raghav,

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
>> Hello Guix!
>>
>> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
>
> These packages haven't been deprecated, as I understand it. That would
> mean they had been defined with the deprecated-package procedure for a
> while.

I think it's hard to understand why this is done here without context.

Raghav has started working on packaging Linphone and has made new
definitions for bctoolbox and ortp in a new (gnu packages linphone)
module.

So these packages are going to be moved rather than be outright
removed.

Raghav, for backward compatibility, when me move or rename a package, we
bind the deprecated symbols using the define-deprecated macro (from
(guix deprecation)).

In this case, it'd look like, for example:

(define-deprecated btcoolbox linphone:bctoolbox)

For an actual example, you can "git show 8ab060b68b3".

Maxim

[bug#40326] Remove deprecated packages

[Maxim Cournoyer]

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello Leo and Raghav,
>
> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
>>> Hello Guix!
>>>
>>> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
>>
>> These packages haven't been deprecated, as I understand it. That would
>> mean they had been defined with the deprecated-package procedure for a
>> while.
>
> I think it's hard to understand why this is done here without context.
>
> Raghav has started working on packaging Linphone and has made new
> definitions for bctoolbox and ortp in a new (gnu packages linphone)
> module.
>
> So these packages are going to be moved rather than be outright
> removed.
>
> Raghav, for backward compatibility, when me move or rename a package, we
> bind the deprecated symbols using the define-deprecated macro (from
> (guix deprecation)).
>
> In this case, it'd look like, for example:
>
> (define-deprecated btcoolbox linphone:bctoolbox)
>
> For an actual example, you can "git show 8ab060b68b3".
>
> Maxim

Sorry, it seems I was wrong about this.  A simple move of a package
definition does not warrant defining deprecation symbols (thanks
Tobias).

The packages should only be removed after (or better yet -- at the same
time) their replacement are added, to prevent breaking someone's
manifest.

Maxim

bug#40326: Remove deprecated packages

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Hi Raghav,

these were used by kopete and bluez-alsa.

I've updated those references too and pushed the result to guix master as
commit 9be3ab7bbe41234d861062e0037d3bd24cbba274.

Still wondering what to do with the "-fPIC" that is now gone from bctoolbox.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40326] Remove deprecated packages

[Raghav Gururajan]

Hi Danny!

> these were used by kopete and bluez-alsa.
> 
> I've updated those references too and pushed the result to guix master as
> commit 9be3ab7bbe41234d861062e0037d3bd24cbba274.

Thank you so much.

> Still wondering what to do with the "-fPIC" that is now gone from bctoolbox.

I think we can deal with when we get any errors related to that in the future. :-)

Regards,
RG.