From: Marius Bakke <marius@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>, 42282-done@debbugs.gnu.org
Subject: bug#42282: [PATCH] gnu: Add ttaenc.
Date: Tue, 21 Jul 2020 00:40:29 +0200 [thread overview]
Message-ID: <875zahhkte.fsf@gnu.org> (raw)
In-Reply-To: <c7890e12e96eea0313dbd06136d7ae09b725642c.camel@zrythm.org>
[-- Attachment #1: Type: text/plain, Size: 2491 bytes --]
Alexandros Theodotou <alex@zrythm.org> writes:
> Hi,
>
> This patch adds the TTA encoder.
[...]
> * gnu/packages/audio.scm (ttaenc): New variable.
[...]
> +(define-public ttaenc
> + (package
> + (name "ttaenc")
> + (version "3.4.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/tta/"
> + "tta/ttaenc-src"
> + "/ttaenc-" version "-src.tgz"))
> + (sha256
> + (base32
> + "1iixpr4b89g9g1hwn8ak8k8iflcww3r5f09a117qdidc2nqcijdj"))))
If you don't use Emacs, please run ./etc/indent-code.el before
submitting packages. :-)
> + (build-system gnu-build-system)
> + (arguments
> + `(#:make-flags
> + (list "CC=gcc" (string-append "INSDIR=" (assoc-ref %outputs "out") "/bin"))
I used (string-append "CC=" ,(cc-for-target)) here to aid
cross-compilation.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; no configure
> + (delete 'check) ; no check
And added #:tests? #f instead of deleting the phase.
> + (add-before 'install 'make-bindir
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/bin"))
> + #t))))))
> + (synopsis "TTA lossless audio encoder")
> + (description
> + "TTA performs lossless compression on multichannel 8,16 and 24 bits
> +data of the Wav audio files. Being lossless means that no data-
> +quality is lost in the compression - when uncompressed, the data will
> +be identical to the original. The compression ratios of TTA depend on
> +the type of music file being compressed, but the compression size
> +will generally range between 30% - 70% of the original. TTA format
> +supports both of ID3v1/v2 and APEv2 tags. Detailed format description
> +is available at http://tta.sourceforge.net")
I removed the last sentence, because that URL just redirects to the home
page and did not actually contain a detailed format description. Also,
it was missing punctuation, and lacked two spaces after the previous
punctuation (did you forget to use 'guix lint'?).
> + (home-page "http://tausoft.org/")
> + (license license:gpl2)))
This is GPL2+, as explicitly stated in the README.
Applied with those changes, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2020-07-20 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 21:44 [bug#42282] [PATCH] gnu: Add ttaenc Alexandros Theodotou
2020-07-20 22:40 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zahhkte.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42282-done@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.