From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WBRiHYQdFl9xUwAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 22:41:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gBEtGYQdFl+QEQAAbx9fmQ (envelope-from ) for ; Mon, 20 Jul 2020 22:41:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC977940220 for ; Mon, 20 Jul 2020 22:41:07 +0000 (UTC) Received: from localhost ([::1]:59544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxeT3-0004wl-Ff for larch@yhetil.org; Mon, 20 Jul 2020 18:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxeT0-0004wX-NZ for guix-patches@gnu.org; Mon, 20 Jul 2020 18:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxeT0-0004tX-Dh for guix-patches@gnu.org; Mon, 20 Jul 2020 18:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxeT0-0000RS-Bf for guix-patches@gnu.org; Mon, 20 Jul 2020 18:41:02 -0400 Subject: bug#42282: [PATCH] gnu: Add ttaenc. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 20 Jul 2020 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou , 42282-done@debbugs.gnu.org Mail-Followup-To: 42282@debbugs.gnu.org, marius@gnu.org, alex@zrythm.org Received: via spool by 42282-done@debbugs.gnu.org id=D42282.15952848511671 (code D ref 42282); Mon, 20 Jul 2020 22:41:02 +0000 Received: (at 42282-done) by debbugs.gnu.org; 20 Jul 2020 22:40:51 +0000 Received: from localhost ([127.0.0.1]:36623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxeSp-0000Qt-98 for submit@debbugs.gnu.org; Mon, 20 Jul 2020 18:40:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxeSk-0000Qd-BF for 42282-done@debbugs.gnu.org; Mon, 20 Jul 2020 18:40:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42689) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxeSd-0004lW-JM; Mon, 20 Jul 2020 18:40:39 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:59664 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxeSc-0007kI-Dg; Mon, 20 Jul 2020 18:40:38 -0400 From: Marius Bakke In-Reply-To: References: Date: Tue, 21 Jul 2020 00:40:29 +0200 Message-ID: <875zahhkte.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: s3gM0jDn1wMp --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > Hi, > > This patch adds the TTA encoder. [...] > * gnu/packages/audio.scm (ttaenc): New variable. [...] =20=20 > +(define-public ttaenc > + (package > + (name "ttaenc") > + (version "3.4.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/tta/" > + "tta/ttaenc-src" > + "/ttaenc-" version "-src.tgz")) > + (sha256 > + (base32 > + "1iixpr4b89g9g1hwn8ak8k8iflcww3r5f09a117qdidc2nqcijdj")))) If you don't use Emacs, please run ./etc/indent-code.el before submitting packages. :-) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags > + (list "CC=3Dgcc" (string-append "INSDIR=3D" (assoc-ref %outputs "= out") "/bin")) I used (string-append "CC=3D" ,(cc-for-target)) here to aid cross-compilation. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ; no configure > + (delete 'check) ; no check And added #:tests? #f instead of deleting the phase. > + (add-before 'install 'make-bindir > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out"))) > + (mkdir-p (string-append out "/bin")) > + #t)))))) > + (synopsis "TTA lossless audio encoder") > + (description > + "TTA performs lossless compression on multichannel 8,16 and 24 bits > +data of the Wav audio files. Being lossless means that no data- > +quality is lost in the compression - when uncompressed, the data will > +be identical to the original. The compression ratios of TTA depend on > +the type of music file being compressed, but the compression size > +will generally range between 30% - 70% of the original. TTA format > +supports both of ID3v1/v2 and APEv2 tags. Detailed format description > +is available at http://tta.sourceforge.net") I removed the last sentence, because that URL just redirects to the home page and did not actually contain a detailed format description. Also, it was missing punctuation, and lacked two spaces after the previous punctuation (did you forget to use 'guix lint'?). > + (home-page "http://tausoft.org/") > + (license license:gpl2))) This is GPL2+, as explicitly stated in the README. Applied with those changes, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8WHV0ACgkQoqBt8qM6 VPpEsggAzAUa9DAiTczuPtTJ74jGIpz1jXq/jGJqLnZdn71VlW3NJBBSj11TdKXq D9i7UotXLE/HpH77UKTd0MMhPE0vh1NKrUbKnWd0QYtw2iyqrzmRAVBuqsxHC8Zb vGaGKOe9AKULY7jTaH2sEcUPcO8KffXWe8J68byBuc7VmHkFkL16428DEvCGC7GK 61hl8iv97ex+3/oJK4kIJKUiR4KlDJD9cxxzFemfxVV8wsdOarn/mo8b5hDxfesh 7bHQQ6ylP5iInvVW6swriKNcxN5PtSI3AocqGMUyGPknwys89hoV7Nnz/lkQmOQP kL2pDJpxQqz4PPPBc6qfhO+fDcMj4A== =JT/S -----END PGP SIGNATURE----- --=-=-=--