From: Xinglu Chen <public@yoctocell.xyz>
To: Olivier Dion <olivier.dion@polymtl.ca>, 50756@debbugs.gnu.org
Subject: [bug#50756] [PATCH] gnu: Add lttng-tools.
Date: Sun, 26 Sep 2021 11:42:18 +0200 [thread overview]
Message-ID: <875yunk70l.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87tuia2ehj.fsf@laura>
[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]
On Fri, Sep 24 2021, Olivier Dion via Guix-patches via wrote:
> On Fri, 24 Sep 2021, Xinglu Chen <public@yoctocell.xyz> wrote:
>> On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote:
>
>>> +(define-public lttng-tools
>>> + (package
>>> + (name "lttng-tools")
>>> + (version "2.12.5")
>>
>> Version 2.13 is available; any reason for not using it?
>
> Would require to bump version of lttng-ust also I think. I prefer to do all of this
> in another patch.
Ah, OK.
>>> + (arguments
>>> + `(#:tests? #f
>>> + #:parallel-tests? #f
>>
>> There is no need to set #:parallel-tests? if #:tests? is set to #f.
>
> During my testing, I noticed that test in parallel are not working
> because of how the lttng-daemon works. So I disable the parallel option
> in order to not forget it when testing will work in the future. I
> should probably add a comment to explain the rationale here.
>
>>> + (propagated-inputs
>>> + `(("libkmod" ,kmod)
>>> + ("modprobe" ,module-init-tools)))
>>
>> Any reason for the labels not being the same as the package?
>
> I follow the naming convention in the description of the project's README
> so it's easier to map the dependencies described by it to Guix's
> packages. I can change this, but I find it more clear that way.
The name of the label is usually the same as the package, so I would
change them to “kmod” and “module-init-tools” respectively.
>>
>>> + (native-inputs
>>> + `(("pkg-config" ,pkg-config)
>>> + ("perl" ,perl)
>>> + ("libpfm4" ,libpfm4)
>>> + ("python" ,python-3)
>>
>> While running the configure script, I get
>>
>> configure: You may configure with --enable-python-bindings if you want Python bindings.
>>
>> So you would have to pass the ‘--enable-python-bindings’ flag, and
>> Python would be needed during runtime as well.
>
> Does it tho? Bindings can be generated at build time. While you would
> require python-3 at runtime to use the bindings, you don't require
> python-3 to use the other tools of the project. I don't mind adding it
> to the inputs, I'm just asking.
True, the user can install always install Python in their profile
themselves.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-26 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:40 [bug#50756] [PATCH] gnu: Add lttng-tools Olivier Dion via Guix-patches via
2021-09-24 14:24 ` Xinglu Chen
2021-09-24 15:13 ` Olivier Dion via Guix-patches via
2021-09-26 9:42 ` Xinglu Chen [this message]
2021-10-13 8:52 ` Ludovic Courtès
2021-10-13 14:41 ` Olivier Dion via Guix-patches via
2021-10-17 15:06 ` [bug#50756] [PATCH v2] " Olivier Dion via Guix-patches via
2021-10-25 12:02 ` bug#50756: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yunk70l.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50756@debbugs.gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.