From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eJpYK7JAUGHXggEAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 11:43:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QB8QJ7JAUGFgfwAA1q6Kng (envelope-from ) for ; Sun, 26 Sep 2021 09:43:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C23E2EF9E for ; Sun, 26 Sep 2021 11:43:14 +0200 (CEST) Received: from localhost ([::1]:39590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUQgj-0001ue-HT for larch@yhetil.org; Sun, 26 Sep 2021 05:43:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUQgY-0001uW-Kz for guix-patches@gnu.org; Sun, 26 Sep 2021 05:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUQgY-0007Yf-D6 for guix-patches@gnu.org; Sun, 26 Sep 2021 05:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUQgY-000408-AR for guix-patches@gnu.org; Sun, 26 Sep 2021 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50756] [PATCH] gnu: Add lttng-tools. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Olivier Dion , 50756@debbugs.gnu.org Received: via spool by 50756-submit@debbugs.gnu.org id=B50756.163264935115341 (code B ref 50756); Sun, 26 Sep 2021 09:43:02 +0000 Received: (at 50756) by debbugs.gnu.org; 26 Sep 2021 09:42:31 +0000 Received: from localhost ([127.0.0.1]:35911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUQg2-0003zM-M7 for submit@debbugs.gnu.org; Sun, 26 Sep 2021 05:42:30 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44476 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUQg1-0003z8-2y for 50756@debbugs.gnu.org; Sun, 26 Sep 2021 05:42:30 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632649339; bh=GmVaEK+iWc148XAa2s0JWVURVsPMOTPXK7F+Hda4y20=; h=From:To:Subject:In-Reply-To:References:Date; b=pU3jt7a5MfrtRXlnI/PjaydhPBLZpuEJclrCnXy0bQtd9DG69dmyNNiG3O/XlgyPf 0593S3aS/qYrpQh44wc/Fxl8cN4DxSarZvxzwDvdXfGWcQbzX4k0IxPSqU10leKCGJ 3+SwRzsIzx807LaeG+0hcsHbZFpyMeoSetNfeq80= In-Reply-To: <87tuia2ehj.fsf@laura> References: <20210923124004.3164-1-olivier.dion@polymtl.ca> <87mto2jbkl.fsf@yoctocell.xyz> <87tuia2ehj.fsf@laura> Date: Sun, 26 Sep 2021 11:42:18 +0200 Message-ID: <875yunk70l.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632649394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=c7AaO1xjBMkolIxT1VctPISvNJxM3oXDF7zxYV/+BMY=; b=i5+k2KbBxbMc9Y8Gp4N/Crahh33xssUHS/Nf2j3Ci/F3uYBuK/4wcNg7qjYWk6gXHwiefK EZ1omaj4qEMfBRxCgOWMRV3FnZSNCpKfjQQPHfAMQ9gYcW7WOlr+otpFk2XQEj/efiNvKr BO+b6cD0vqSvBXsXS8FE0KpOVZ1CcD2WwegTIAYO2Dph4Mr4OQTDbNMLNTvo1uue86CwX4 oVFXo1JrwWId4POeefpL45awVE3dMr9GCYOxd6n1oXOxgnOioQP0YeapxcZDwQONkUbJiZ dGeyNZQFOYp6rArqzIi230+KriCjzNOEZdw9TY9Qge5A9HQuNPwdrSrP5IdNSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632649394; a=rsa-sha256; cv=none; b=GFEpWK3v8QA82GGPEXIzT/mAjGgwO0uN8nHs7iy2V+sxRV+yKhp9FMeWemf52W5mj11fQb Gn8LGEMIUtXh4c8eCvj9aEah2NRsmrzTp1IqWcMwVKrrTW3MHzrlZqp9xNrPMFwEGtdcRZ qmlSKzxARRO5e69rzJAeznji6qupVGk8Mi011EqFZbN8LIgzcL/0oWXDa5O8p/3XMchbSR g9BPADqhxWMByNHqjlWGmgo431GPlz4I4CZMpvlDi4BOk1lxye9j9mmac9plfhFSPK14I9 GAVDT3HdXa3PaqCwa8vCfcXevDOC2nuVdvgyy95d8u6cG1Q5ulwvPxAWKVr0yg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=pU3jt7a5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=pU3jt7a5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5C23E2EF9E X-Spam-Score: -2.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: ltLZtUu3U70V --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Sep 24 2021, Olivier Dion via Guix-patches via wrote: > On Fri, 24 Sep 2021, Xinglu Chen wrote: >> On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote: > >>> +(define-public lttng-tools >>> + (package >>> + (name "lttng-tools") >>> + (version "2.12.5") >> >> Version 2.13 is available; any reason for not using it? > > Would require to bump version of lttng-ust also I think. I prefer to do = all of this > in another patch. Ah, OK. >>> + (arguments >>> + `(#:tests? #f >>> + #:parallel-tests? #f >> >> There is no need to set #:parallel-tests? if #:tests? is set to #f. > > During my testing, I noticed that test in parallel are not working > because of how the lttng-daemon works. So I disable the parallel option > in order to not forget it when testing will work in the future. I > should probably add a comment to explain the rationale here. > >>> + (propagated-inputs >>> + `(("libkmod" ,kmod) >>> + ("modprobe" ,module-init-tools))) >> >> Any reason for the labels not being the same as the package? > > I follow the naming convention in the description of the project's README > so it's easier to map the dependencies described by it to Guix's > packages. I can change this, but I find it more clear that way. The name of the label is usually the same as the package, so I would change them to =E2=80=9Ckmod=E2=80=9D and =E2=80=9Cmodule-init-tools=E2=80= =9D respectively. >> >>> + (native-inputs >>> + `(("pkg-config" ,pkg-config) >>> + ("perl" ,perl) >>> + ("libpfm4" ,libpfm4) >>> + ("python" ,python-3) >> >> While running the configure script, I get >> >> configure: You may configure with --enable-python-bindings if you want= Python bindings. >> >> So you would have to pass the =E2=80=98--enable-python-bindings=E2=80=99= flag, and >> Python would be needed during runtime as well. > > Does it tho? Bindings can be generated at build time. While you would > require python-3 at runtime to use the bindings, you don't require > python-3 to use the other tools of the project. I don't mind adding it > to the inputs, I'm just asking. True, the user can install always install Python in their profile themselves. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFQQHoVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5ag4P/2fBRNy73tVNjITBIYfTlhENNzI6 zf4dz7841A99MBUqsrpb+SDN674SAmi4bUd8+xtsSZTSDIirUqY/MWLT+EgXE5GL r1qDO6DrEgpd8MI/YxKY9EOYVQ7wi+U+RzndroR8CXoIiFbr0q4DHXsJAwNKW8i8 XX5PP++2mbESD0uOydNlvzPvgibHokikwoZXZZLazq03l3seLAOv3HvL+E1zK4fP CqnLTg2XDr9teXA8m/JMgAETcbuZI/Fn52SpOvUH8B2x2QSASPYrS1c7dR2PWd2W fQvRM/MNuG1hjOnuBeTkczSMCpNee/zd4ubXnDV9nftS+/ig0dUwQ8bC/a+uJ3+S hfCdJt4Wh4zZpvfS3xD7ThZtRF5fMrjOFQUh/FBYk/ox2VNXpHarU06DfTuobDPU YWIEQtvTH7jZ1HTTpZfEi0Rcl2e2qgIvORyL4it9g5EXwg7UMkPG0V96gSo5XeYu R7JRjIaE3ZGTy9x+mPDo+MpLmV6wYPZDZ3IV0QJFFKF2L7XDn/ejIavTDACyZl80 LWlwGlRbI7vWgj/9ZsuVIGxTm8+wwcT0X9EvWhs+np6+M7DCZR1b/KoLQpKFT96J 1aEBeLVJbkuraPesMGJEAYDg1TCv4NIN9+0IIHN2JZZMCGEJTNhnKu8okVVzeEm1 ifMoFZUT1OEo0tWb =YSqJ -----END PGP SIGNATURE----- --=-=-=--