From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 49577@debbugs.gnu.org, phodina <phodina@protonmail.com>
Subject: [bug#49577] [PATCH] Add python-pmbootstrap
Date: Tue, 17 May 2022 15:49:44 -0400 [thread overview]
Message-ID: <875ym4hrc7.fsf_-_@gmail.com> (raw)
In-Reply-To: <86lf5zrt0a.fsf_-_@mgsn.dev> (Sarah Morgensen's message of "Wed, 21 Jul 2021 19:18:13 -0700")
Hi phodina,
Sarah Morgensen <iskarian@mgsn.dev> writes:
> Hi!
>
> Thanks for the patch. I have some suggestions for this one as well.
>
> phodina <phodina@protonmail.com> writes:
>
>> Here's updated patch with better package description:
>>
>> ---
>> index d8c3fbec07..a59d065efa 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -985,6 +985,44 @@ and URL-safe UUIDs. UUIDs are generated using the built-in Python @code{uuid}
>> module and then similar looking characters are removed.")
>> (license license:bsd-3)))
>>
>> +(define-public python-pmbootstrap
>> + (package
>> + (name "python-pmbootstrap")
>> + (version "1.32.0")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "pmbootstrap" version))
>> + (sha256
>> + (base32
>> + "1j796f4wrcdrjd7j9m3w3ziiyqq17kskil9bgy893j6sk73fc5q0"))))
>> + (build-system python-build-system)
>> + ;; TODO: Running tests fails
>> + (arguments
>> + '(#:tests? #f))
>
> It is not a good idea to skip tests without knowing why they fail, as
> there could be subtle bugs in the program even if it seems to run. In
> this case, it seems like the reason they're failing is that the pypi
> release strips some directories that are required for testing. Perhaps
> try from the git repo?
>
>> + (inputs
>> + `(("python-pytest" ,python-pytest) ("python-pyopenssl" ,python-pyopenssl)))
>
> Typically test packages are put in native-inputs rather than inputs.
>
>> + (propagated-inputs `(("openssl" ,openssl)))
>
> Is this necessary? If pmbootstrap just uses openssl through pyopenssl,
> it shouldn't be necessary.
>
>> + (home-page "https://www.postmarketos.org")
>> + (synopsis
>> + "A sophisticated chroot / build / flash tool to develop and install
>> +postmarketOS")
>> + (description
>> + "Bootstrap program that abstracts everything in chroots and therefore
>> +basically runs on top of any Linux distribution. Features:
>> +@enumerate
>> +@item chroot setup (distro-independent QEMU user emulation
>> +@item clean chroot shutdown (umount) and zapping
>> +@item build software as packages
>> +@item cross-compile all armhf-packages
>> +@item effective caching out of the box (survives chroot zaps)
>> +@item installation targets
>> +@item flasher abstractions
>> +@item logging
>> +@item security
>> +@end enumerate")
>> + (license #f)))
>
> Please make sure not to skip the license field. It looks like this one
> is gpl3.
>
>> +
>> (define-public python-logwrap
>> (package
>> (name "python-logwrap")
Gentle ping, since the above comments were 42 weeks ago :-)
Thanks,
Maxim
next prev parent reply other threads:[~2022-05-17 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:31 [bug#49577] [PATCH] Add python-pmbootstrap phodina via Guix-patches via
2021-07-18 10:35 ` phodina via Guix-patches via
2021-07-22 2:18 ` Sarah Morgensen
2022-05-17 19:49 ` Maxim Cournoyer [this message]
2022-06-06 21:07 ` phodina via Guix-patches via
2022-12-15 21:51 ` phodina via Guix-patches via
2022-12-16 4:52 ` Maxim Cournoyer
2023-05-25 0:16 ` Maxim Cournoyer
2023-05-29 10:31 ` phodina via Guix-patches via
2023-06-14 2:46 ` Maxim Cournoyer
2023-06-14 3:06 ` jgart via Guix-patches via
2023-03-13 5:21 ` [bug#49577] jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ym4hrc7.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=49577@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.