From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iIPJDIn8g2J97gAAbAwnHQ (envelope-from ) for ; Tue, 17 May 2022 21:50:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YDG8DIn8g2JgiAAAauVa8A (envelope-from ) for ; Tue, 17 May 2022 21:50:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBB8E2C0C6 for ; Tue, 17 May 2022 21:50:32 +0200 (CEST) Received: from localhost ([::1]:56074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nr3DD-0001Gs-UL for larch@yhetil.org; Tue, 17 May 2022 15:50:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nr3Ck-0001E9-7I for guix-patches@gnu.org; Tue, 17 May 2022 15:50:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nr3Cj-0001AY-Ul for guix-patches@gnu.org; Tue, 17 May 2022 15:50:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nr3Cj-0003IB-Sg for guix-patches@gnu.org; Tue, 17 May 2022 15:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49577] [PATCH] Add python-pmbootstrap Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 May 2022 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49577 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49577@debbugs.gnu.org, phodina Received: via spool by 49577-submit@debbugs.gnu.org id=B49577.165281699212634 (code B ref 49577); Tue, 17 May 2022 19:50:01 +0000 Received: (at 49577) by debbugs.gnu.org; 17 May 2022 19:49:52 +0000 Received: from localhost ([127.0.0.1]:58093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nr3Ca-0003Hi-GY for submit@debbugs.gnu.org; Tue, 17 May 2022 15:49:52 -0400 Received: from mail-qv1-f45.google.com ([209.85.219.45]:38764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nr3CZ-0003HT-4g for 49577@debbugs.gnu.org; Tue, 17 May 2022 15:49:51 -0400 Received: by mail-qv1-f45.google.com with SMTP id n10so15146830qvi.5 for <49577@debbugs.gnu.org>; Tue, 17 May 2022 12:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZglGWF5sm2KRNswUPzI15mapXwn88vRMvAL/e4fp7kw=; b=kjh6z/mC8g1DCEjaDQHqOcDV3HOqnDMASZ+OIAUWEQhaA9P/KEHMT7zfOo7XjUKkTT ilCIb76AalMGDx71ewkpORwTtOVKbK5fIzsS4kTAlxS4P0BaTKOqm8QS8YX3orjJJl7r EFybPeQqthurmjGICW8sawoEc7bTQi6LSIS5ffRnvfdT6axP819aNpWK6EwfzF24iECP UY7oW3SA8QbXE2if5znALFVKJgcPI9FUmstuebY4F5txq1cxfsjNOvULtW8juEfryJup vO0sDdlzz8Fo12f9/4vXGyLy7XULsuOORwxTJE8OPlS0o8hl9zdoQygLZmtQfnSG+XUC gYIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZglGWF5sm2KRNswUPzI15mapXwn88vRMvAL/e4fp7kw=; b=niYaMXRjyRdXEvsz1gH1AmnRAlvPmCop3NePmNw00jcwTTyNpBi7XBeKMy/sQHxOBd 9L6/Vpf1rH98LTdpJYZ3yA5ArqzWGn+cxwhTWamrcvCnVCP1MBhDydDBMXHd5SjMmCew h04/reQz0icg+NvgxpZoCrBOIGgGugFczQsmWH58wKySJqAYh08HfRngOX9Od/NxePeY SDZVfcsWqPyu9jzi8EPxuO9d/3/HFzsRteFFnkfl8Uk2yFy8XtzkvBY+IgUXXJU9SO6B AJNhGFZNrK11X27k6qeSY4BqydczeaTsAFnT3N0ZYTggd/8Dz2y6F6UNjMbSnPz57sMy QR4A== X-Gm-Message-State: AOAM530dQteNmdL8+OqnXY/s5HrESj9ABacjwixyeM17KKNCG7t1znVQ /7p41BUj3clO17DIapvRaXCmP4vjap2nJQ== X-Google-Smtp-Source: ABdhPJwo2cIMrzixw67LfmsUmMXdEbB5bsqgxYS7R1KZUEs1Acq+FJAVCBVKKvuk3bIdCyveg5tpHA== X-Received: by 2002:ad4:5c4f:0:b0:443:fd5b:b7ba with SMTP id a15-20020ad45c4f000000b00443fd5bb7bamr21463985qva.0.1652816985356; Tue, 17 May 2022 12:49:45 -0700 (PDT) Received: from hurd (dsl-205-233-124-104.b2b2c.ca. [205.233.124.104]) by smtp.gmail.com with ESMTPSA id c83-20020a379a56000000b0069fc13ce231sm27441qke.98.2022.05.17.12.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 12:49:44 -0700 (PDT) From: Maxim Cournoyer References: <86lf5zrt0a.fsf_-_@mgsn.dev> Date: Tue, 17 May 2022 15:49:44 -0400 In-Reply-To: <86lf5zrt0a.fsf_-_@mgsn.dev> (Sarah Morgensen's message of "Wed, 21 Jul 2021 19:18:13 -0700") Message-ID: <875ym4hrc7.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652817033; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ZglGWF5sm2KRNswUPzI15mapXwn88vRMvAL/e4fp7kw=; b=fZnlQCInL57jybdcX0C2JQ9WThXYEyuafOCdZImR6FuN1SrMdeuhOLGFoZtLqKJt3C+PGV E8Wd06FLwiIosHUEsvHxRKqZ5PWnJ6CZPlse/RpDAkIDJ73U+yBRR5IbxBSxQdUIk21iKx EPykVl+NNFHB7Q7DEQbRsoala3QLMDnOxam22l0dWQZcJeslnAgHtpV5yMt0hTfWaIZfV7 Qk8BtufjHOk4S0lnDyKaZKcGbHOWdpGaTh/3MAgGGUMrtvlfXQuSfVN8WcA1x/s7JjoH39 VRKjcemIJlA+BH78xhFeCSTKSHoAvinGweQAePMosdqKywqCtYt1YbTMApczFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652817033; a=rsa-sha256; cv=none; b=Ou2d7b4vKgj9D5g9JsgK64T/5dJtIqH8mWBXRdH6NW7aNyYZ9ngEkI6XCjFOywZx6y3biB EesGhA4YXSQe58ZSjzjQD/5Hy0chUIbOJSOAhhKRo3ZVcCXrj6m4UqnUD/51+9wxl/OaI8 fQ2/jnNm7+b0Xjgc1h7BWZuRRyVcOAjl0zjCnmuswhx7jw/Kwrn2hMMCqVvRFtxz1t+m07 YD4XliIwga6AFKN/eWHSzyNr2w/+hDEJgArCBH/MMaz6+06iRjEfksg0GGugnx7tu+7I42 jlCThiV8Ejh8DM3646gKJYSE14xuKsq/xwEdfy7MSz8iobGg3Rk1Q9ll4vE2hw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="kjh6z/mC"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="kjh6z/mC"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BBB8E2C0C6 X-Spam-Score: 5.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: hLWVhHTw4k5B Hi phodina, Sarah Morgensen writes: > Hi! > > Thanks for the patch. I have some suggestions for this one as well. > > phodina writes: > >> Here's updated patch with better package description: >> >> --- >> index d8c3fbec07..a59d065efa 100644 >> --- a/gnu/packages/python-xyz.scm >> +++ b/gnu/packages/python-xyz.scm >> @@ -985,6 +985,44 @@ and URL-safe UUIDs. UUIDs are generated using the built-in Python @code{uuid} >> module and then similar looking characters are removed.") >> (license license:bsd-3))) >> >> +(define-public python-pmbootstrap >> + (package >> + (name "python-pmbootstrap") >> + (version "1.32.0") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "pmbootstrap" version)) >> + (sha256 >> + (base32 >> + "1j796f4wrcdrjd7j9m3w3ziiyqq17kskil9bgy893j6sk73fc5q0")))) >> + (build-system python-build-system) >> + ;; TODO: Running tests fails >> + (arguments >> + '(#:tests? #f)) > > It is not a good idea to skip tests without knowing why they fail, as > there could be subtle bugs in the program even if it seems to run. In > this case, it seems like the reason they're failing is that the pypi > release strips some directories that are required for testing. Perhaps > try from the git repo? > >> + (inputs >> + `(("python-pytest" ,python-pytest) ("python-pyopenssl" ,python-pyopenssl))) > > Typically test packages are put in native-inputs rather than inputs. > >> + (propagated-inputs `(("openssl" ,openssl))) > > Is this necessary? If pmbootstrap just uses openssl through pyopenssl, > it shouldn't be necessary. > >> + (home-page "https://www.postmarketos.org") >> + (synopsis >> + "A sophisticated chroot / build / flash tool to develop and install >> +postmarketOS") >> + (description >> + "Bootstrap program that abstracts everything in chroots and therefore >> +basically runs on top of any Linux distribution. Features: >> +@enumerate >> +@item chroot setup (distro-independent QEMU user emulation >> +@item clean chroot shutdown (umount) and zapping >> +@item build software as packages >> +@item cross-compile all armhf-packages >> +@item effective caching out of the box (survives chroot zaps) >> +@item installation targets >> +@item flasher abstractions >> +@item logging >> +@item security >> +@end enumerate") >> + (license #f))) > > Please make sure not to skip the license field. It looks like this one > is gpl3. > >> + >> (define-public python-logwrap >> (package >> (name "python-logwrap") Gentle ping, since the above comments were 42 weeks ago :-) Thanks, Maxim