all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
@ 2023-06-09 15:52 Vinicius Monego
  2023-07-01 21:25 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Vinicius Monego @ 2023-06-09 15:52 UTC (permalink / raw)
  To: 63980; +Cc: Vinicius Monego

* gnu/packages/python-xyz.scm (python-typeguard)[native-inputs]: Add
python-setuptools-scm.
---
This is required to report the correct version.

 gnu/packages/python-xyz.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7d5128911f..351e199e57 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -23453,8 +23453,10 @@ (define-public python-typeguard
                         ;; XXX: These fail when installed as a library:
                         ;; https://github.com/agronholm/typeguard/issues/176
                         "not usefixtures and not test_cached_module")))))))
-    (native-inputs
-     (list python-mypy python-pytest python-typing-extensions))
+    (native-inputs (list python-mypy
+                         python-pytest
+                         python-setuptools-scm
+                         python-typing-extensions))
     (home-page "https://github.com/agronholm/typeguard")
     (synopsis "Run-time type checker for Python")
     (description
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
  2023-06-09 15:52 [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm Vinicius Monego
@ 2023-07-01 21:25 ` Ludovic Courtès
  2023-07-02  9:45   ` Christopher Baines
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2023-07-01 21:25 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: Christopher Baines, 63980

Hi,

Vinicius Monego <monego@posteo.net> skribis:

> * gnu/packages/python-xyz.scm (python-typeguard)[native-inputs]: Add
> python-setuptools-scm.

LGTM!

<https://qa.guix.gnu.org/issue/63980> says it’s OK; the “Blocked”
numbers are higher, but I’m not sure what that means since there are no
new packages here.  Chris, WDYT?

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
  2023-07-01 21:25 ` Ludovic Courtès
@ 2023-07-02  9:45   ` Christopher Baines
  2023-07-29 18:53     ` Vinicius Monego
  0 siblings, 1 reply; 6+ messages in thread
From: Christopher Baines @ 2023-07-02  9:45 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 63980

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Vinicius Monego <monego@posteo.net> skribis:
>
>> * gnu/packages/python-xyz.scm (python-typeguard)[native-inputs]: Add
>> python-setuptools-scm.
>
> LGTM!
>
> <https://qa.guix.gnu.org/issue/63980> says it’s OK; the “Blocked”
> numbers are higher, but I’m not sure what that means since there are no
> new packages here.  Chris, WDYT?

This is an issue with the data service incorrectly seeing some builds as
not blocked, when they should be. Some of the builds in the base
revision that are being counted in the "Unknown" column should actually
be in blocked, which is why the blocked count appears to increase.

I'm not quite sure what the issue is, but I'll have another look at
fixing this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
  2023-07-02  9:45   ` Christopher Baines
@ 2023-07-29 18:53     ` Vinicius Monego
  2023-09-08 21:51       ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Vinicius Monego @ 2023-07-29 18:53 UTC (permalink / raw)
  To: Christopher Baines, Ludovic Courtès; +Cc: 63980

Hi,

Em dom, 2023-07-02 às 10:45 +0100, Christopher Baines escreveu:
> 
> Ludovic Courtès <ludo@gnu.org> writes:
> 
> > Hi,
> > 
> > Vinicius Monego <monego@posteo.net> skribis:
> > 
> > > * gnu/packages/python-xyz.scm (python-typeguard)[native-inputs]:
> > > Add
> > > python-setuptools-scm.
> > 
> > LGTM!
> > 
> > <https://qa.guix.gnu.org/issue/63980> says it’s OK; the “Blocked”
> > numbers are higher, but I’m not sure what that means since there
> > are no
> > new packages here.  Chris, WDYT?
> 
> This is an issue with the data service incorrectly seeing some builds
> as
> not blocked, when they should be. Some of the builds in the base
> revision that are being counted in the "Unknown" column should
> actually
> be in blocked, which is why the blocked count appears to increase.
> 
> I'm not quite sure what the issue is, but I'll have another look at
> fixing this.

If it's a problem in the data service only, can I push this to master?
There are 257 rebuilds with this change (including pytorch) and I want
to add another one in https://issues.guix.gnu.org/63621 before it hits
300.

Vinicius




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
  2023-07-29 18:53     ` Vinicius Monego
@ 2023-09-08 21:51       ` Ludovic Courtès
  2023-09-17 11:29         ` bug#63980: " Vinicius Monego
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2023-09-08 21:51 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: Christopher Baines, 63980

Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

> If it's a problem in the data service only, can I push this to master?
> There are 257 rebuilds with this change (including pytorch) and I want
> to add another one in https://issues.guix.gnu.org/63621 before it hits
> 300.

I think you can go ahead and push both series (assuming that at least
‘python-pytorch’ is fine after these changes).

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63980: [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm.
  2023-09-08 21:51       ` Ludovic Courtès
@ 2023-09-17 11:29         ` Vinicius Monego
  0 siblings, 0 replies; 6+ messages in thread
From: Vinicius Monego @ 2023-09-17 11:29 UTC (permalink / raw)
  To: 63980-done; +Cc: Ludovic Courtès, Christopher Baines

Em sex, 2023-09-08 às 23:51 +0200, Ludovic Courtès escreveu:
> Hi Vinicius,
> 
> Vinicius Monego <monego@posteo.net> skribis:
> 
> > If it's a problem in the data service only, can I push this to
> > master?
> > There are 257 rebuilds with this change (including pytorch) and I
> > want
> > to add another one in https://issues.guix.gnu.org/63621 before it
> > hits
> > 300.
> 
> I think you can go ahead and push both series (assuming that at least
> ‘python-pytorch’ is fine after these changes).
> 
> Thanks,
> Ludo’.

Hi Ludo,

Closing this one because I applied it. I pushed only part of the other
because the latest version of BoTorch is having issues with reporting
its version, I will look further into it.

Vinicius




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-17 11:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 15:52 [bug#63980] [PATCH] gnu: python-typeguard: Add dependency on python-setuptools-scm Vinicius Monego
2023-07-01 21:25 ` Ludovic Courtès
2023-07-02  9:45   ` Christopher Baines
2023-07-29 18:53     ` Vinicius Monego
2023-09-08 21:51       ` Ludovic Courtès
2023-09-17 11:29         ` bug#63980: " Vinicius Monego

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.