bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Mark H Weaver]

We install a wrapper script around WindowMaker that prepends
/gnu/store/XXX-windowmaker-XXX/bin to $PATH.  This setting is propagated
to all subprocesses in the entire X session, which is suboptimal.  It
would be nice to find another solution, preferably by using absolute
pathnames when launching subprocesses run by WindowMaker.

      Mark

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> We install a wrapper script around WindowMaker that prepends
> /gnu/store/XXX-windowmaker-XXX/bin to $PATH.  This setting is propagated
> to all subprocesses in the entire X session, which is suboptimal.  It
> would be nice to find another solution, preferably by using absolute
> pathnames when launching subprocesses run by WindowMaker.

Fixed in be05e64.

Ludo’.

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Ricardo Wurmus]

The fix may have resulted in unintended side-effects.  On a fresh
installation of the System Distribution v0.8.1 WindowMaker is installed
by default, but it is not completely functional.

For example, the attempt to change the style via the menu results in
this error to be displayed:

    Could not execute command:
        setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style

Likewise, selecting "Configure Window Maker" from the right-click menu
results in this error:

    Could not execute command: exec WPrefs

The "setstyle" executable is located in
/gnu/store/...windowmaker.../bin/, but is not in the PATH.

~~ Ricardo

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[宋文武]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> The fix may have resulted in unintended side-effects.  On a fresh
> installation of the System Distribution v0.8.1 WindowMaker is installed
> by default, but it is not completely functional.
>
> For example, the attempt to change the style via the menu results in
> this error to be displayed:
>
>     Could not execute command:
>         setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style
>
> Likewise, selecting "Configure Window Maker" from the right-click menu
> results in this error:
>
>     Could not execute command: exec WPrefs
>
> The "setstyle" executable is located in
> /gnu/store/...windowmaker.../bin/, but is not in the PATH.
Yes, the $out/bin of windowmaker is not in $PATH, and same for sawfish.

Instead of wrapping every executable of session-type, we can:

#1: Add the package to system profile ('packages').
  It's not clear to me how to do it now, until we have something
  like the NixOS's module system.

#2: Make SLiM use '/run/current-system/profile/share/xsessions' as
    session_dir.
  So simply add a package providing xsession file to 'packages' should
  make it available to SLiM.  And all DE and many window-managers provide
  xsession files already (eg: openbox, sawfish, xfce), we can patch
  the rest (eg: WindowMaker) to install one.

I would like to go #2, WDYT?

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Ludovic Courtès]

宋文武 <iyzsong@gmail.com> skribis:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> The fix may have resulted in unintended side-effects.  On a fresh
>> installation of the System Distribution v0.8.1 WindowMaker is installed
>> by default, but it is not completely functional.
>>
>> For example, the attempt to change the style via the menu results in
>> this error to be displayed:
>>
>>     Could not execute command:
>>         setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style
>>
>> Likewise, selecting "Configure Window Maker" from the right-click menu
>> results in this error:
>>
>>     Could not execute command: exec WPrefs
>>
>> The "setstyle" executable is located in
>> /gnu/store/...windowmaker.../bin/, but is not in the PATH.
> Yes, the $out/bin of windowmaker is not in $PATH, and same for sawfish.
>
> Instead of wrapping every executable of session-type, we can:
>
> #1: Add the package to system profile ('packages').
>   It's not clear to me how to do it now, until we have something
>   like the NixOS's module system.

What I have in mind is to add a ‘packages’ field in ‘service’.  That
would allow service implementations to contribute packages to the global
profile.  Thoughts?

> #2: Make SLiM use '/run/current-system/profile/share/xsessions' as
>     session_dir.
>   So simply add a package providing xsession file to 'packages' should
>   make it available to SLiM.  And all DE and many window-managers provide
>   xsession files already (eg: openbox, sawfish, xfce), we can patch
>   the rest (eg: WindowMaker) to install one.

IIUC the bug initially reported here would remain: the user’s $PATH
would be polluted with the window manager’s stuff, no?

Thanks,
Ludo’.

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[宋文武]

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>
>>> The fix may have resulted in unintended side-effects.  On a fresh
>>> installation of the System Distribution v0.8.1 WindowMaker is installed
>>> by default, but it is not completely functional.
>>>
>>> For example, the attempt to change the style via the menu results in
>>> this error to be displayed:
>>>
>>>     Could not execute command:
>>>         setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style
>>>
>>> Likewise, selecting "Configure Window Maker" from the right-click menu
>>> results in this error:
>>>
>>>     Could not execute command: exec WPrefs
>>>
>>> The "setstyle" executable is located in
>>> /gnu/store/...windowmaker.../bin/, but is not in the PATH.
>> Yes, the $out/bin of windowmaker is not in $PATH, and same for sawfish.
>>
>> Instead of wrapping every executable of session-type, we can:
>>
>> #1: Add the package to system profile ('packages').
>>   It's not clear to me how to do it now, until we have something
>>   like the NixOS's module system.
>
> What I have in mind is to add a ‘packages’ field in ‘service’.  That
> would allow service implementations to contribute packages to the global
> profile.  Thoughts?
It's fine, but we may also need a 'dbus-service' field (for wicd).
>
>> #2: Make SLiM use '/run/current-system/profile/share/xsessions' as
>>     session_dir.
>>   So simply add a package providing xsession file to 'packages' should
>>   make it available to SLiM.  And all DE and many window-managers provide
>>   xsession files already (eg: openbox, sawfish, xfce), we can patch
>>   the rest (eg: WindowMaker) to install one.
>
> IIUC the bug initially reported here would remain: the user’s $PATH
> would be polluted with the window manager’s stuff, no?
I think the 'polluted' means we have a $PATH contains:
  /gnu/store/xxx-windowmaker/bin
install it to profile doesn't have this issue.
>
> Thanks,
> Ludo’.

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Ludovic Courtès]

宋文武 <iyzsong@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>>
>>>> The fix may have resulted in unintended side-effects.  On a fresh
>>>> installation of the System Distribution v0.8.1 WindowMaker is installed
>>>> by default, but it is not completely functional.
>>>>
>>>> For example, the attempt to change the style via the menu results in
>>>> this error to be displayed:
>>>>
>>>>     Could not execute command:
>>>>         setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style
>>>>
>>>> Likewise, selecting "Configure Window Maker" from the right-click menu
>>>> results in this error:
>>>>
>>>>     Could not execute command: exec WPrefs
>>>>
>>>> The "setstyle" executable is located in
>>>> /gnu/store/...windowmaker.../bin/, but is not in the PATH.
>>> Yes, the $out/bin of windowmaker is not in $PATH, and same for sawfish.
>>>
>>> Instead of wrapping every executable of session-type, we can:
>>>
>>> #1: Add the package to system profile ('packages').
>>>   It's not clear to me how to do it now, until we have something
>>>   like the NixOS's module system.
>>
>> What I have in mind is to add a ‘packages’ field in ‘service’.  That
>> would allow service implementations to contribute packages to the global
>> profile.  Thoughts?
> It's fine, but we may also need a 'dbus-service' field (for wicd).

Hmm right.  And dbus policy, and policykit something, and...

Clearly the NixOS way where each service can change anything in the
global config makes it easy; we need to find a middle ground where we
don’t end up allowing services to do anything.  Food for thought...

>>> #2: Make SLiM use '/run/current-system/profile/share/xsessions' as
>>>     session_dir.
>>>   So simply add a package providing xsession file to 'packages' should
>>>   make it available to SLiM.  And all DE and many window-managers provide
>>>   xsession files already (eg: openbox, sawfish, xfce), we can patch
>>>   the rest (eg: WindowMaker) to install one.
>>
>> IIUC the bug initially reported here would remain: the user’s $PATH
>> would be polluted with the window manager’s stuff, no?
> I think the 'polluted' means we have a $PATH contains:
>   /gnu/store/xxx-windowmaker/bin
> install it to profile doesn't have this issue.

Right, but WindowMaker is not necessarily in the user’s profile.

Still, maybe the initial solution, which added WindowMaker to $PATH, is
the least undesirable solution.

Thoughts?

Ludo’.

bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session

[Maxim Cournoyer]

Hello,

Mark H Weaver <mhw@netris.org> writes:

> We install a wrapper script around WindowMaker that prepends
> /gnu/store/XXX-windowmaker-XXX/bin to $PATH.  This setting is propagated
> to all subprocesses in the entire X session, which is suboptimal.  It
> would be nice to find another solution, preferably by using absolute
> pathnames when launching subprocesses run by WindowMaker.
>
>       Mark

I tested with the following modifications to our lightweight-desktop
template:

--8<---------------cut here---------------start------------->8---
modified   gnu/system/examples/lightweight-desktop.tmpl
@@ -2,6 +2,7 @@
 ;; for a "desktop" setup without full-blown desktop
 ;; environments.

+(use-modules (gnu packages gnustep))
 (use-modules (gnu) (gnu system nss))
 (use-service-modules desktop)
 (use-package-modules bootloaders certs ratpoison suckless wm xorg)
@@ -42,7 +43,7 @@
   ;; the log-in screen with F1.
   (packages (append (list
                      ;; window managers
-                     ratpoison i3-wm i3status dmenu
+                     windowmaker
                      ;; terminal emulator
                      xterm
                      ;; for HTTPS access
--8<---------------cut here---------------end--------------->8---

And I cannot reproduce this.  I believe the fix Ludo did 6 years ago in
be05e643ae4d62dc25aa88b7fbdb0eae9cf10eb0 combined with the use of a
xsession file added in commit 537fe4568f4 by Kei resolved this issue for
good.

Closing.

Thanks,

Maxim