From: ludo@gnu.org (Ludovic Courtès)
To: "Clément Lassieur" <clement@lassieur.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add Prosody service.
Date: Sat, 07 Jan 2017 22:29:07 +0100 [thread overview]
Message-ID: <874m1azhi4.fsf@gnu.org> (raw)
In-Reply-To: <20170104215559.3295-1-clement@lassieur.org> ("Clément Lassieur"'s message of "Wed, 4 Jan 2017 22:55:59 +0100")
Hi Clément,
Clément Lassieur <clement@lassieur.org> skribis:
> * gnu/services/messaging.scm: New file.
> * gnu/services/configuration.scm: New exported procedures.
> * gnu/packages/messaging.scm (prosody)[arguments]: Add 'fix-makefile'
> phase.
> In 'wrap-programs' phase, add 'openssl' and 'coreutils' to 'PATH'.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/services/messaging.scm.
> * doc/guix.texi (Messaging Services): New section.
Great work!
I would suggest moving the gnu/packages change to a separate patch, but
apart from that I don’t have anything to add to Hartmut’s comment.
Could you send updated patches?
I suppose you confirmed with ‘guix system vm’ or similar that it works
as intended. Could you consider writing a system test for Prosody? The
(gnu tests mail) and (gnu tests ssh) modules provide relatively simple
examples to start from.
Thank you!
Ludo’.
next prev parent reply other threads:[~2017-01-07 21:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 21:55 [PATCH] gnu: Add Prosody service Clément Lassieur
2017-01-05 10:34 ` Hartmut Goebel
2017-01-05 10:50 ` ng0
2017-01-07 22:10 ` Clément Lassieur
2017-01-07 21:14 ` Clément Lassieur
2017-01-07 21:29 ` Ludovic Courtès [this message]
2017-01-08 19:06 ` Clément Lassieur
2017-01-08 19:08 ` [PATCH 1/3] " Clément Lassieur
2017-01-08 19:08 ` [PATCH 2/3] gnu: prosody: Fix inputs Clément Lassieur
2017-01-08 22:38 ` Ludovic Courtès
2017-01-08 19:08 ` [PATCH 3/3] gnu: prosody: Make config and data files visible to 'prosodyctl' Clément Lassieur
2017-01-08 22:38 ` Ludovic Courtès
2017-01-08 22:40 ` [PATCH 1/3] gnu: Add Prosody service Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2016-11-26 17:15 RFH: Add prosody service Clément Lassieur
2016-11-26 17:20 ` [PATCH] gnu: " Clément Lassieur
2016-11-26 23:41 ` Leo Famulari
2016-11-27 10:04 ` Clément Lassieur
2016-11-26 17:20 ` Clément Lassieur
2016-11-26 21:28 ` Clément Lassieur
2016-11-26 21:30 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m1azhi4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=clement@lassieur.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.