From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add Prosody service.
Date: Sat, 07 Jan 2017 22:29:07 +0100
Message-ID: <874m1azhi4.fsf@gnu.org>
References: <20170104215559.3295-1-clement@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cPyY7-0003wt-2P
	for guix-devel@gnu.org; Sat, 07 Jan 2017 16:29:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cPyY2-0008Gg-VC
	for guix-devel@gnu.org; Sat, 07 Jan 2017 16:29:15 -0500
In-Reply-To: <20170104215559.3295-1-clement@lassieur.org> (=?utf-8?Q?=22Cl?=
	=?utf-8?Q?=C3=A9ment?=
	Lassieur"'s message of "Wed, 4 Jan 2017 22:55:59 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: guix-devel@gnu.org

Hi Cl=C3=A9ment,

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> * gnu/services/messaging.scm: New file.
> * gnu/services/configuration.scm: New exported procedures.
> * gnu/packages/messaging.scm (prosody)[arguments]: Add 'fix-makefile'
>   phase.
>   In 'wrap-programs' phase, add 'openssl' and 'coreutils' to 'PATH'.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/services/messaging.scm.
> * doc/guix.texi (Messaging Services): New section.

Great work!

I would suggest moving the gnu/packages change to a separate patch, but
apart from that I don=E2=80=99t have anything to add to Hartmut=E2=80=99s c=
omment.

Could you send updated patches?

I suppose you confirmed with =E2=80=98guix system vm=E2=80=99 or similar th=
at it works
as intended.  Could you consider writing a system test for Prosody?  The
(gnu tests mail) and (gnu tests ssh) modules provide relatively simple
examples to start from.

Thank you!

Ludo=E2=80=99.