all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: okapi@firemail.cc
Cc: 30381@debbugs.gnu.org
Subject: [bug#30381] gnu: Add gzdoom.
Date: Fri, 09 Feb 2018 11:20:03 +0100	[thread overview]
Message-ID: <874lmq4g8c.fsf@gnu.org> (raw)
In-Reply-To: <e11a636a5bf5d5211b00f9cdef56e076@firemail.cc> (okapi@firemail.cc's message of "Wed, 07 Feb 2018 19:03:24 +0100")

okapi@firemail.cc skribis:

> From c3b7fea66a5bc5bd13f448da15d704659ee5bcb7 Mon Sep 17 00:00:00 2001
> From: okapi <okapi@firemail.cc>
> Date: Wed, 17 Jan 2018 00:21:42 +0100
> Subject: [PATCH 2/2] gnu: Add gzdoom.
>
> * gnu/packages/games.scm (gzdoom): New variable.
> * gnu/packages/patches/gzdoom-search-in-installed-share.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

Overall LGTM!  Minor issues:

> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("unzip" ,unzip)))
> +    (synopsis "Modern Doom 2 source port")
> +    (description "Gzdoom is a Doom 2 source port with a modern renderer.

To give a bit more context, maybe: “Gzdoom is a port of the Doom 2
ADJECTIVE game, using a modern renderer.” (I’ll let you find what
ADJECTIVE to use.  :-))

> +It improves modding support with ZDoom's advanced mapping features and the new
> +ZScript language.  In addition to Doom, it supports Heretic, Hexen, Strife,
> +Chex Quest, and fan-created games like Harmony and Hacx.")
> +    (home-page "https://zdoom.org/index")
> +    (license (list license:gpl3+         ; gzdoom game
> +                   license:lgpl3+        ; gzdoom renderer
> +                   license:expat         ; gdtoa
> +                   (license:non-copyleft ; modified dumb
> +                    "file://dumb/licence.txt"
> +                    "Dumb license, explicitly GPL compatible.")))))
> diff --git a/gnu/packages/patches/gzdoom-search-in-installed-share.patch b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> new file mode 100644
> index 000000000..d16b604db
> --- /dev/null
> +++ b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> @@ -0,0 +1,14 @@

Please add a couple of lines explaining what the patch does, and what
its upstream status is (with a link to the upstream commit/issue, if
any.)

Could you send an updated patch?

Thanks,
Ludo’.

  parent reply	other threads:[~2018-02-09 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 18:03 [bug#30381] gnu: Add gzdoom okapi
2018-02-09 10:16 ` Ludovic Courtès
     [not found]   ` <f1bb9dc3477a3a89f4baf355b97a64ac@firemail.cc>
2018-02-18 23:17     ` Ludovic Courtès
2018-02-09 10:20 ` Ludovic Courtès [this message]
     [not found]   ` <9752ffae572668a688ceccda891a5821@firemail.cc>
2018-02-18 23:26     ` bug#30381: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lmq4g8c.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30381@debbugs.gnu.org \
    --cc=okapi@firemail.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.