From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5nm-0003oX-CR
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:21:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5ni-0004Y3-4l
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:21:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:55039)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ek5ni-0004Xw-0m
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:21:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5nh-0002DB-Rl
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:21:01 -0500
Subject: [bug#30381] gnu: Add gzdoom.
Resent-Message-ID: <handler.30381.B30381.15181716118435@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <e11a636a5bf5d5211b00f9cdef56e076@firemail.cc>
Date: Fri, 09 Feb 2018 11:20:03 +0100
In-Reply-To: <e11a636a5bf5d5211b00f9cdef56e076@firemail.cc>
	(okapi@firemail.cc's message of "Wed, 07 Feb 2018 19:03:24 +0100")
Message-ID: <874lmq4g8c.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: okapi@firemail.cc
Cc: 30381@debbugs.gnu.org

okapi@firemail.cc skribis:

> From c3b7fea66a5bc5bd13f448da15d704659ee5bcb7 Mon Sep 17 00:00:00 2001
> From: okapi <okapi@firemail.cc>
> Date: Wed, 17 Jan 2018 00:21:42 +0100
> Subject: [PATCH 2/2] gnu: Add gzdoom.
>
> * gnu/packages/games.scm (gzdoom): New variable.
> * gnu/packages/patches/gzdoom-search-in-installed-share.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

Overall LGTM!  Minor issues:

> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("unzip" ,unzip)))
> +    (synopsis "Modern Doom 2 source port")
> +    (description "Gzdoom is a Doom 2 source port with a modern renderer.

To give a bit more context, maybe: =E2=80=9CGzdoom is a port of the Doom 2
ADJECTIVE game, using a modern renderer.=E2=80=9D (I=E2=80=99ll let you fin=
d what
ADJECTIVE to use.  :-))

> +It improves modding support with ZDoom's advanced mapping features and t=
he new
> +ZScript language.  In addition to Doom, it supports Heretic, Hexen, Stri=
fe,
> +Chex Quest, and fan-created games like Harmony and Hacx.")
> +    (home-page "https://zdoom.org/index")
> +    (license (list license:gpl3+         ; gzdoom game
> +                   license:lgpl3+        ; gzdoom renderer
> +                   license:expat         ; gdtoa
> +                   (license:non-copyleft ; modified dumb
> +                    "file://dumb/licence.txt"
> +                    "Dumb license, explicitly GPL compatible.")))))
> diff --git a/gnu/packages/patches/gzdoom-search-in-installed-share.patch =
b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> new file mode 100644
> index 000000000..d16b604db
> --- /dev/null
> +++ b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> @@ -0,0 +1,14 @@

Please add a couple of lines explaining what the patch does, and what
its upstream status is (with a link to the upstream commit/issue, if
any.)

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.