From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Z572 <873216071@qq.com>
Cc: 46018@debbugs.gnu.org
Subject: [bug#46018] [PATCH] Add dwl.
Date: Sat, 23 Jan 2021 12:15:23 +0100 [thread overview]
Message-ID: <874kj7gb04.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <tencent_6FCA5F4BAA6AA7376B526DB3FAFEC674F609@qq.com> (873216071@qq.com's message of "Thu, 21 Jan 2021 20:14:40 +0800")
Hello,
Z572 <873216071@qq.com> writes:
> Subject: [PATCH] gnu: Add dwl.
Thank you! Some comments follow.
> +(define-public dwl
> + (package
> + (name "dwl")
> + (version "0.1")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/djpohly/dwl")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; no tests
> + #:make-flags
> + (list
> + "CC=gcc"
Instead of "CC=gcc", you should use
(string-append "CC=" ,(cc-for-target))
for cross-compilation.
> + (string-append "PREFIX=" %output))
Here, I think it is preferable to use
(string-append "PREFIX=" (assoc-ref %outputs "out"))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; no configure
> + (replace 'install ; no install targer
Typo: ";no install target"
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin")))
> + (install-file "dwl" bin)))))))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("wlroots" ,wlroots)))
> + (home-page "https://github.com/djpohly/dwl")
> + (synopsis "Dwm for Wayland")
It would be nice to expound Dwm, e.g.,
"Dynamic window manager for Wayland"
> + (description
> + "A compact, hackable compositor for Wayland based on wlroots. It is
This should be a complete sentence, e.g.,
Dwl is a compact, hackable...
> +intended to fill the same space in the Wayland world that dwm does in X11,
> +primarily in terms of philosophy, and secondarily in terms of functionality.
> +Like dwm, dwl is:
> +@itemize
> +@item Easy to understand, hack on, and extend with patches
> +@item One C source file (or a very small number) configurable via config.h
> +@item Limited to 2000 SLOC to promote hackability
> +@item Tied to as few external dependencies as possible
I suggest rewrite so it doesn't include a list. For example:
Like dwm, dwl is easy to understand and hack on, due to a limited
size and a few external dependencies. It is configurable via @file{config.h}.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-01-23 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:14 [bug#46018] [PATCH] Add dwl Z572
2021-01-21 12:14 ` Z572
2021-01-23 11:15 ` Nicolas Goaziou [this message]
2021-01-23 12:17 ` Z572
2021-01-23 12:17 ` Z572
2021-02-12 7:35 ` bug#46018: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kj7gb04.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=46018@debbugs.gnu.org \
--cc=873216071@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.