From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6LO9KIMFDGBmBQAA0tVLHw (envelope-from ) for ; Sat, 23 Jan 2021 11:16:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wOadJIMFDGDeawAAB5/wlQ (envelope-from ) for ; Sat, 23 Jan 2021 11:16:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DD539403A4 for ; Sat, 23 Jan 2021 11:16:19 +0000 (UTC) Received: from localhost ([::1]:35102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Gtu-0008HD-2J for larch@yhetil.org; Sat, 23 Jan 2021 06:16:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Gte-0008H2-Pl for guix-patches@gnu.org; Sat, 23 Jan 2021 06:16:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3Gte-0001Pg-GF for guix-patches@gnu.org; Sat, 23 Jan 2021 06:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3Gte-0005FD-BZ for guix-patches@gnu.org; Sat, 23 Jan 2021 06:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46018] [PATCH] Add dwl. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Jan 2021 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46018 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com> Received: via spool by 46018-submit@debbugs.gnu.org id=B46018.161140053720125 (code B ref 46018); Sat, 23 Jan 2021 11:16:02 +0000 Received: (at 46018) by debbugs.gnu.org; 23 Jan 2021 11:15:37 +0000 Received: from localhost ([127.0.0.1]:33764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3GtF-0005EX-CV for submit@debbugs.gnu.org; Sat, 23 Jan 2021 06:15:37 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:52219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3GtB-0005ED-S4 for 46018@debbugs.gnu.org; Sat, 23 Jan 2021 06:15:35 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 857BF240016; Sat, 23 Jan 2021 11:15:25 +0000 (UTC) From: Nicolas Goaziou References: Date: Sat, 23 Jan 2021 12:15:23 +0100 In-Reply-To: (873216071@qq.com's message of "Thu, 21 Jan 2021 20:14:40 +0800") Message-ID: <874kj7gb04.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46018@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3DD539403A4 X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: RWVAXBtSUmzU Hello, Z572 <873216071@qq.com> writes: > Subject: [PATCH] gnu: Add dwl. Thank you! Some comments follow. > +(define-public dwl > + (package > + (name "dwl") > + (version "0.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/djpohly/dwl") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; no tests > + #:make-flags > + (list > + "CC=gcc" Instead of "CC=gcc", you should use (string-append "CC=" ,(cc-for-target)) for cross-compilation. > + (string-append "PREFIX=" %output)) Here, I think it is preferable to use (string-append "PREFIX=" (assoc-ref %outputs "out")) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ; no configure > + (replace 'install ; no install targer Typo: ";no install target" > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (install-file "dwl" bin))))))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("wlroots" ,wlroots))) > + (home-page "https://github.com/djpohly/dwl") > + (synopsis "Dwm for Wayland") It would be nice to expound Dwm, e.g., "Dynamic window manager for Wayland" > + (description > + "A compact, hackable compositor for Wayland based on wlroots. It is This should be a complete sentence, e.g., Dwl is a compact, hackable... > +intended to fill the same space in the Wayland world that dwm does in X11, > +primarily in terms of philosophy, and secondarily in terms of functionality. > +Like dwm, dwl is: > +@itemize > +@item Easy to understand, hack on, and extend with patches > +@item One C source file (or a very small number) configurable via config.h > +@item Limited to 2000 SLOC to promote hackability > +@item Tied to as few external dependencies as possible I suggest rewrite so it doesn't include a list. For example: Like dwm, dwl is easy to understand and hack on, due to a limited size and a few external dependencies. It is configurable via @file{config.h}. Could you send an updated patch? Regards, -- Nicolas Goaziou