all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#48128] [PATCH] Add font-montserrat.
@ 2021-04-30 20:47 Sergiu Ivanov
  2021-05-03 16:13 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Sergiu Ivanov @ 2021-04-30 20:47 UTC (permalink / raw)
  To: 48128

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Dear Guix,

Here's a patch adding the font Montserrat.

I retrieve the release zipball from GitHub using a direct url-fetch
rather than git-fetch, because I've seen both in fonts.scm. If you think
git-fetch is more appropriate, I'll change the method.

Thank you!

[-- Attachment #2: 0001-Add-font-montserrat.patch --]
[-- Type: text/x-patch, Size: 1863 bytes --]

From 6de396df2fa096e8ff3e27328c902fe789e12a13 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <sivanov@colimite.fr>
Date: Fri, 30 Apr 2021 22:20:16 +0200
Subject: [PATCH] Add font-montserrat.

---
 gnu/packages/fonts.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index b78c46b0f8..35f2398dc8 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2020 Tim Van den Langenbergh <tmt_vdl@gmx.com>
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
 ;;; Copyright © 2021 Antoine Côté <antoine.cote@posteo.net>
+;;; Copyright © 2021 Sergiu Ivanov <sivanov@colimite.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2156,3 +2157,21 @@ suitable for a wide range of uses.")
     (description "Cozette is a 6x13px (bounding box) bitmap font based on Dina
 and heavily inspired by Creep.")
     (license license:expat)))
+
+(define-public font-montserrat
+  (package
+    (name "font-montserrat")
+    (version "7.210")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))
+              (sha256
+               (base32
+                "0k5jsb8hgya4ap80w5l4vxnx17kw482k3lm007awjyy5qzp982z3"))
+              ))
+    (build-system font-build-system)
+    (home-page "https://github.com/JulietaUla/Montserrat")
+    (synopsis "The Montserat font")
+    (description "The old posters and signs in the traditional Montserrat neighborhood of Buenos Aires inspired Julieta Ulanovsky to design this typeface and rescue the beauty of urban typography that emerged in the first half of the twentieth century.")
+    (license license:silofl1.1)))
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48128] [PATCH] Add font-montserrat.
  2021-04-30 20:47 [bug#48128] [PATCH] Add font-montserrat Sergiu Ivanov
@ 2021-05-03 16:13 ` Ludovic Courtès
  2021-05-05 20:17   ` Sergiu Ivanov
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2021-05-03 16:13 UTC (permalink / raw)
  To: Sergiu Ivanov; +Cc: 48128

Hi Sergiu,

Sergiu Ivanov <sivanov@colimite.fr> skribis:

> I retrieve the release zipball from GitHub using a direct url-fetch
> rather than git-fetch, because I've seen both in fonts.scm. If you think
> git-fetch is more appropriate, I'll change the method.


[...]

> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))

This is a generated tarball that may change over time, which is why
‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
instead.

You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
lint’ suggests.

There are also a couple of ‘guix lint’ warnings that I’ll let you
check.  :-)

> +    (synopsis "The Montserat font")
                            ^
Missing ‘r’.

Could you send an updated patch?

Thanks in advance,
Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48128] [PATCH] Add font-montserrat.
  2021-05-03 16:13 ` Ludovic Courtès
@ 2021-05-05 20:17   ` Sergiu Ivanov
  2021-05-08 10:14     ` bug#48128: " Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Sergiu Ivanov @ 2021-05-05 20:17 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 48128

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Hi Ludovic,

Thank you for taking the time to answer and giving me the opportunity
to learn!

Also, sorry for the delay.


Thus quoth  Ludovic Courtès  on Mon May 03 2021 at 18:13 (+0200):
> Hi Sergiu,
>
> Sergiu Ivanov <sivanov@colimite.fr> skribis:
>
>> I retrieve the release zipball from GitHub using a direct url-fetch
>> rather than git-fetch, because I've seen both in fonts.scm. If you think
>> git-fetch is more appropriate, I'll change the method.
>
>
> [...]
>
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))
>
> This is a generated tarball that may change over time, which is why
> ‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
> instead.

I changed that, thank you.

> You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
> lint’ suggests.

Indeed, I added that field.

> There are also a couple of ‘guix lint’ warnings that I’ll let you
> check.  :-)

I left closing parens on a separate line :O :O :O

I remember thinking how guix lint was wonderful when I read the Guix
Manual, and now I forgot to run it :D

>> +    (synopsis "The Montserat font")
>                             ^
> Missing ‘r’.

Fixed, thank you.

> Could you send an updated patch?

I attach the update.

-
Sergiu

[-- Attachment #2: 0001-Add-font-montserrat.patch --]
[-- Type: text/x-patch, Size: 1944 bytes --]

From fcec43e6a60081c2041f5827f22bcccec3c17bfd Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <sivanov@colimite.fr>
Date: Fri, 30 Apr 2021 22:20:16 +0200
Subject: [PATCH] Add font-montserrat.

---
 gnu/packages/fonts.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index b78c46b0f8..8c9b4b68ce 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2020 Tim Van den Langenbergh <tmt_vdl@gmx.com>
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
 ;;; Copyright © 2021 Antoine Côté <antoine.cote@posteo.net>
+;;; Copyright © 2021 Sergiu Ivanov <sivanov@colimite.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2156,3 +2157,25 @@ suitable for a wide range of uses.")
     (description "Cozette is a 6x13px (bounding box) bitmap font based on Dina
 and heavily inspired by Creep.")
     (license license:expat)))
+
+(define-public font-montserrat
+  (package
+    (name "font-montserrat")
+    (version "7.210")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/JulietaUla/Montserrat")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0jn1yvfamq5xazw85sfnxgriji60g7mkss9mkf8d0117vdk838bn"))))
+    (build-system font-build-system)
+    (home-page "https://github.com/JulietaUla/Montserrat")
+    (synopsis "The Montserrat font")
+    (description "The old posters and signs in the traditional Montserrat
+neighborhood of Buenos Aires inspired Julieta Ulanovsky to design this
+typeface and rescue the beauty of urban typography that emerged in the first
+half of the twentieth century.")
+    (license license:silofl1.1)))
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#48128: [PATCH] Add font-montserrat.
  2021-05-05 20:17   ` Sergiu Ivanov
@ 2021-05-08 10:14     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2021-05-08 10:14 UTC (permalink / raw)
  To: Sergiu Ivanov; +Cc: 48128-done

Hi Sergiu,

Sergiu Ivanov <sivanov@colimite.fr> skribis:

> Thank you for taking the time to answer and giving me the opportunity
> to learn!

You’re welcome.  :-)

> From fcec43e6a60081c2041f5827f22bcccec3c17bfd Mon Sep 17 00:00:00 2001
> From: Sergiu Ivanov <sivanov@colimite.fr>
> Date: Fri, 30 Apr 2021 22:20:16 +0200
> Subject: [PATCH] Add font-montserrat.
>
> ---
>  gnu/packages/fonts.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)

I added a ChangeLog-style commit message and committed it.

Thank you!

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-08 10:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 20:47 [bug#48128] [PATCH] Add font-montserrat Sergiu Ivanov
2021-05-03 16:13 ` Ludovic Courtès
2021-05-05 20:17   ` Sergiu Ivanov
2021-05-08 10:14     ` bug#48128: " Ludovic Courtès

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git