[bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.

[bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.

[Xinglu Chen]

* gnu/packages/emacs-xyz.scm (emacs-org-inline-pdf): New variable.
---
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 886320cc34..22918c8f9b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4635,6 +4635,36 @@ strike through completed TODO headings, changes Org blocks, changes Org check
 boxes, and more.")
       (license license:gpl3+))))
 
+(define-public emacs-org-inline-pdf
+  (package
+    (name "emacs-org-inline-pdf")
+    (version "0.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/shg/org-inline-pdf.el")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1qc92xvgxmnwjixk8bxwbc1l1jj0qk9dg73jyaip6lk4g0wjk6xf"))))
+    (build-system emacs-build-system)
+    (inputs
+     `(("pdf2svg" ,pdf2svg)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-exec-paths
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((pdf2svg (assoc-ref inputs "pdf2svg")))
+               (substitute* "org-inline-pdf.el"
+                 (("\"pdf2svg\"") (string-append "\"" pdf2svg "/bin/pdf2svg\"")))))))))
+    (home-page "https://github.com/shg/org-inline-pdf.el")
+    (synopsis "Inline PDF previewing for Org ")
+    (description "This package provides a minor mode that enables
+inline PDF preview in Org buffers by using pdf2svg.")
+    (license license:gpl3+)))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")

base-commit: 0ffac75ece4f22a8595e19b8a375791e87d365aa
-- 
2.31.1

[bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On Wed, May 26 2021, Xinglu Chen wrote:

> +(define-public emacs-org-inline-pdf
> +  (package
> +    (name "emacs-org-inline-pdf")
> +    (version "0.2")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/shg/org-inline-pdf.el")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1qc92xvgxmnwjixk8bxwbc1l1jj0qk9dg73jyaip6lk4g0wjk6xf"))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("pdf2svg" ,pdf2svg)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-exec-paths
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((pdf2svg (assoc-ref inputs "pdf2svg")))
> +               (substitute* "org-inline-pdf.el"
> +                 (("\"pdf2svg\"") (string-append "\"" pdf2svg "/bin/pdf2svg\"")))))))))
> +    (home-page "https://github.com/shg/org-inline-pdf.el")
> +    (synopsis "Inline PDF previewing for Org ")
                                               ^^
Oops, trailing whitespace.  Should I add a linter check for this?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#48663: [PATCH] gnu: Add emacs-org-inline-pdf.

[Nicolas Goaziou]

Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

> On Wed, May 26 2021, Xinglu Chen wrote:
>
>> +(define-public emacs-org-inline-pdf

Patch applied. Thank you.

> Oops, trailing whitespace.  Should I add a linter check for this?

Isn't it the case already? There's a `report-trailing-white-space'
checker in "lint.scm".

Regards,
-- 
Nicolas Goaziou

[bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

On Wed, May 26 2021, Nicolas Goaziou wrote:

>> Oops, trailing whitespace.  Should I add a linter check for this?
>
> Isn't it the case already? There's a `report-trailing-white-space'
> checker in "lint.scm".

I think this one only checks the lines and not the text inside of the
synopsis string.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]