From: "Ludovic Courtès" <ludo@gnu.org>
To: Timmy Douglas <mail@timmydouglas.com>
Cc: 52174@debbugs.gnu.org
Subject: [bug#52174] [PATCH] gnu: Add podman
Date: Sat, 18 Dec 2021 18:57:20 +0100 [thread overview]
Message-ID: <874k75pzi7.fsf@gnu.org> (raw)
In-Reply-To: <4d5abde1033a5178c7b088fbd13f93f4f96866b6.1638168394.git.mail@timmydouglas.com> (Timmy Douglas's message of "Sun, 28 Nov 2021 22:46:36 -0800")
Hi Timmy,
Timmy Douglas <mail@timmydouglas.com> skribis:
> * gnu/packages/containers.scm (crun, conmon, libslirp, slirp4netns,
> cni-plugins, podman): Add podman and dependencies.
> ---
>
> I was going to try running some docker containers on my Guix system
> today, but I noticed docker was an old version. I decided to try
> packaging podman as the daemonless aspect seems appealing and was able
> to run a basic alpine image (rootless) after a couple of hours of
> putting this together. This is one of my first packages for Guix, so
> please give me some feedback--I'm also interested if anyone else would
> like to work together on this, because I'm fairly new to Guix and I
> haven't used podman before either. This probably needs some more
> testing since I only tried a basic scenario.
>
> For podman to work, I needed to run this:
> `sudo mount -t cgroup2 none /sys/fs/cgroup`
Woow, that’s a great start, and it’ll certainly be useful to many.
Overall it LGTM. Here are some minor issues that would be nice
addressing:
> gnu/packages/containers.scm | 304 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 304 insertions(+)
> create mode 100644 gnu/packages/containers.scm
We usually have one patch per new package; IWBN if you could split this
patch accordingly.
Make sure to add ‘containers.scm’ to ‘gnu/local.mk’ too.
> + (arguments
> + '(#:tests? #f
> + #:configure-flags '("--disable-systemd")
> + #:phases
Please align keywords, as in:
'(#:tests? #f
#:configure-flags …
#:phases …)
> + (display (string-append
> + "/* autogenerated. */\n#ifndef GIT_VERSION\n# define GIT_VERSION \""
> + "8e5757a4e68590326dafe8a8b1b4a584b10a1370" ; refactor this
You can write “,commit” (read: “unquote commit”), assuming there’s a
‘commit’ local variable above.
> + (inputs
> + `(("libcap" ,libcap)
> + ("libseccomp" ,libseccomp)
> + ("libyajl" ,libyajl)))
> + (native-inputs
> + `(("automake" ,automake)
> + ("autoreconf" ,autoconf)
> + ("git" ,git)
> + ("libtool" ,libtool)
> + ("pkg-config" ,pkg-config)
> + ("python-3" ,python-3)))
IWBN if you could run packages through ‘guix style’:
https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-style.html
> + (name "conmon")
> + (version "v2.0.30")
Please remove “v” from the version number (here and elsewhere), and…
> + (uri (git-reference
> + (url "https://github.com/containers/conmon")
> + (commit version)))
^
… add it here, with (string-append "v" version).
> + (home-page "https://gitlab.freedesktop.org/slirp/libslirp")
> + (synopsis "User-mode networking library")
> + (description
> + "libslirp is a user-mode networking library used by virtual machines,
> +containers or various tools.")
> + (license license:non-copyleft))) ;fixme what is this?
It’s ‘license:bsd-3’, per
<https://gitlab.freedesktop.org/slirp/libslirp/-/blob/master/COPYRIGHT>.
That’s it.
Could you send updated patches?
Thank you, and apologies for the delay!
Ludo’.
next prev parent reply other threads:[~2021-12-18 18:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 6:46 [bug#52174] [PATCH] gnu: Add podman Timmy Douglas via Guix-patches via
2021-12-18 17:57 ` Ludovic Courtès [this message]
2021-12-19 4:58 ` [bug#52174] [PATCH v2 1/6] gnu: add crun Timmy Douglas via Guix-patches via
[not found] ` <875yrjl8a5.fsf@gnu.org>
2021-12-21 20:17 ` Timmy Douglas via Guix-patches via
2021-12-24 15:23 ` Ludovic Courtès
2021-12-25 0:22 ` Timmy Douglas via Guix-patches via
2022-01-01 18:11 ` bug#52174: [PATCH] gnu: Add podman Ludovic Courtès
2022-01-01 19:59 ` [bug#52174] " Timmy Douglas via Guix-patches via
2022-01-03 11:14 ` Ludovic Courtès
2021-12-19 4:58 ` [bug#52174] [PATCH v2 2/6] gnu: add conmon Timmy Douglas via Guix-patches via
[not found] ` <87wnjzjtk2.fsf@gnu.org>
2021-12-21 22:42 ` Timmy Douglas via Guix-patches via
2021-12-24 15:25 ` Ludovic Courtès
2021-12-19 4:58 ` [bug#52174] [PATCH v2 3/6] gnu: add libslirp Timmy Douglas via Guix-patches via
[not found] ` <871r27l87f.fsf@gnu.org>
2021-12-21 22:37 ` Timmy Douglas via Guix-patches via
2021-12-24 15:24 ` Ludovic Courtès
2021-12-19 4:58 ` [bug#52174] [PATCH v2 4/6] gnu: add slirp4netns Timmy Douglas via Guix-patches via
2021-12-19 4:58 ` [bug#52174] [PATCH v2 5/6] gnu: add cni-plugins Timmy Douglas via Guix-patches via
2021-12-19 4:58 ` [bug#52174] [PATCH v2 6/6] gnu: add podman Timmy Douglas via Guix-patches via
[not found] <CMD7WNOQ95S7.2N4ASFNPGIJXS@nix>
2022-08-23 7:14 ` [bug#52174] [PATCH] gnu: Add podman guix-patches--- via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k75pzi7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=52174@debbugs.gnu.org \
--cc=mail@timmydouglas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.