From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iCi2KtkhvmHmjQAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 19:00:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OLdsJtkhvmH4RQAAB5/wlQ (envelope-from ) for ; Sat, 18 Dec 2021 18:00:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51A309297 for ; Sat, 18 Dec 2021 19:00:57 +0100 (CET) Received: from localhost ([::1]:43956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mye0t-0003kf-Ga for larch@yhetil.org; Sat, 18 Dec 2021 13:00:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydy6-0000Pa-42 for guix-patches@gnu.org; Sat, 18 Dec 2021 12:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mydy5-00053N-QQ for guix-patches@gnu.org; Sat, 18 Dec 2021 12:58:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mydy5-0006Q1-MC for guix-patches@gnu.org; Sat, 18 Dec 2021 12:58:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52174] [PATCH] gnu: Add podman Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timmy Douglas Cc: 52174@debbugs.gnu.org Received: via spool by 52174-submit@debbugs.gnu.org id=B52174.163985025124632 (code B ref 52174); Sat, 18 Dec 2021 17:58:01 +0000 Received: (at 52174) by debbugs.gnu.org; 18 Dec 2021 17:57:31 +0000 Received: from localhost ([127.0.0.1]:43784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydxb-0006PD-C2 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:57:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydxZ-0006P0-Gg for 52174@debbugs.gnu.org; Sat, 18 Dec 2021 12:57:29 -0500 Received: from [2001:470:142:3::e] (port=33628 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydxU-0004z4-78; Sat, 18 Dec 2021 12:57:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=LOC5Nwmb80BUH1RTWZxhjfhjZ60zarm4QY88dpIgJAM=; b=rCQKIk1nniBvb7EKlMES jXu7dknE2AMAt4qh8TgZYFeKl6V1fupU4pWpxxavXhk8zcygQurfaNaQlOC9DMNrVK6N8FrZCGpHB jn1ssVORlvRsmt253Hpm0LchukwRGvFFN6HolSyS6YytV1AA7XEBZLODMhJBBiUrpSD5jWej1Xo65 pW1pkb4XgG5fskLnggT4JmyoV3XKxBxqLbXMnTmcdnPIuuNmpX3s9kYPAROPhI7Y/4cI1Ooaw03hP QXPavUpzNq+mP9DJCMsHn94A9kGE45HAeWhYnDrfMrnoFkFjT3ExlW2ICMydgcyEhbYYZXAWlbcYu PLKXr6CVah66Ug==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:64335 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydxU-0003ba-7N; Sat, 18 Dec 2021 12:57:24 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <4d5abde1033a5178c7b088fbd13f93f4f96866b6.1638168394.git.mail@timmydouglas.com> Date: Sat, 18 Dec 2021 18:57:20 +0100 In-Reply-To: <4d5abde1033a5178c7b088fbd13f93f4f96866b6.1638168394.git.mail@timmydouglas.com> (Timmy Douglas's message of "Sun, 28 Nov 2021 22:46:36 -0800") Message-ID: <874k75pzi7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639850457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LOC5Nwmb80BUH1RTWZxhjfhjZ60zarm4QY88dpIgJAM=; b=Aa3DW7U+2Qy+F5YohTNuiH6gtHH+K3uQ1Mpbe0RMFJAyEBRvIU76+gKgM7u5qKTz3YPTp2 NtJBzRZpA+AcuVybb+INNxWawuXN8Z4Gtypn8cKZh4+yq5bPRUo4b207Kt2Mj7xVHvlYYA ONf6jz/n/Xwf01jPCOW/27vy0OyxYUAjABMEBA0BAYSO3XW3SxQhmx+h73FUsSSBzODtrM 3m5xGi6weQFLEsZMa46Blxh0LLnWpmebNmtREvRuW425ALxS8oNNlYYYlZX72WFkzM2yDi AtYe4SAhFxGOGWR0HgduasOUhmVT26lmJLW96WfFmAsXJLUeC7rzm9ekpnO2dg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639850457; a=rsa-sha256; cv=none; b=RTGyns6i8xBun2Ou3twe5l1BYYoNk0I4Cki5I8Cq7ZtaeBbWj7SymegpUSfL7MlAzCluDW FtsFbOWBeTprxnNZo5A4ip/gwdbmFSLAwqWF3oOMbRDA/wW4zg4zwsED5y0tX75IwKTAgr bwHAXMFaIdha9bImCUA+7WuQtL89T2IswvwVrwkSMoiIGgTNizK/lUoFrRHL+PeuW/qEg5 anaDuQLOQJAgienwJHmXkWBIeopnMGwmlEppxIBOCXlvfH53Fb2LHNTUmfB38Cmd5DSH4n 98qhKmH4LHSfYysUWEFo/PF9DSUoLX/HyYm5TfgK0h+AKzq31eMeyM9gdt0tUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rCQKIk1n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rCQKIk1n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 51A309297 X-Spam-Score: -4.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7d49K+jN61aq Hi Timmy, Timmy Douglas skribis: > * gnu/packages/containers.scm (crun, conmon, libslirp, slirp4netns, > cni-plugins, podman): Add podman and dependencies. > --- > > I was going to try running some docker containers on my Guix system > today, but I noticed docker was an old version. I decided to try > packaging podman as the daemonless aspect seems appealing and was able > to run a basic alpine image (rootless) after a couple of hours of > putting this together. This is one of my first packages for Guix, so > please give me some feedback--I'm also interested if anyone else would > like to work together on this, because I'm fairly new to Guix and I > haven't used podman before either. This probably needs some more > testing since I only tried a basic scenario. > > For podman to work, I needed to run this: > `sudo mount -t cgroup2 none /sys/fs/cgroup` Woow, that=E2=80=99s a great start, and it=E2=80=99ll certainly be useful t= o many. Overall it LGTM. Here are some minor issues that would be nice addressing: > gnu/packages/containers.scm | 304 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 304 insertions(+) > create mode 100644 gnu/packages/containers.scm We usually have one patch per new package; IWBN if you could split this patch accordingly. Make sure to add =E2=80=98containers.scm=E2=80=99 to =E2=80=98gnu/local.mk= =E2=80=99 too. > + (arguments > + '(#:tests? #f > + #:configure-flags '("--disable-systemd") > + #:phases Please align keywords, as in: '(#:tests? #f #:configure-flags =E2=80=A6 #:phases =E2=80=A6) > + (display (string-append > + "/* autogenerated. */\n#ifndef GIT_= VERSION\n# define GIT_VERSION \"" > + "8e5757a4e68590326dafe8a8b1b4a584b10= a1370" ; refactor this You can write =E2=80=9C,commit=E2=80=9D (read: =E2=80=9Cunquote commit=E2= =80=9D), assuming there=E2=80=99s a =E2=80=98commit=E2=80=99 local variable above. > + (inputs > + `(("libcap" ,libcap) > + ("libseccomp" ,libseccomp) > + ("libyajl" ,libyajl))) > + (native-inputs > + `(("automake" ,automake) > + ("autoreconf" ,autoconf) > + ("git" ,git) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config) > + ("python-3" ,python-3))) IWBN if you could run packages through =E2=80=98guix style=E2=80=99: https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-style.html > + (name "conmon") > + (version "v2.0.30") Please remove =E2=80=9Cv=E2=80=9D from the version number (here and elsewhe= re), and=E2=80=A6 > + (uri (git-reference > + (url "https://github.com/containers/conmon") > + (commit version))) ^ =E2=80=A6 add it here, with (string-append "v" version). > + (home-page "https://gitlab.freedesktop.org/slirp/libslirp") > + (synopsis "User-mode networking library") > + (description > + "libslirp is a user-mode networking library used by virtual machine= s, > +containers or various tools.") > + (license license:non-copyleft))) ;fixme what is this? It=E2=80=99s =E2=80=98license:bsd-3=E2=80=99, per . That=E2=80=99s it. Could you send updated patches? Thank you, and apologies for the delay! Ludo=E2=80=99.