* [bug#54152] [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
@ 2022-02-24 22:53 Pierre Langlois
2022-03-03 22:33 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Langlois @ 2022-02-24 22:53 UTC (permalink / raw)
To: 54152
[-- Attachment #1.1: Type: text/plain, Size: 730 bytes --]
Hi Guix!
Since the GCC update, dovecot doesn't build on aarch64 because the
test_backtrace() tests fail :-/. What happens is the backtrace()
function works but only contains addresses and no real symbol names,
which the tests expect.
I was going to propose disabling them, but doing some searching I found
that debian fixed this by using the -rdynamic linker flag [0], and
indeed, looking at GCC's documentation, they suggest using this flag for
symbols to work [1].
I'm not sure why it works OK on other platforms, this flag might be on
by default there.
OK to push?
[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962630
[1]: https://www.gnu.org/software/libc/manual/html_node/Backtraces.html
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-dovecot-Fix-backtrace-test-on-aarch64.patch --]
[-- Type: text/x-patch, Size: 1183 bytes --]
From 4a282547821196ba6d5ec494334144b528c6c9cd Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Thu, 24 Feb 2022 22:09:45 +0000
Subject: [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
* gnu/packages/mail.scm (dovecot)[arguments]: Add LDFLAGS=-rdynamic to
make-flags.
---
gnu/packages/mail.scm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 7a146a8603..8dce9d55b5 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1900,6 +1900,10 @@ (define-public dovecot
"--localstatedir=/var"
"--with-sqlite" ; not auto-detected
"--with-lucene") ; not auto-detected
+ ;; The -rdynamic linker flag is needed for the backtrace() function to
+ ;; have symbol names rather than just addresses. Dovecot's tests rely
+ ;; on this, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962630.
+ #:make-flags (list "LDFLAGS=-rdynamic")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-file-names
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#54152] [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
2022-02-24 22:53 [bug#54152] [PATCH] gnu: dovecot: Fix backtrace test on aarch64 Pierre Langlois
@ 2022-03-03 22:33 ` Ludovic Courtès
2022-03-03 23:07 ` bug#54152: " Pierre Langlois
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2022-03-03 22:33 UTC (permalink / raw)
To: Pierre Langlois; +Cc: 54152
Hi,
Pierre Langlois <pierre.langlois@gmx.com> skribis:
> From 4a282547821196ba6d5ec494334144b528c6c9cd Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois@gmx.com>
> Date: Thu, 24 Feb 2022 22:09:45 +0000
> Subject: [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
>
> * gnu/packages/mail.scm (dovecot)[arguments]: Add LDFLAGS=-rdynamic to
> make-flags.
LGTM, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#54152: [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
2022-03-03 22:33 ` Ludovic Courtès
@ 2022-03-03 23:07 ` Pierre Langlois
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Langlois @ 2022-03-03 23:07 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: Pierre Langlois, 54152-done
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> From 4a282547821196ba6d5ec494334144b528c6c9cd Mon Sep 17 00:00:00 2001
>> From: Pierre Langlois <pierre.langlois@gmx.com>
>> Date: Thu, 24 Feb 2022 22:09:45 +0000
>> Subject: [PATCH] gnu: dovecot: Fix backtrace test on aarch64.
>>
>> * gnu/packages/mail.scm (dovecot)[arguments]: Add LDFLAGS=-rdynamic to
>> make-flags.
>
> LGTM, thanks!
Thanks Ludo'! Pushed with 74130e73c019d7f2bc0700eca04d797d2645ffa4.
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-03 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 22:53 [bug#54152] [PATCH] gnu: dovecot: Fix backtrace test on aarch64 Pierre Langlois
2022-03-03 22:33 ` Ludovic Courtès
2022-03-03 23:07 ` bug#54152: " Pierre Langlois
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.