From: Aleksandr Vityazev <avityazev@posteo.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59097@debbugs.gnu.org
Subject: [bug#59097] v2[PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode.
Date: Mon, 14 Nov 2022 16:23:49 +0000 [thread overview]
Message-ID: <874jv1qzca.fsf_-_@posteo.org> (raw)
In-Reply-To: <878rkmpmu5.fsf@cbaines.net> (Christopher Baines's message of "Mon, 07 Nov 2022 20:45:42 +0100")
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Hi,
On 2022-11-07, 20:45 +0100, Christopher Baines <mail@cbaines.net> wrote:
> While writing the changelog in the commit is good (so thanks for that),
> it's still often important to put something in the commit about why the
> change is being made.
fixed in patch v2 (in attachment).
> That includes this case, I'm left wondering why this propagated-input is
> being removed?
>
> Note that I'm not asking for some detailed and airtight argument for
> making the change, I just want to why you think this is good to do, even
> if that's just "it doesn't seem to be needed".
I don't know exactly what to do in this situation, since emacs-skempo no
longer has any packages on which it depends, I thought it logical to
remove the propagated-inputs field. Is there any reason why this should
not be done?
--
Best regards,
Aleksandr Vityazev
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: skempo --]
[-- Type: text/x-patch, Size: 1138 bytes --]
From d0a4ad13cf6a2c55690626fbef4da42dbf0d0614 Mon Sep 17 00:00:00 2001
Message-Id: <d0a4ad13cf6a2c55690626fbef4da42dbf0d0614.1668442528.git.avityazev@posteo.org>
From: Aleksandr Vityazev <avityazev@posteo.org>
Date: Mon, 7 Nov 2022 10:51:22 +0300
Subject: [PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode.
* gnu/packages/emacs-xyz.scm (emacs-skempo)[propagated-inputs]:
Remove dependency on emacs-parent-mode.
As of a936f8d9fa0d42f17c64da9d2652a5f3e7c6546a commit skempo
drop dependency for parent-mode.
---
gnu/packages/emacs-xyz.scm | 2 --
1 file changed, 2 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4bbebd3cd6..27039609fd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4772,8 +4772,6 @@ (define-public emacs-skempo
(base32
"0xsr6819qaad0y8rhfrf555c9w7cmgbgkf1a2svgbp7rhhnywl0a"))))
(build-system emacs-build-system)
- (propagated-inputs
- (list emacs-parent-mode))
(home-page "https://github.com/xFA25E/skempo")
(synopsis "Enhancements for skeleton/tempo + abbrev")
(description
--
2.38.1
next prev parent reply other threads:[~2022-11-15 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 7:51 [bug#59097] [PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode Aleksandr Vityazev
2022-11-07 19:45 ` Christopher Baines
2022-11-14 16:23 ` Aleksandr Vityazev [this message]
2022-11-17 11:51 ` bug#59097: v2[PATCH] " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jv1qzca.fsf_-_@posteo.org \
--to=avityazev@posteo.org \
--cc=59097@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.